Go MAEDA
2fe36c4128
Fix RuboCop offense Style/RedundantInterpolationUnfreeze ( #39887 ).
...
Since interpolated strings are always unfrozen in Ruby 3.0 and later, the use of `+""` is now redundant.
git-svn-id: https://svn.redmine.org/redmine/trunk@23001 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-09-01 00:38:01 +00:00
Marius Balteanu
ffce07e785
Start working on replacing old icons with SVG icons ( #23980 ):
...
* Introduces IconsHelper with methods to render SVG icon from a sprite file.
* Adds SVG sprite file with icons mainly from Font Awesome, but also from Material Design Icons and Fluent UI System Icons (based on the work made by Takashi Kato (@tohosaku)).
* Replaces specific icons with new SVG icons.
* Temporarily keep all old CSS icon definitions for backard compatibility.
git-svn-id: https://svn.redmine.org/redmine/trunk@22988 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-29 21:46:40 +00:00
Go MAEDA
fdd90bab2b
Fix RuboCop offenses Style/NegatedIf and Style/NegatedWhile ( #39887 , #7770 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22987 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-25 08:44:33 +00:00
Marius Balteanu
fb37d2e4fa
Upgrade to Rails 7.2.0 ( #36320 ).
...
Patch by Takashi Kato (user:tohosaku).
git-svn-id: https://svn.redmine.org/redmine/trunk@22960 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-20 05:54:30 +00:00
Go MAEDA
6c8b04d6d5
Add configurable setting for copying attachments when copying an issue ( #36197 ).
...
Patch by Yuichi HARADA (user:yui.har).
git-svn-id: https://svn.redmine.org/redmine/trunk@22926 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-14 01:49:53 +00:00
Marius Balteanu
6322650728
Add bulk unlock to user list context menu ( #40913 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22925 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-13 10:21:49 +00:00
Go MAEDA
47d7dd0187
Fix RuboCop offense Style/CollectionCompact ( #39887 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22921 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-11 09:35:32 +00:00
Marius Balteanu
c15c754589
Introduces @valid_watcher?@ check on watchables (@40946).
...
Patch by Jens Krämer (@jkraemer).
git-svn-id: https://svn.redmine.org/redmine/trunk@22916 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-08 21:33:50 +00:00
Marius Balteanu
57743c4145
Permission check based on the type of @watchables@ ( #40946 ).
...
Patch by Jens Krämer (@jkraemer).
git-svn-id: https://svn.redmine.org/redmine/trunk@22915 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-08 21:32:15 +00:00
Marius Balteanu
2d20811f40
Improve watcher list permissions check to explicitly require @view_issue_watchers@ permission ( #40946 ).
...
Patch by Felix Schäfer (@felix).
git-svn-id: https://svn.redmine.org/redmine/trunk@22913 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-08 21:28:24 +00:00
Marius Balteanu
193ca9faee
Add bulk lock feature to user list context menu ( #40913 ).
...
Patch by Mizuki ISHIKAWA (@ishikawa999).
git-svn-id: https://svn.redmine.org/redmine/trunk@22898 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-25 19:03:36 +00:00
Go MAEDA
b803bddb1f
Fix "ArgumentError: Invalid response name: unprocessable_entity" with Rack 3.1.0+ in assert_response ( #39889 ).
...
Rack 3.1.0 changed the symbol for HTTP status code 422 from `:unprocessable_entity` to `:unprocessable_content`.
Due to the change, `assert_response(:unprocessable_entity, ...)` raises ArgumentError with Rack 3.1.0+.
This fix is a follow-up to r22837.
git-svn-id: https://svn.redmine.org/redmine/trunk@22876 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-12 16:09:37 +00:00
Marius Balteanu
38a8adb2a2
Adds description field to custom queries ( #9309 ).
...
Patch by Go MAEDA (@maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@22855 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-04 20:04:45 +00:00
Go MAEDA
c19176a5c4
Reduce an extra SQL query in IssuesController#retrieve_default_query ( #40775 ).
...
Patch by Go MAEDA (@maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@22854 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-04 09:37:34 +00:00
Go MAEDA
c0af36b12d
Dynamic generation of supported code highlighting languages in help section ( #40681 ).
...
Patch by Go MAEDA (@maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@22840 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-19 05:07:42 +00:00
Go MAEDA
a9518e28b8
Fix RuboCop offense Rails/HttpStatus ( #39889 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22837 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-18 05:56:55 +00:00
Marius Balteanu
b4bfb6b581
Replaces use of Digest::MD5 / Digest::SHA1 with ActiveSupport::Digest ( #35217 ).
...
Patch by Jens Krämer (@jkraemer).
git-svn-id: https://svn.redmine.org/redmine/trunk@22816 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-07 18:36:46 +00:00
Marius Balteanu
8b57ffc3c7
Adds the date of the last activity to the list of available columns for Projects ( #23954 ).
...
Patch by Frederico Camara (@fredsdc) and Marius BĂLTEANU (@marius.balteanu).
git-svn-id: https://svn.redmine.org/redmine/trunk@22811 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-03 13:14:18 +00:00
Marius Balteanu
54aa810240
Fix rubocop warning ( #39111 , #40137 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22757 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-03-03 22:24:58 +00:00
Marius Balteanu
38d950df55
Remove current year from source file copyright headers and update year in footer to 2024 ( #40043 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Marius Balteanu
eef8f625c8
Adds route for code highlighting languages page ( #39111 , #40137 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22732 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-25 21:41:14 +00:00
Marius Balteanu
56f3a4dac3
* Remove languages from wiki syntax help files that are identical with en language.
...
* Fall back to the english help page if there is none for the current language.
(#39111 , #40137 ).
git-svn-id: https://svn.redmine.org/redmine/trunk@22721 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-19 20:54:01 +00:00
Marius Balteanu
e80a8bd877
Reorganize all the wiki syntax help files per text formatter (@markdown@, @common_mark@ and @textile@) ( #39111 , #40137 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22720 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-19 20:51:34 +00:00
Marius Balteanu
74a691de19
* Introduces @HelpController@ and a new route @help/wiki_syntax/(:type)@ to serve wiki syntax help files.
...
* Moves all wiki syntax help files to @app/views/help@ and CSS files to asset pipeline.
(#39111 , #40137 ).
git-svn-id: https://svn.redmine.org/redmine/trunk@22719 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-19 20:41:41 +00:00
Marius Balteanu
ec77fe4e3a
Reverts r22717 ( #39111 , #40137 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22718 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-19 20:28:15 +00:00
Marius Balteanu
609cc9221e
* Moves all wiki syntax files from @public/help@ to @app/views/help/wiki_syntax@.
...
* Adds route to serve wiki syntax help files.
* Moves wiki syntax CSS files to asset pipeline.
(#39111 , #40137 ).
git-svn-id: https://svn.redmine.org/redmine/trunk@22717 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-19 20:24:33 +00:00
Marius Balteanu
b010054d69
Replaces @URI.parse@ with @Addressable::URI.parse(url)@ to enhance robustness of @validate_back_url@ ( #31831 ).
...
Patch by Go MAEDA (@maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@22710 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-13 23:17:09 +00:00
Marius Balteanu
353ac52d47
Stop appending the utf8 checkmark parameter to form URLs ( #40190 ).
...
Patch by Go MAEDA (@maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@22709 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-13 23:13:49 +00:00
Marius Balteanu
5676499ceb
Remove deprecated @status=@ param used to get all users. @status=*@ should be used now. ( #40124 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22635 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-25 15:38:39 +00:00
Marius Balteanu
7ad46f7e04
Adds deprecation warning when an empty status param (status=) is used to get all users from API ( #40099 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22633 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-25 15:31:49 +00:00
Marius Balteanu
e07452e921
Remove code that is no longer needed as a result of asset pipeline implementation ( #39111 ).
...
Patch by Takashi Kato (@tohosaku).
git-svn-id: https://svn.redmine.org/redmine/trunk@22627 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-25 05:40:45 +00:00
Marius Balteanu
f803778cde
Restores API compatibility to legacy status when status param is sent blank (@status=@) and it should return all users ( #40099 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22625 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-25 05:10:51 +00:00
Go MAEDA
63391766a9
Remove unnecessary use of instance variables in CSV and Atom response handlers ( #32985 ).
...
Contributed by Ko Nagase (@sanak).
git-svn-id: https://svn.redmine.org/redmine/trunk@22622 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-24 02:49:38 +00:00
Marius Balteanu
13aeb797cf
Use ApplicationRecord instead of ActiveRecord::Base ( #38975 ).
...
Patch by Minoru Maeda (@maeda-m).
git-svn-id: https://svn.redmine.org/redmine/trunk@22619 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-23 11:52:38 +00:00
Marius Balteanu
c517664985
Reverts r22438 ( #35189 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22616 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-23 01:05:38 +00:00
Go MAEDA
52a55f407b
Replace String#sub with delete_prefix / delete_suffix ( #40008 ).
...
Patch by Go MAEDA (@maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@22596 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-08 01:04:37 +00:00
Marius Balteanu
fe9fd97f6d
Explicitly render a 404 on non-JS requests to messages#quote ( #39999 ).
...
Patch by Holger Just (@hjust).
git-svn-id: https://svn.redmine.org/redmine/trunk@22584 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-03 01:19:25 +00:00
Go MAEDA
06f9567415
Optimize loading of journals, relations, and allowed_statuses in IssuesController#show for API requests ( #39993 ).
...
Patch by Go MAEDA (@maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@22582 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-01 11:28:48 +00:00
Marius Balteanu
539d0f867e
Explicitly render a 404 on non-JS requests to @watchers#new@ ( #39894 ).
...
Patch by @hjust.
git-svn-id: https://svn.redmine.org/redmine/trunk@22538 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-21 06:47:32 +00:00
Go MAEDA
380444f085
Fix RuboCop offense Performance/StringIdentifierArgument ( #39888 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22535 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-20 09:23:05 +00:00
Go MAEDA
c8640d7ffc
Fix RuboCop offense Style/HashEachMethods ( #39887 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22532 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-20 08:13:48 +00:00
Go MAEDA
d9ef2d191c
Fix RuboCop offense Lint/SymbolConversion ( #39887 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22531 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-20 07:16:35 +00:00
Marius Balteanu
54afecb2ca
Revert r21883 which was an workaround for #37626 ( #37732 , #36320 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22489 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-11-29 07:11:50 +00:00
Marius Balteanu
7b911245d3
Updates Rails to 7.1.2 ( #36320 ).
...
Patch by Takashi Kato.
git-svn-id: https://svn.redmine.org/redmine/trunk@22488 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-11-27 20:58:55 +00:00
Go MAEDA
384cde0a46
New email notification option "For any event on my bookmarked projects" ( #35189 ).
...
Patch by Mizuki ISHIKAWA.
git-svn-id: https://svn.redmine.org/redmine/trunk@22438 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-11-16 08:32:41 +00:00
Marius Balteanu
f0f1d49b56
Remove @rss_*@ deprecated methods ( #36806 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22416 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-11-06 20:36:48 +00:00
Go MAEDA
63188014b0
Replace hardcoded issues count check with limit variable in IssuesController#retrieve_previous_and_next_issue_ids ( #39380 ).
...
Patch by Go MAEDA.
git-svn-id: https://svn.redmine.org/redmine/trunk@22415 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-10-31 13:02:09 +00:00
Go MAEDA
c6fdc7db86
Redirect to repositories#show after repository#fetch_changesets to avoid the user-visible browser URL ( #39238 ).
...
Patch by Holger Just.
git-svn-id: https://svn.redmine.org/redmine/trunk@22414 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-10-31 12:45:15 +00:00
Go MAEDA
6713c882b4
Fix reversed display of default queue adapter check ( #36695 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22403 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-10-30 09:11:34 +00:00
Go MAEDA
36a7932003
Fix related issues count not updating after deleting one of the related issues ( #38493 ).
...
Patch by Takashi Kato.
git-svn-id: https://svn.redmine.org/redmine/trunk@22395 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-10-29 07:31:01 +00:00