meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-01-31 19:47:14 +00:00
Code Issues Releases Wiki Activity

Optimize loading of journals, relations, and allowed_statuses in IssuesController#show for API requests (#39993).

Browse Source 
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22582 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA 2024-01-01 11:28:48 +00:00
parent ccee193f38
commit 06f9567415
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
app/controllers/issues_controller.rb
View File

@ -93,14 +93,16 @@ class IssuesController < ApplicationController
end
def show
@journals = @issue.visible_journals_with_index
@has_changesets = @issue.changesets.visible.preload(:repository, :user).exists? unless api_request?
@relations =
@issue.relations.
select do |r|
r.other_issue(@issue) && r.other_issue(@issue).visible?
end
@journals.reverse! if User.current.wants_comments_in_reverse_order?
if !api_request? || include_in_api_response?('journals')
@journals = @issue.visible_journals_with_index
@journals.reverse! if User.current.wants_comments_in_reverse_order?
end
if !api_request? || include_in_api_response?('relations')
@relations = @issue.relations.select {|r| r.other_issue(@issue)&.visible?}
end
if !api_request? || include_in_api_response?('allowed_statuses')
@allowed_statuses = @issue.new_statuses_allowed_to(User.current)
end
if User.current.allowed_to?(:view_time_entries, @project)
Issue.load_visible_spent_hours([@issue])
@ -109,16 +111,15 @@ class IssuesController < ApplicationController
respond_to do |format|
format.html do
@allowed_statuses = @issue.new_statuses_allowed_to(User.current)
@priorities = IssuePriority.active
@time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
@time_entries = @issue.time_entries.visible.preload(:activity, :user)
@relation = IssueRelation.new
@has_changesets = @issue.changesets.visible.preload(:repository, :user).exists?
retrieve_previous_and_next_issue_ids
render :template => 'issues/show'
end
format.api do
@allowed_statuses = @issue.new_statuses_allowed_to(User.current)
if include_in_api_response?('changesets')
@changesets = @issue.changesets.visible.preload(:repository, :user).to_a
@changesets.reverse! if User.current.wants_comments_in_reverse_order?