meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-01-31 19:47:14 +00:00
Code Issues Releases Wiki Activity

Cache the result of Journal#attachments (#39847).

Browse Source 
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22581 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA 2023-12-31 02:02:31 +00:00
parent a6509d658b
commit ccee193f38
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/models/journal.rb
View File

@ -142,8 +142,10 @@ class Journal < ActiveRecord::Base
end
def attachments
ids = details.select {|d| d.property == 'attachment' && d.value.present?}.map(&:prop_key)
Attachment.where(id: ids).sort_by {|a| ids.index(a.id.to_s)}
@attachments ||= begin
ids = details.select {|d| d.property == 'attachment' && d.value.present?}.map(&:prop_key)
ids.empty? ? [] : Attachment.where(id: ids).sort_by {|a| ids.index(a.id.to_s)}
end
end
def visible?(*args)