Marius Balteanu
c15c754589
Introduces @valid_watcher?@ check on watchables (@40946).
...
Patch by Jens Krämer (@jkraemer).
git-svn-id: https://svn.redmine.org/redmine/trunk@22916 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-08 21:33:50 +00:00
Marius Balteanu
57743c4145
Permission check based on the type of @watchables@ ( #40946 ).
...
Patch by Jens Krämer (@jkraemer).
git-svn-id: https://svn.redmine.org/redmine/trunk@22915 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-08 21:32:15 +00:00
Marius Balteanu
f9f486bdd0
Check view watchers permission when copying issues ( #40946 ).
...
Patch by Jens Kraemer (@jkraemer).
git-svn-id: https://svn.redmine.org/redmine/trunk@22914 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-08 21:30:36 +00:00
Marius Balteanu
2d20811f40
Improve watcher list permissions check to explicitly require @view_issue_watchers@ permission ( #40946 ).
...
Patch by Felix Schäfer (@felix).
git-svn-id: https://svn.redmine.org/redmine/trunk@22913 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-08 21:28:24 +00:00
Marius Balteanu
c1eff66f68
Truncate git authors to 255 characters ( #40948 ).
...
The committer column in the database allows max 255 characters. With longer authors, this would result in a schema violation. By manually truncating the author field, we can avoid this.
Patch by Holger Just (@hjust).
git-svn-id: https://svn.redmine.org/redmine/trunk@22910 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-08 20:35:16 +00:00
Go MAEDA
2b786a6f48
Spent hours ignoring "Time Span Format" Setting on several pages ( #40924 ).
...
Patch by Go MAEDA (@maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@22902 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-30 14:37:12 +00:00
Go MAEDA
578c53a932
Disable custom query links while loading to prevent multiple requests ( #40901 ).
...
Patch by Mizuki ISHIKAWA (@ishikawa999).
git-svn-id: https://svn.redmine.org/redmine/trunk@22901 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-27 08:41:45 +00:00
Go MAEDA
f82d8314d9
Expose project updated_on column and filter in project query ( #40829 ).
...
Patch by Felix Schäfer (@felix).
git-svn-id: https://svn.redmine.org/redmine/trunk@22899 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-27 04:46:27 +00:00
Marius Balteanu
193ca9faee
Add bulk lock feature to user list context menu ( #40913 ).
...
Patch by Mizuki ISHIKAWA (@ishikawa999).
git-svn-id: https://svn.redmine.org/redmine/trunk@22898 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-25 19:03:36 +00:00
Go MAEDA
b5078e314a
Creating a new issue fails with an internal error if no issue priorities are defined ( #40860 ).
...
Patch by Holger Just (@hjust).
git-svn-id: https://svn.redmine.org/redmine/trunk@22895 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-25 02:09:40 +00:00
Go MAEDA
719b0ce615
Reject passwords that are the same as login, first name, last name, or email ( #37279 ).
...
Patch by Go MAEDA (@maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@22888 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-21 05:32:46 +00:00
Go MAEDA
2706019f09
Upgrade jQuery to 3.7.1 and jQuery UI to 1.13.3 ( #40853 , #40864 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22887 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-20 04:11:39 +00:00
Go MAEDA
07307140b9
Fix misalignment issue when displaying the table of contents (TOC) on the right of wiki page ( #34473 ).
...
Patch by Mizuki ISHIKAWA (@ishikawa999).
git-svn-id: https://svn.redmine.org/redmine/trunk@22885 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-19 14:06:08 +00:00
Go MAEDA
b3308d126a
Optimize Version#behind_schedule? by avoiding the call to completed_percent when due_date or start_date is nil ( #40798 ).
...
Patch by Go MAEDA (@maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@22882 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-17 07:10:29 +00:00
Go MAEDA
35aa00f7ac
Optimize FixedIssuesExtension#closed_percent by bypassing issues_progress when all issues are closed ( #40798 ).
...
Patch by Go MAEDA (@maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@22881 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-17 06:57:57 +00:00
Go MAEDA
c132b178a1
Optimize Version model by reducing redundant SQL count queries ( #40798 ).
...
Patch by Go MAEDA (@maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@22880 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-17 06:55:36 +00:00
Go MAEDA
ddde0ff47d
Fix RuboCop offense Rails/ActiveRecordCallbacksOrder ( #39889 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22879 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-17 03:11:08 +00:00
Go MAEDA
af6a627d20
Revisions count is wrong on the wiki content page ( #40655 ).
...
Contributed by Karel Pičman (@picman).
git-svn-id: https://svn.redmine.org/redmine/trunk@22877 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-13 03:06:04 +00:00
Go MAEDA
b803bddb1f
Fix "ArgumentError: Invalid response name: unprocessable_entity" with Rack 3.1.0+ in assert_response ( #39889 ).
...
Rack 3.1.0 changed the symbol for HTTP status code 422 from `:unprocessable_entity` to `:unprocessable_content`.
Due to the change, `assert_response(:unprocessable_entity, ...)` raises ArgumentError with Rack 3.1.0+.
This fix is a follow-up to r22837.
git-svn-id: https://svn.redmine.org/redmine/trunk@22876 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-12 16:09:37 +00:00
Go MAEDA
c1335f5126
Suppress RuboCop false positive for Security/Open ( #39887 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22862 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-06 01:20:23 +00:00
Go MAEDA
f9eb77227a
Fix RuboCop offense Naming/MemoizedInstanceVariableName ( #37862 , #1671 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22860 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-05 08:21:59 +00:00
Marius Balteanu
82c88b3700
Adds estimated remaining time to version page ( #37862 , #1671 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22858 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-04 20:17:01 +00:00
Marius Balteanu
d9ca32b9d1
Move logic for estimated remaining hours from @QueryColumn@ to @Issue@ ( #37862 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22857 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-04 20:16:08 +00:00
Marius Balteanu
38a8adb2a2
Adds description field to custom queries ( #9309 ).
...
Patch by Go MAEDA (@maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@22855 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-04 20:04:45 +00:00
Go MAEDA
c19176a5c4
Reduce an extra SQL query in IssuesController#retrieve_default_query ( #40775 ).
...
Patch by Go MAEDA (@maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@22854 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-04 09:37:34 +00:00
Go MAEDA
a73eb69648
Introduce configuration for done ratio options interval ( #31756 ).
...
Patch by Go MAEDA (@maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@22849 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-29 15:06:28 +00:00
Marius Balteanu
3acc94914f
Link "Last activity" column to project activity page ( #40706 , #23954 ).
...
Patch by Go MAEDA (@maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@22848 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-28 17:40:09 +00:00
Go MAEDA
a4e7d34cb7
Add updated_on and updated_by fields to Issues API journal response ( #40449 ).
...
Contributed by Thomas Hoffmann (@ThomasHo).
git-svn-id: https://svn.redmine.org/redmine/trunk@22846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-27 07:41:57 +00:00
Go MAEDA
c9fda88a40
Fix duplicated alt and title attributes for attached images in Textile formatter ( #40650 ).
...
Patch by Katsuya HIDAKA (@hidakatsuya).
git-svn-id: https://svn.redmine.org/redmine/trunk@22845 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-24 02:52:32 +00:00
Go MAEDA
b42d7984b1
Fix RuboCop offense Style/SuperArguments ( #39887 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22842 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-23 11:25:16 +00:00
Go MAEDA
c0af36b12d
Dynamic generation of supported code highlighting languages in help section ( #40681 ).
...
Patch by Go MAEDA (@maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@22840 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-19 05:07:42 +00:00
Go MAEDA
a9518e28b8
Fix RuboCop offense Rails/HttpStatus ( #39889 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22837 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-18 05:56:55 +00:00
Go MAEDA
9189837e7b
Ignore statuses in Project#rolled_up_statuses which only have an identity transition defined ( #40693 ).
...
Patch by Holger Just (@hjust).
git-svn-id: https://svn.redmine.org/redmine/trunk@22833 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-16 07:20:19 +00:00
Go MAEDA
250414c353
Explicitly reference table name in Project#like scope to avoid ambiguity ( #40691 ).
...
Patch by Vincent Robert (@Nanego).
git-svn-id: https://svn.redmine.org/redmine/trunk@22830 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-14 08:04:04 +00:00
Go MAEDA
3761510af8
Fix slow display of projects list when including project description column ( #40610 ).
...
Patch by Go MAEDA (@maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@22829 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-14 07:44:05 +00:00
Go MAEDA
fb9bc74dd4
Fix RuboCop offense Style/RedundantSelfAssignment ( #40412 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22826 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-13 07:45:20 +00:00
Marius Balteanu
47099ccd3a
Fixes issue list filter "Watched by: me" only shows issues watched via group for projects with the @view_issue_watchers@ permission ( #40412 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22819 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-11 08:35:27 +00:00
Marius Balteanu
b4bfb6b581
Replaces use of Digest::MD5 / Digest::SHA1 with ActiveSupport::Digest ( #35217 ).
...
Patch by Jens Krämer (@jkraemer).
git-svn-id: https://svn.redmine.org/redmine/trunk@22816 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-07 18:36:46 +00:00
Marius Balteanu
8b57ffc3c7
Adds the date of the last activity to the list of available columns for Projects ( #23954 ).
...
Patch by Frederico Camara (@fredsdc) and Marius BĂLTEANU (@marius.balteanu).
git-svn-id: https://svn.redmine.org/redmine/trunk@22811 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-03 13:14:18 +00:00
Marius Balteanu
1a96ee225d
Fixes RuboCop offense Performance/Sum ( #24457 , #4682 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22805 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-02 21:35:16 +00:00
Marius Balteanu
cd8d4fe444
Progress of version should be calculated the same way as parent tasks ( #24457 , #4682 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22803 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-02 20:58:03 +00:00
Go MAEDA
6f82abf463
Fix RuboCop offense Style/SuperWithArgsParentheses ( #37862 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@22801 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-01 09:21:47 +00:00
Marius Balteanu
6fa12a95ab
Adds estimated remaining hours issue query column calculated based on estimated time and done ratio ( #37862 ).
...
Patch by Jens Krämer (@jkraemer).
git-svn-id: https://svn.redmine.org/redmine/trunk@22800 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-01 07:49:29 +00:00
Marius Balteanu
61c7d539dc
Adds Watcher list to the list of available query columns for issues ( #29894 ).
...
Patch by Felix Schäfer (@felix).
git-svn-id: https://svn.redmine.org/redmine/trunk@22793 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-04-28 07:26:29 +00:00
Marius Balteanu
ab2f00f2eb
Fixes that watcher groups on new issue form get dereferenced on validation error ( #40410 , #40555 ).
...
Patch by Felix Schäfer (@felix) and Kenta Kumojima (@kumojima).
git-svn-id: https://svn.redmine.org/redmine/trunk@22792 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-04-28 07:12:32 +00:00
Marius Balteanu
f94370962a
Focus on the textarea after clicking the Edit Journal button ( #40556 ).
...
Patch by Yasu Saku (@skys).
git-svn-id: https://svn.redmine.org/redmine/trunk@22791 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-04-28 06:53:52 +00:00
Marius Balteanu
b5c48c1d97
Adds an option to send email notification when an attachment is added ( #40569 ).
...
Patch by Mizuki ISHIKAWA (#ishikawa999).
git-svn-id: https://svn.redmine.org/redmine/trunk@22790 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-04-28 06:40:12 +00:00
Go MAEDA
e4fcfc6990
Fix issue where descriptions in the issues list ignore CommonMark Markdown table alignment ( #40515 ).
...
Contributed by Takenori TAKAKI (@takenory).
git-svn-id: https://svn.redmine.org/redmine/trunk@22787 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-04-23 02:58:55 +00:00
Marius Balteanu
d03009e9a0
Fix incorrect icon image path for DatePicker button ( #40559 , #39111 ).
...
Patch by Katsuya HIDAKA (hidakatsuya).
git-svn-id: https://svn.redmine.org/redmine/trunk@22784 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-04-16 18:58:45 +00:00
Marius Balteanu
49b7b30c5d
Fix incorrect icon image paths on Textile help page ( #40559 , #40137 , #39111 ).
...
Patch by Katsuya HIDAKA (hidakatsuya).
git-svn-id: https://svn.redmine.org/redmine/trunk@22783 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-04-16 18:57:48 +00:00