meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-01-31 19:47:14 +00:00
Code Issues Releases Wiki Activity

Fixes RuboCop offense Performance/Sum (#24457, #4682).

Browse Source 
git-svn-id: https://svn.redmine.org/redmine/trunk@22805 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Marius Balteanu 2024-05-02 21:35:16 +00:00
parent 3822b633ef
commit 1a96ee225d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/models/version.rb
View File

@ -80,7 +80,7 @@ module FixedIssuesExtension
if @estimated_average.nil?
issues_with_total_estimated_hours = select {|c| c.total_estimated_hours.to_f > 0.0}
if issues_with_total_estimated_hours.any?
average = issues_with_total_estimated_hours.map(&:total_estimated_hours).sum.to_f / issues_with_total_estimated_hours.count
average = issues_with_total_estimated_hours.sum(&:total_estimated_hours).to_f / issues_with_total_estimated_hours.count
else
average = 1.0
end
@ -100,12 +100,12 @@ module FixedIssuesExtension
@issues_progress[open] ||= begin
progress = 0
if count > 0
done = open(open).map {|c|
done = open(open).sum do |c|
estimated = c.total_estimated_hours.to_f
estimated = estimated_average unless estimated > 0.0
ratio = c.closed? ? 100 : (c.done_ratio || 0)
estimated * ratio
}.sum
end
progress = done / (estimated_average * count)
end
progress