meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-24 01:11:12 +00:00
Code Issues Releases Wiki Activity
18,462 Commits 32 Branches 194 Tags
Commit Graph

3277 Commits

Author SHA1 Message Date
Go MAEDA
52deba3abf Replace custom email normalization logic with Rails' normalizes method (#29208). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23064 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-09-20 01:58:08 +00:00
Go MAEDA
94d9a2337b Add "Author / Previous assignee" group to assignee dropdown in issue form (#16045). 
Patch by Luka Lüdicke (user:dkd-luedicke), Mizuki ISHIKAWA (user:ishikawa999), and Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23059 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-09-15 06:31:30 +00:00
Go MAEDA
68121841b5 Fix NoMethodError in Issue#blocked? due to invalid issue_from_id in Issue#relations_from (#8539). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23048 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-09-10 00:55:32 +00:00
Go MAEDA
b7120cfe3a Remove unnecessary rubocop:disable directive for Style/EmptyLiteral (#39887). 
RuboCop’s Style/EmptyLiteral false positive for `Hash.new([])` was resolved in RuboCop 1.66.1. This commit updates the RuboCop version to 1.66.1 and removes the now-unnecessary `rubocop:disable` directives.


git-svn-id: https://svn.redmine.org/redmine/trunk@23013 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-09-05 00:49:54 +00:00
Go MAEDA
d24d11a682 Fix RuboCop offense Style/StringChars (#39887). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23009 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-09-01 06:05:39 +00:00
Go MAEDA
eee5d73ee1 Revert r23002 (#39887). 
The change caused a test failure:

```
Failure:
UserTest#test_accessing_projects_by_role_with_no_projects_should_return_an_empty_array [test/unit/user_test.rb:1048]:
Expected: []
  Actual: nil
```


git-svn-id: https://svn.redmine.org/redmine/trunk@23006 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-09-01 01:33:00 +00:00
Go MAEDA
2190a4b417 Disable RuboCop Lint/InterpolationCheck for USER_FORMATS in app/models/user.rb (#39887). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23005 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-09-01 01:02:38 +00:00
Go MAEDA
987a36281a Fix RuboCop offense Style/EmptyLiteral (#39887). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23002 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-09-01 00:42:33 +00:00
Go MAEDA
2fe36c4128 Fix RuboCop offense Style/RedundantInterpolationUnfreeze (#39887). 
Since interpolated strings are always unfrozen in Ruby 3.0 and later, the use of `+""` is now redundant.


git-svn-id: https://svn.redmine.org/redmine/trunk@23001 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-09-01 00:38:01 +00:00
Go MAEDA
8da72cb712 Fix precision issues in TimeEntry#hours calculation by returning Rational instead of Float (#40914). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23000 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-31 09:26:50 +00:00
Go MAEDA
fdd90bab2b Fix RuboCop offenses Style/NegatedIf and Style/NegatedWhile (#39887, #7770). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22987 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-25 08:44:33 +00:00
Go MAEDA
c2eb20e434 Fix RuboCop offense Style/ClassEqualityComparison (#39887). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22978 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-21 13:45:13 +00:00
Go MAEDA
9cc3542fa1 Introduce active? method to Group via Principal model (#27510). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22976 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-21 08:05:59 +00:00
Go MAEDA
643b4ebb08 Add filters for "Author's group" and "Author's role" to issues list (#7867). 
Patch by Takenori TAKAKI (user:takenory).


git-svn-id: https://svn.redmine.org/redmine/trunk@22975 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-21 07:47:27 +00:00
Go MAEDA
93645a279e Use anonymous block forwarding introduced in Ruby 3.1 (#38585). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22973 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-21 00:46:15 +00:00
Go MAEDA
c069ea3a24 Use Array#intersect? introduced in Ruby 3.1 (#38585). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22972 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-20 23:40:58 +00:00
Go MAEDA
65597ec1cf Add filters for "User's group" and "User's role" to Spent time list (#41053). 
Patch by Takenori TAKAKI (user:takenory).


git-svn-id: https://svn.redmine.org/redmine/trunk@22958 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-16 02:05:25 +00:00
Go MAEDA
b3d1deeece Fix RuboCop offense Layout/SpaceInsideParens, one of the offenses enabled in rubocop-rails-omakase (#39887). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22954 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-12 08:45:54 +00:00
Go MAEDA
74e2262efb Fix RuboCop offense Layout/EmptyLinesAroundMethodBody, one of the offenses enabled in rubocop-rails-omakase (#39887). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22950 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-12 07:46:58 +00:00
Go MAEDA
174c237c70 Fix incorrect sorting of users grouped by status in issue filters for administrators (#41079). 
Patch by Vladislav Moiseev (user:vladdy.moses).


git-svn-id: https://svn.redmine.org/redmine/trunk@22947 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-11 08:30:40 +00:00
Go MAEDA
fded8025d5 Add project identifier to List-Id header in notification emails (#13359). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22944 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-26 03:19:22 +00:00
Go MAEDA
0247ebb394 Set default age parameter for User.prune method to 30 days (#41023). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22938 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-19 08:26:13 +00:00
Go MAEDA
ee31bf8fe9 Add an option to render Integer and Float custom fields with thousands delimiters (#39997). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22935 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-18 04:56:20 +00:00
Marius Balteanu
f9f486bdd0 Check view watchers permission when copying issues (#40946). 
Patch by Jens Kraemer (@jkraemer).


git-svn-id: https://svn.redmine.org/redmine/trunk@22914 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-08 21:30:36 +00:00
Marius Balteanu
c1eff66f68 Truncate git authors to 255 characters (#40948). 
The committer column in the database allows max 255 characters. With longer authors, this would result in a schema violation. By manually truncating the author field, we can avoid this.

Patch by Holger Just (@hjust). 



git-svn-id: https://svn.redmine.org/redmine/trunk@22910 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-08 20:35:16 +00:00
Go MAEDA
f82d8314d9 Expose project updated_on column and filter in project query (#40829). 
Patch by Felix Schäfer (@felix).


git-svn-id: https://svn.redmine.org/redmine/trunk@22899 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-27 04:46:27 +00:00
Go MAEDA
b5078e314a Creating a new issue fails with an internal error if no issue priorities are defined (#40860). 
Patch by Holger Just (@hjust).


git-svn-id: https://svn.redmine.org/redmine/trunk@22895 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-25 02:09:40 +00:00
Go MAEDA
719b0ce615 Reject passwords that are the same as login, first name, last name, or email (#37279). 
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22888 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-21 05:32:46 +00:00
Go MAEDA
b3308d126a Optimize Version#behind_schedule? by avoiding the call to completed_percent when due_date or start_date is nil (#40798). 
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22882 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-17 07:10:29 +00:00
Go MAEDA
35aa00f7ac Optimize FixedIssuesExtension#closed_percent by bypassing issues_progress when all issues are closed (#40798). 
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22881 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-17 06:57:57 +00:00
Go MAEDA
c132b178a1 Optimize Version model by reducing redundant SQL count queries (#40798). 
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22880 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-17 06:55:36 +00:00
Go MAEDA
ddde0ff47d Fix RuboCop offense Rails/ActiveRecordCallbacksOrder (#39889). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22879 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-17 03:11:08 +00:00
Go MAEDA
c1335f5126 Suppress RuboCop false positive for Security/Open (#39887). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22862 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-06 01:20:23 +00:00
Go MAEDA
f9eb77227a Fix RuboCop offense Naming/MemoizedInstanceVariableName (#37862, #1671). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22860 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-05 08:21:59 +00:00
Marius Balteanu
82c88b3700 Adds estimated remaining time to version page (#37862, #1671). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22858 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-04 20:17:01 +00:00
Marius Balteanu
d9ca32b9d1 Move logic for estimated remaining hours from @QueryColumn@ to @Issue@ (#37862). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22857 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-04 20:16:08 +00:00
Marius Balteanu
38a8adb2a2 Adds description field to custom queries (#9309). 
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22855 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-04 20:04:45 +00:00
Go MAEDA
b42d7984b1 Fix RuboCop offense Style/SuperArguments (#39887). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22842 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-05-23 11:25:16 +00:00
Go MAEDA
9189837e7b Ignore statuses in Project#rolled_up_statuses which only have an identity transition defined (#40693). 
Patch by Holger Just (@hjust).


git-svn-id: https://svn.redmine.org/redmine/trunk@22833 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-05-16 07:20:19 +00:00
Go MAEDA
250414c353 Explicitly reference table name in Project#like scope to avoid ambiguity (#40691). 
Patch by Vincent Robert (@Nanego).


git-svn-id: https://svn.redmine.org/redmine/trunk@22830 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-05-14 08:04:04 +00:00
Go MAEDA
fb9bc74dd4 Fix RuboCop offense Style/RedundantSelfAssignment (#40412). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22826 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-05-13 07:45:20 +00:00
Marius Balteanu
47099ccd3a Fixes issue list filter "Watched by: me" only shows issues watched via group for projects with the @view_issue_watchers@ permission (#40412). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22819 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-05-11 08:35:27 +00:00
Marius Balteanu
b4bfb6b581 Replaces use of Digest::MD5 / Digest::SHA1 with ActiveSupport::Digest (#35217). 
Patch by Jens Krämer (@jkraemer).

git-svn-id: https://svn.redmine.org/redmine/trunk@22816 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-05-07 18:36:46 +00:00
Marius Balteanu
8b57ffc3c7 Adds the date of the last activity to the list of available columns for Projects (#23954). 
Patch by Frederico Camara (@fredsdc) and Marius BĂLTEANU (@marius.balteanu).

git-svn-id: https://svn.redmine.org/redmine/trunk@22811 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-05-03 13:14:18 +00:00
Marius Balteanu
1a96ee225d Fixes RuboCop offense Performance/Sum (#24457, #4682). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22805 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-05-02 21:35:16 +00:00
Marius Balteanu
cd8d4fe444 Progress of version should be calculated the same way as parent tasks (#24457, #4682). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22803 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-05-02 20:58:03 +00:00
Go MAEDA
6f82abf463 Fix RuboCop offense Style/SuperWithArgsParentheses (#37862). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22801 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-05-01 09:21:47 +00:00
Marius Balteanu
6fa12a95ab Adds estimated remaining hours issue query column calculated based on estimated time and done ratio (#37862). 
Patch by Jens Krämer (@jkraemer).

git-svn-id: https://svn.redmine.org/redmine/trunk@22800 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-05-01 07:49:29 +00:00
Marius Balteanu
61c7d539dc Adds Watcher list to the list of available query columns for issues (#29894). 
Patch by Felix Schäfer (@felix).

git-svn-id: https://svn.redmine.org/redmine/trunk@22793 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-04-28 07:26:29 +00:00
Marius Balteanu
b5c48c1d97 Adds an option to send email notification when an attachment is added (#40569). 
Patch by  Mizuki ISHIKAWA (#ishikawa999).

git-svn-id: https://svn.redmine.org/redmine/trunk@22790 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-04-28 06:40:12 +00:00