1
0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-29 11:49:37 +00:00

8158 Commits

Author SHA1 Message Date
Go MAEDA
62a930cc65 Fix RuboCop offense Performance/RedundantMatch (#38146).
git-svn-id: https://svn.redmine.org/redmine/trunk@22032 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-11 13:31:57 +00:00
Go MAEDA
dbf8c1d921 Fix RuboCop offense Performance/RedundantEqualityComparisonBlock (#38146).
git-svn-id: https://svn.redmine.org/redmine/trunk@22031 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-11 13:30:25 +00:00
Go MAEDA
70ef2a3db1 Fix RuboCop offense Performance/ConstantRegexp (#38146).
git-svn-id: https://svn.redmine.org/redmine/trunk@22029 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-11 13:26:31 +00:00
Go MAEDA
3942177f49 Fix RuboCop offense Performance/BlockGivenWithExplicitBlock (#38146).
git-svn-id: https://svn.redmine.org/redmine/trunk@22027 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-11 13:20:52 +00:00
Go MAEDA
1c937f1e23 Use Group.visible instead of manual visibility check in GroupsController (#38144).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@22023 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-04 01:05:20 +00:00
Go MAEDA
025323f5ba Add guard clause to time_tag method to handle nil time (#38139).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22022 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-02 06:56:47 +00:00
Go MAEDA
21ca0e3d0a Fix RuboCop offense Style/MinMaxComparison (#36919).
git-svn-id: https://svn.redmine.org/redmine/trunk@22019 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-02 06:10:53 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Go MAEDA
f186e614ee Ruby 3.2: Changeset.normalize_comments raises Encoding::CompatibilityError if the string contains an invalid UTF-8 byte sequence (#38099, #38100).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22000 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-12-26 01:36:44 +00:00
Go MAEDA
cec30f9a05 Fix RuboCop offense Performance/StringInclude in app/controllers/imports_controller.rb (#37247).
git-svn-id: https://svn.redmine.org/redmine/trunk@21999 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-12-25 07:55:14 +00:00
Go MAEDA
361b285250 Do not break when setting enabled_module_names on a project without a default_member_role (#38064).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21994 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-12-21 02:25:47 +00:00
Go MAEDA
f094471ff5 Fix shadowing variable in ApplicationHelper#textilizable (#15667).
Patch by Ilya S.


git-svn-id: https://svn.redmine.org/redmine/trunk@21991 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-12-16 07:59:35 +00:00
Marius Balteanu
0b72c5bfa7 Fix mentioning users with certain characters renders incorrectly (#37755).
Patch Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21986 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-12-03 13:21:17 +00:00
Marius Balteanu
c0f60e5feb Fix groups added to watchers are not shown as links (#37958).
Patch by Mizuki ISHIKAWA.



git-svn-id: https://svn.redmine.org/redmine/trunk@21967 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-11-28 22:59:05 +00:00
Marius Balteanu
7c80efae71 Query display types should accept only known types (#37925).
Patch by Alexander Meindl.


git-svn-id: https://svn.redmine.org/redmine/trunk@21965 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-11-28 22:41:53 +00:00
Go MAEDA
0f2378c121 Reverts r21958 and r21959 (#1739).
git-svn-id: https://svn.redmine.org/redmine/trunk@21960 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-11-18 08:17:50 +00:00
Go MAEDA
b3e4214989 Add the ability to change the author of an issue (#1739).
Patch by Vladimir Kovacik, Jiri Stepanek, Aighan Pacobilch, Olivier Houdas, Takenori TAKAKI, and Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21958 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-11-16 09:24:17 +00:00
Go MAEDA
fcf1352c6b Redirect to container URL in case of error in attachments#download_all (#37880).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21948 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-11-03 05:17:48 +00:00
Go MAEDA
693a8bae50 Don't display an unnecessary closing li element when there is no "Next" button on the activity page. (#37875).
Patch by Alexander Meindl.


git-svn-id: https://svn.redmine.org/redmine/trunk@21942 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-11-02 01:47:32 +00:00
Go MAEDA
0f8c36869e Disallow all in /robots.txt if login is required (#37807).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21940 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-11-01 03:28:08 +00:00
Go MAEDA
afbec488c4 Always allow access to /robots.txt for Anonymous (#37807).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21939 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-11-01 03:26:15 +00:00
Go MAEDA
dcdf27b895 Render all visible projects in robots.txt (including closed projects) (#37807).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21938 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-11-01 03:24:17 +00:00
Go MAEDA
e1928aaf19 Read-only field permission for the project field is ignored if the current project has subprojects (#37685).
Patch by salman mp.


git-svn-id: https://svn.redmine.org/redmine/trunk@21937 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-31 09:04:46 +00:00
Go MAEDA
5817752289 Remove unnecessary disabling of RuboCop Rails/Pluck (#37248).
git-svn-id: https://svn.redmine.org/redmine/trunk@21930 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-29 07:42:03 +00:00
Go MAEDA
ee1476f802 Fix RuboCop offense Rails/Pluck (#37248).
git-svn-id: https://svn.redmine.org/redmine/trunk@21928 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-28 07:50:11 +00:00
Go MAEDA
47b17044d2 Fix RuboCop offense Style/RedundantStringEscape (#36919).
git-svn-id: https://svn.redmine.org/redmine/trunk@21920 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-26 13:14:08 +00:00
Go MAEDA
8bc9d2abdf Simplify AttachmentsController#find_container (#37772).
Patch by  Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21907 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-20 04:14:26 +00:00
Go MAEDA
d726df660f Adds visible? method to journal (#37772).
Patch by  Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21905 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-20 04:11:58 +00:00
Marius Balteanu
5b78b045b1 Fix rubocop warning (#37626).
git-svn-id: https://svn.redmine.org/redmine/trunk@21886 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-02 12:47:33 +00:00
Marius Balteanu
e9adf8088d Add to do to fix the deprecation warning (#37626).
git-svn-id: https://svn.redmine.org/redmine/trunk@21884 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-02 09:59:11 +00:00
Marius Balteanu
dc54c7a721 Fix show diff of a javascript file in repository module is displayed without layout (#37626).
Patch by Trang Tran Thi Quynh. 


git-svn-id: https://svn.redmine.org/redmine/trunk@21883 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-02 08:53:09 +00:00
Go MAEDA
5b0e4a8e2d Add table header in Plugins page (#37692).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21879 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-01 06:54:27 +00:00
Go MAEDA
df88b9c7dd Issue ID field does not get focus when adding a related issue (#37473).
Patch by Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21867 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-28 09:18:31 +00:00
Marius Balteanu
20baf029ba Fix undefined method when auth source name column is added as column (#37674).
git-svn-id: https://svn.redmine.org/redmine/trunk@21861 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-27 19:55:09 +00:00
Go MAEDA
8cf28048a4 Adds missing join when ordering by authsource (#37674).
Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21856 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-27 09:30:07 +00:00
Go MAEDA
f92477a423 Cleanup Repository::Git#clear_extra_info_of_changesets (#37614).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21845 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-25 05:08:32 +00:00
Go MAEDA
a1126aebd4 Use the safe navigation operator instead of checking if an object is nil (#37614).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21844 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-25 05:07:09 +00:00
Go MAEDA
fa3a42d1de Fix RuboCop offense Style/GuardClause (#37614).
git-svn-id: https://svn.redmine.org/redmine/trunk@21843 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-25 05:00:29 +00:00
Go MAEDA
f17e8507c5 Fix RuboCop offense Style/IfUnlessModifier (#37614).
git-svn-id: https://svn.redmine.org/redmine/trunk@21842 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-25 04:58:53 +00:00
Go MAEDA
b7e477ea7f Fix RuboCop offense Style/SymbolProc (#37614).
git-svn-id: https://svn.redmine.org/redmine/trunk@21841 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-25 04:57:21 +00:00
Go MAEDA
02f17b6d2b Fix RuboCop offense Rails/Blank (#37614).
git-svn-id: https://svn.redmine.org/redmine/trunk@21840 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-25 04:56:16 +00:00
Marius Balteanu
d9d4bb2cbf Enable user auto-complete in issues bulk edit (#37369).
git-svn-id: https://svn.redmine.org/redmine/trunk@21834 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-23 05:58:19 +00:00
Marius Balteanu
a059599a8b Fix perfomance issue when objects are filtered by custom field values (#37268).
git-svn-id: https://svn.redmine.org/redmine/trunk@21833 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-23 05:51:59 +00:00
Go MAEDA
d7df1a740e Unify duplicate codes (#37687).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21832 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-23 04:47:49 +00:00
Go MAEDA
43c7cc03a5 Retrieve attachments with a single query when rendering a journal (#37687).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21831 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-23 04:46:39 +00:00
Go MAEDA
eb9bd3e836 Confirm user update / deletion (#37674).
Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21825 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-20 03:37:26 +00:00
Go MAEDA
62f7551d57 User bulk destroy (#37674).
includes a confirmation page that also gives the opportunity to lock
users instead of deleting them.

Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21824 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-20 03:36:40 +00:00
Go MAEDA
cd70187c2f Introduces a UserQuery model for admin/users (#37674).
Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21823 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-20 03:16:05 +00:00
Go MAEDA
ab2b130e3c Ignore statuses if workflow only defines identity transition (#37636).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21818 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-17 07:58:12 +00:00
Go MAEDA
d4b7634cc6 Consider only roles with either add_issues or edit_issues permissions for any status transitions (#37635).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21817 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-17 06:14:27 +00:00