meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-01-31 11:37:14 +00:00
Code Issues Releases Wiki Activity

Simplify AttachmentsController#find_container (#37772).

Browse Source 
Patch by  Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21907 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA 2022-10-20 04:14:26 +00:00
parent aeabd4682a
commit 8bc9d2abdf
1 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
app/controllers/attachments_controller.rb
View File

@ -219,19 +219,10 @@ class AttachmentsController < ApplicationController
end
def find_container
klass =
begin
params[:object_type].to_s.singularize.classify.constantize
rescue
nil
end
unless klass && (klass.reflect_on_association(:attachments) || klass.method_defined?(:attachments))
render_404
return
end
# object_type is constrained to valid values in routes
klass = params[:object_type].to_s.singularize.classify.constantize
@container = klass.find(params[:object_id])
if @container.respond_to?(:visible?) && !@container.visible?
unless @container.visible?
render_403
return
end