Toshi MARUYAMA
203c30dad1
rubocop: add Style/AsciiComments to .rubocop_todo.yml
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18632 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-09 02:05:49 +00:00
Toshi MARUYAMA
171c62f02d
code cleanup: rubocop: fix Style/AsciiComments in lib/redmine/search.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18631 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-09 02:05:37 +00:00
Toshi MARUYAMA
91c56e2cbd
code cleanup: rubocop: fix Style/AsciiComments in test/unit/mail_handler_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18630 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-09 02:05:25 +00:00
Go MAEDA
47de059580
Don't use sprockets 4.0.0 in order to avoid Sprockets::Railtie::ManifestNeededError ( #32223 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18629 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-09 02:02:16 +00:00
Toshi MARUYAMA
74f5842adb
code layout clean up test/unit/issue_status_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18628 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-08 14:10:02 +00:00
Toshi MARUYAMA
73b81ddef0
code layout clean up test/functional/issue_statuses_controller_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18627 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-08 14:09:51 +00:00
Toshi MARUYAMA
ae58969f64
code cleanup: rubocop: fix Style/RedundantBegin in lib/redmine/scm/adapters/git_adapter.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18626 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-08 14:09:40 +00:00
Go MAEDA
d5deee8af1
Fix wong link destinations in wiki_syntax_markdown.html ( #32169 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18625 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-08 12:54:10 +00:00
Toshi MARUYAMA
9716194b29
add additional assert to Issue system "test_update_issue_with_form_update"
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18624 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-08 12:18:01 +00:00
Toshi MARUYAMA
331d327325
reduce sleep seconds of Issue system "test_update_journal_notes_with_preview"
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18623 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-08 12:17:51 +00:00
Toshi MARUYAMA
017d8790c9
code layout clean up app/views/issues/_action_menu.html.erb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18622 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-08 07:39:23 +00:00
Toshi MARUYAMA
ffab57044a
code layout clean up app/views/issues/_attributes.html.erb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18621 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-08 05:29:40 +00:00
Toshi MARUYAMA
6a4080e9e9
code clean up test/integration/issues_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18620 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 13:07:12 +00:00
Toshi MARUYAMA
a55867fda3
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/integration/issues_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18619 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 13:07:00 +00:00
Toshi MARUYAMA
28c29d19a8
code cleanup: rubocop: fix Style/HashSyntax in test/functional/issues_controller_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18618 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 13:06:47 +00:00
Toshi MARUYAMA
6b5991b34e
use "attr_writer" instead of "attr_accessor" for WikiPage#deleted_attachment_ids
...
WikiPage#deleted_attachment_ids is already defined in this class.
git-svn-id: http://svn.redmine.org/redmine/trunk@18617 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 11:45:22 +00:00
Toshi MARUYAMA
1c0b6075ee
use "attr_writer" instead of "attr_accessor" for QueryColumn#sortable
...
QueryColumn#sortable is already defined in this class.
git-svn-id: http://svn.redmine.org/redmine/trunk@18616 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 11:45:11 +00:00
Toshi MARUYAMA
21cc761b53
use "attr_reader" instead of "attr_accessor" for CustomFieldValue#value
...
CustomFieldValue#value= is already defined in this class.
git-svn-id: http://svn.redmine.org/redmine/trunk@18615 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 11:44:54 +00:00
Toshi MARUYAMA
6972d7e982
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation and Layout/IndentHeredoc in test/unit/setting_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18614 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 11:44:42 +00:00
Toshi MARUYAMA
557f045e42
code cleanup: fix source code comment in r18607
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18613 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:34:22 +00:00
Toshi MARUYAMA
023c3455e6
code cleanup: rubocop: fix Layout/AlignArray in test/functional/issues_controller_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18612 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:21:27 +00:00
Toshi MARUYAMA
7d70e5175a
code cleanup: rubocop: fix Layout/SpaceAfterColon in test/integration/wiki_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18611 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:21:14 +00:00
Toshi MARUYAMA
359802ac3b
code cleanup: rubocop: fix Layout/SpaceInsideStringInterpolation in test/functional/issues_controller_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18610 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:21:03 +00:00
Toshi MARUYAMA
ff3df17fee
code cleanup: rubocop: fix Layout/SpaceAfterColon in test/functional/issues_controller_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18609 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:20:50 +00:00
Toshi MARUYAMA
a7f046ee7a
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/functional/issues_controller_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18608 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:20:38 +00:00
Toshi MARUYAMA
af67ade563
code cleanup: rubocop: fix Lint/UselessAccessModifier in app/models/changeset.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18607 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:20:26 +00:00
Toshi MARUYAMA
eee75cf080
code cleanup: rubocop: fix Layout/IndentHeredoc in test/functional/documents_controller_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18606 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:20:13 +00:00
Go MAEDA
66659d61e9
Traditional Chinese translation update ( #32210 ).
...
Patch by ChunChang Lo.
git-svn-id: http://svn.redmine.org/redmine/trunk@18605 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 04:08:08 +00:00
Toshi MARUYAMA
78b1838b68
rubocop: remove test/integration/attachments_test.rb from Layout/EmptyLinesAroundExceptionHandling fixed by r18593
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18604 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 02:32:36 +00:00
Toshi MARUYAMA
3c5d5df196
rubocop: remove test/functional/issues_controller_test.rb from Layout/IndentHeredoc and Layout/IndentationConsistency fixed by r18593
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18603 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 02:02:40 +00:00
Go MAEDA
cf0a40b28f
Options in a drop-down overlap the down arrow when Alternate theme is used ( #32206 , #31147 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18602 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 00:40:03 +00:00
Go MAEDA
9841f2d998
Japanese wiki help translation update ( #32207 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18601 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-06 10:53:09 +00:00
Go MAEDA
2158e3f2c6
Fix that "Associated revisions" tab has no content when the user displays comments in reverse chronological order ( #32198 , #3058 ).
...
Patch by José Esteves.
git-svn-id: http://svn.redmine.org/redmine/trunk@18598 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-05 23:57:33 +00:00
Go MAEDA
ebfe08974f
Japanese translation update ( #32202 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18597 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-05 10:02:00 +00:00
Go MAEDA
3bd0d76fef
Update locales ( #17840 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18596 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-05 09:48:15 +00:00
Go MAEDA
16c580a2f8
Option to send email notification on "Target version updated" ( #17840 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18595 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-05 09:46:05 +00:00
Go MAEDA
d182e73643
Redmine::VERSION::revision may return wrong value ( #29601 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18594 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-05 05:46:39 +00:00
Go MAEDA
5ce4a363a9
Fix test failure due to missing call to set_tmp_attachments_directory ( #32122 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18593 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-04 11:17:33 +00:00
Go MAEDA
b834020297
Fix incorrect headings example in Textile help ( #32184 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18592 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-04 00:18:30 +00:00
Go MAEDA
cbcca10d6b
Fix "already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN" warning when executing rake tasks ( #32110 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18589 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-03 13:40:55 +00:00
Go MAEDA
4146467ff2
Remove unnecessary requiring of "rexml/document" ( #32189 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18588 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-03 13:36:18 +00:00
Go MAEDA
9c01c3ba21
Rounded corners on table.cal ( #32165 ).
...
Patch by Antonio McDeal.
git-svn-id: http://svn.redmine.org/redmine/trunk@18587 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-03 12:09:25 +00:00
Go MAEDA
7763902629
Use Redmine::MimeType.of instead of regexp to check if the attachment is Textile ( #29752 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18586 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-03 09:30:43 +00:00
Go MAEDA
cffc5d6a12
Add styles for Textile/Markdown attachments preview ( #29752 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18585 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-03 00:32:33 +00:00
Go MAEDA
3ce678510e
Render Textile and Markdown attachments on the preview page ( #29752 ).
...
Patch by Takenori TAKAKI.
git-svn-id: http://svn.redmine.org/redmine/trunk@18584 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-03 00:09:28 +00:00
Go MAEDA
df1c54146f
RuboCop: Disable Layout/SpaceInsideHashLiteralBraces
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18583 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-03 00:08:02 +00:00
Go MAEDA
545a050ba3
Code cleanup: RuboCop: Fix Performance/Count and Performance/Detect.
...
This change corrects newly detected offenses after updating rubocop-performance to 1.5.0 in r18579.
git-svn-id: http://svn.redmine.org/redmine/trunk@18580 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-02 00:53:11 +00:00
Go MAEDA
fff145a49d
Update rubocop-performance to 1.5.0 ( #31509 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18579 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-02 00:27:19 +00:00
Toshi MARUYAMA
30f3fea023
fix Redmine::Themes#scan_themes is not private
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18578 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-01 05:07:27 +00:00
Toshi MARUYAMA
c343588fa7
fix Watcher#prune_single_user is not private
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18577 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-01 05:07:16 +00:00