Marius Balteanu
2116ebb79a
Fix Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body ( #43125 ).
...
Patch by Katsuya HIDAKA (user:hidakatsuya).
git-svn-id: https://svn.redmine.org/redmine/trunk@23921 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-13 20:34:33 +00:00
Marius Balteanu
2d1f1684a1
Explicitly don't cache sensitive 2FA actions ( #43083 ).
...
Patch by Felix Schäfer (user:felix).
git-svn-id: https://svn.redmine.org/redmine/trunk@23917 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-13 05:58:49 +00:00
Marius Balteanu
8f002c297e
Deny 2fa setup when 2fa already present ( #43083 ).
...
Patch by Felix Schäfer (user:felix).
git-svn-id: https://svn.redmine.org/redmine/trunk@23916 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-13 05:57:21 +00:00
Marius Balteanu
30880b861f
Run Setting.clear_cache after each test in order to decrease the number of random failing tests ( #43130 ).
...
Patch by Katsuya HIDAKA (user:hidakatsuya).
git-svn-id: https://svn.redmine.org/redmine/trunk@23915 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-13 05:31:26 +00:00
Marius Balteanu
686c04dd85
Remove redundant fixtures declaration from OauthProviderSystemTest ( #43125 , 24808).
...
Patch by Katsuya HIDAKA (user:hidakatsuya).
git-svn-id: https://svn.redmine.org/redmine/trunk@23914 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-13 05:26:20 +00:00
Marius Balteanu
d79fe0df9a
Adds @Cache-Control: no-store@ header to login, lost password, change password and sudo pages ( #42998 ).
...
Patch by Go MAEDA (user:maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@23908 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-10 13:23:14 +00:00
Marius Balteanu
458072ab7d
When the Gravatar service is disabled, display the user's initials as a fallback avatar. This provides a consistent user interface than the generic icon ( #29824 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23903 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-07 19:07:33 +00:00
Go MAEDA
9605bb4b3b
Add model/controller generators tests ( #42934 ).
...
Patch by Haruka Asakura (Agileware) (user:asakura-agileware).
git-svn-id: https://svn.redmine.org/redmine/trunk@23901 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-07-31 11:49:13 +00:00
Marius Balteanu
ae3cb747bb
Adds method @initials@ to @Principal@ and return @nil@ by default ( #42623 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23888 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-07-15 05:20:23 +00:00
Marius Balteanu
e940540e2e
Refactor, refresh UI and unify the structure of journals, replies and comments ( #42972 , #40744 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23887 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-07-14 21:33:33 +00:00
Go MAEDA
69dde23d5c
Downloading .js files from the repository browser fails with a 422 error due to ActionController::InvalidCrossOriginRequest ( #42839 ).
...
Patch by Go MAEDA (user:maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@23857 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-07-05 02:22:30 +00:00
Marius Balteanu
a531b4fe80
Reimplement partial quote feature using Stimulus JS ( #42515 ).
...
Patch by Katsuya HIDAKA (user:hidakatsuya).
git-svn-id: https://svn.redmine.org/redmine/trunk@23854 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-07-04 05:45:29 +00:00
Marius Balteanu
c1115fea4a
Fixes @icon-only@ class for quote reply button and test assertions that are always true ( #42515 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23853 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-07-04 05:28:34 +00:00
Go MAEDA
a4a32179f6
Fix "Page not found" error when saving workflows with many statuses on Rack >= 3.1.14 ( #42875 ).
...
Patch by Go MAEDA (user:maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@23841 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-18 01:57:58 +00:00
Marius Balteanu
9186b8e64d
Replaces webrick server used in @OauthProviderSystemTest@ with puma ( #24808 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23840 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-16 21:32:45 +00:00
Marius Balteanu
eb1fcac5e4
Improve text assertion ( #24808 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23839 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-16 21:21:24 +00:00
Marius Balteanu
2d3b3b939e
Add OAuth2 provider capability using doorkeeper gem ( #24808 ).
...
Patch by Jens Krämer (user:jkraemer).
git-svn-id: https://svn.redmine.org/redmine/trunk@23837 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-12 07:09:03 +00:00
Marius Balteanu
e56d84b632
Reverts r23835 due to wrong issue ID ( #40856 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23836 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-12 07:05:01 +00:00
Marius Balteanu
ebdd1a40f4
Add OAuth2 provider capability using doorkeeper gem ( #40856 ).
...
Patch by Jens Krämer (user:jkraemer).
git-svn-id: https://svn.redmine.org/redmine/trunk@23835 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-11 20:30:44 +00:00
Go MAEDA
bb6b8e1e43
Fix RuboCop Style/RedundantArrayFlatten ( #41884 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23823 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-07 07:42:07 +00:00
Go MAEDA
8c10cf3f30
Fix render_flash_messages method to ignore non-string flash values and prevent errors ( #42073 ).
...
Patch by Katsuya HIDAKA (user:hidakatsuya).
git-svn-id: https://svn.redmine.org/redmine/trunk@23821 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-06 06:34:26 +00:00
Marius Balteanu
feb751843e
Set default for "Javascript based table sorting in wiki content" to disabled for new installations ( #40588 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23813 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-01 20:41:16 +00:00
Marius Balteanu
86f1676742
Reverts r23811 ( #31531 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23812 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-01 20:32:31 +00:00
Marius Balteanu
3d8002febf
Change quote note icon to quotation marks ( #31531 ).
...
Patch by Mizuki ISHIKAWA (user:ishikawa999) and Marius BALTEANU (user:marius.balteanu).
git-svn-id: https://svn.redmine.org/redmine/trunk@23811 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-01 20:28:50 +00:00
Go MAEDA
d911e0d0fd
Fix system test failure in reactions_test.rb caused by r23809 ( #31531 ).
...
Patch by Katsuya HIDAKA (user:hidakatsuya).
git-svn-id: https://svn.redmine.org/redmine/trunk@23810 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-01 02:02:19 +00:00
Marius Balteanu
7645774634
Change quote note icon to quotation marks ( #31531 ).
...
Patch by Mizuki ISHIKAWA (user:ishikawa999) and Marius BALTEANU (user:marius.balteanu).
git-svn-id: https://svn.redmine.org/redmine/trunk@23809 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-30 20:04:46 +00:00
Go MAEDA
9beb9d9c5c
"Edit this section" button is missing for headings rendered as multiline HTML ( #42332 ).
...
Patch by Abe Tomoaki (user:abetomo).
git-svn-id: https://svn.redmine.org/redmine/trunk@23802 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-27 01:55:37 +00:00
Marius Balteanu
3090bf6906
Adds icons to commonmark alerts ( #42603 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23796 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-24 21:29:21 +00:00
Go MAEDA
bc12a74a5c
Update tests for rails-dom-testing 2.3.0 whitespace collapsing ( #42756 ).
...
Patch by Katsuya HIDAKA (user:hidakatsuya).
git-svn-id: https://svn.redmine.org/redmine/trunk@23784 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-23 05:44:05 +00:00
Go MAEDA
8d1ad3f239
Allow reactions on journals with property changes only ( #42630 ).
...
Patch by Katsuya HIDAKA (user:hidakatsuya).
git-svn-id: https://svn.redmine.org/redmine/trunk@23781 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-17 08:46:25 +00:00
Go MAEDA
4b42d68842
Avoid adding "%" suffix in CSV export for Progress Bar custom fields to prevent import errors ( #42335 , #42706 ).
...
Patch by Kenta Kumojima (user:kumojima).
git-svn-id: https://svn.redmine.org/redmine/trunk@23780 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-17 02:02:04 +00:00
Go MAEDA
48f09a5d87
Improve reaction button style to better highlight existing reactions ( #42630 ):
...
* Hide count when zero
* Make non-zero count bold
* Remove underline on hover and active
Patch by Mizuki ISHIKAWA (user:ishikawa999).
git-svn-id: https://svn.redmine.org/redmine/trunk@23778 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-16 02:57:04 +00:00
Marius Balteanu
6f31d4fb87
Fixes wrong change added in r23761 ( #42422 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23770 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-15 05:28:27 +00:00
Go MAEDA
d2a9223c4a
Improve method and variable naming for clarity and consistency ( #42630 ).
...
Patch by Katsuya HIDAKA (user:hidakatsuya).
git-svn-id: https://svn.redmine.org/redmine/trunk@23769 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-15 05:09:17 +00:00
Go MAEDA
e7703a0170
Show reaction counts and user names only for reactions visible to the logged-in user ( #42630 ).
...
Patch by Katsuya HIDAKA (user:hidakatsuya).
git-svn-id: https://svn.redmine.org/redmine/trunk@23768 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-15 05:01:54 +00:00
Marius Balteanu
66e2d1a9a9
Adds Initials to the list of default gratavar options ( #42623 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23767 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-14 19:41:04 +00:00
Marius Balteanu
e78e1e29fd
Use Capybara's @assert_current_path@ in "log_user" steps to wait for page in ApplicationSystemTestCase ( #42422 ).
...
Patch by Takuya Kodama (user:otegami).
git-svn-id: https://svn.redmine.org/redmine/trunk@23761 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-14 17:36:11 +00:00
Go MAEDA
9232726b95
Fix random failures in several system tests with Chrome 133 and later ( #42687 ).
...
Patch by Katsuya HIDAKA (user:hidakatsuya).
git-svn-id: https://svn.redmine.org/redmine/trunk@23756 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-11 11:03:09 +00:00
Go MAEDA
403c10091f
Introduce reactions feature (so-called "like button") to issues, notes, news, and forums ( #42630 ).
...
Patch by Katsuya HIDAKA (user:hidakatsuya).
git-svn-id: https://svn.redmine.org/redmine/trunk@23755 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-11 07:59:16 +00:00
Go MAEDA
1b9698df2c
Add a sticky issue header to issue page ( #42684 ).
...
Patch by Mizuki ISHIKAWA (user:ishikawa999).
git-svn-id: https://svn.redmine.org/redmine/trunk@23752 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-10 01:00:13 +00:00
Marius Balteanu
e25f391677
Fixes rubocop offenses ( #42648 , #42603 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23728 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-30 22:56:45 +00:00
Marius Balteanu
acb6ae97c2
Fixes rubocop offense "Prefer assert_not_includes over refute_includes" ( #42603 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23727 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-30 22:46:39 +00:00
Marius Balteanu
e6f00370ee
Fixes broken references for multiple footnote usage ( #42648 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23726 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-30 22:40:18 +00:00
Marius Balteanu
2b9c6f64b1
Fixes failing test ( #42603 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23725 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-30 22:30:14 +00:00
Marius Balteanu
8fa4c44581
Enable CommonMark alert extension ( #42603 ).
...
Patch by Mizuki ISHIKAWA (user:ishikawa999).
git-svn-id: https://svn.redmine.org/redmine/trunk@23724 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-29 21:13:55 +00:00
Go MAEDA
0dc7337c7d
Fix RuboCop Layout/EmptyLinesAroundMethodBody ( #42602 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23723 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-27 09:37:30 +00:00
Marius Balteanu
6faaf3d038
Replaces deckar01-task_list gem with commonmarks tasklist extension ( #42602 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23718 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-27 06:58:32 +00:00
Go MAEDA
293e7c22fe
Suppress "Change your password" popup for stable system tests ( #42600 ).
...
Patch by Mizuki ISHIKAWA (user:ishikawa999).
git-svn-id: https://svn.redmine.org/redmine/trunk@23704 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-23 00:50:57 +00:00
Go MAEDA
ce94a1d71a
Adds interval ratio setting to progressbar custom field ( #42335 ).
...
Patch by Marius BĂLTEANU (user:marius.balteanu) and Go MAEDA (user:maeda).
git-svn-id: https://svn.redmine.org/redmine/trunk@23686 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-19 08:46:02 +00:00
Marius Balteanu
de96d418b1
Add "editable" attribute in the custom fields API response ( #41935 ).
...
git-svn-id: https://svn.redmine.org/redmine/trunk@23678 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-18 14:44:17 +00:00