meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-02-01 03:57:15 +00:00
Code Issues Releases Wiki Activity

Declare text direction on HTML element for better RTL/LTR styling support (#43506).

Browse Source 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@24151 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA 2025-11-20 23:51:55 +00:00
parent cadb79138d
commit 4791d3801f
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/views/layouts/base.html.erb
View File

@ -1,5 +1,5 @@
<!DOCTYPE html>
<html lang="<%= current_language %>">
<html lang="<%= current_language %>" dir="<%= l(:direction) %>">
<head>
<meta charset="utf-8" />
<title><%= html_title %></title>

8
test/integration/application_test.rb
View File

@ -31,6 +31,7 @@ class ApplicationTest < Redmine::IntegrationTest
assert_select 'h2', :text => 'Projets'
assert_equal :fr, current_language
assert_select "html[lang=?]", "fr"
assert_select "html[dir=?]", "ltr"
# then an italien user
get '/projects', :headers => {'HTTP_ACCEPT_LANGUAGE' => 'it;q=0.8,en-us;q=0.5,en;q=0.3'}
@ -38,12 +39,19 @@ class ApplicationTest < Redmine::IntegrationTest
assert_select 'h2', :text => 'Progetti'
assert_equal :it, current_language
assert_select "html[lang=?]", "it"
assert_select "html[dir=?]", "ltr"
# html[dir] should be "rtl" for right-to-left scripts
get '/projects', :headers => {'HTTP_ACCEPT_LANGUAGE' => 'ar'}
assert_response :success
assert_select "html[dir=?]", "rtl"
# not a supported language: default language should be used
get '/projects', :headers => {'HTTP_ACCEPT_LANGUAGE' => 'zz'}
assert_response :success
assert_select 'h2', :text => 'Projects'
assert_select "html[lang=?]", "en"
assert_select "html[dir=?]", "ltr"
end
def test_token_based_access_should_not_start_session