1
0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-19 23:11:12 +00:00
redmine/test/functional/messages_controller_test.rb
Jean-Philippe Lang 015ca36634 Send individual emails for each mail recipient (#26791).
We are creating multipe mails per class notification event, one per
recipient, wrapped in a Mailer::MultiMessage object to send them all at
once.

We keep the existing interface of all class methods intended to be used
by external code the same as they were before, with one exception:

We provide additional recipient addresses in options[:recipients] for
Mailer.security_notification. Since the first-class recipients have to
be users to render individual mails for them, additional recipient
addresses have to be provided with some other channel.

By providing additional recipients in options[:recipients], we can solve
the use-case for address change notifications for users, which probably
is the only real use-case for having to use a plain email address
instead of a User as a notification recipient.

Patch by Holger Just and Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17583 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-06 13:08:52 +00:00

293 lines
7.8 KiB
Ruby

# Redmine - project management software
# Copyright (C) 2006-2017 Jean-Philippe Lang
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
require File.expand_path('../../test_helper', __FILE__)
class MessagesControllerTest < Redmine::ControllerTest
fixtures :projects, :users, :email_addresses, :user_preferences, :members, :member_roles, :roles, :boards, :messages, :enabled_modules
def setup
User.current = nil
end
def test_show
get :show, :params => {
:board_id => 1,
:id => 1
}
assert_response :success
assert_select 'h2', :text => 'First post'
end
def test_show_should_contain_reply_field_tags_for_quoting
@request.session[:user_id] = 2
get :show, :params => {
:board_id => 1,
:id => 1
}
assert_response :success
# tags required by MessagesController#quote
assert_select 'input#message_subject'
assert_select 'textarea#message_content'
assert_select 'div#reply'
end
def test_show_with_pagination
message = Message.find(1)
assert_difference 'Message.count', 30 do
30.times do
message.children << Message.new(:subject => 'Reply',
:content => 'Reply body',
:author_id => 2,
:board_id => 1)
end
end
reply_ids = message.children.map(&:id).sort
get :show, :params => {
:board_id => 1,
:id => 1,
:r => reply_ids.last
}
assert_response :success
assert_select 'a[href=?]', "/boards/1/topics/1?r=#{reply_ids.last}#message-#{reply_ids.last}"
assert_select 'a[href=?]', "/boards/1/topics/1?r=#{reply_ids.first}#message-#{reply_ids.first}", 0
end
def test_show_with_reply_permission
@request.session[:user_id] = 2
get :show, :params => {
:board_id => 1,
:id => 1
}
assert_response :success
assert_select 'div#reply textarea#message_content'
end
def test_show_message_not_found
get :show, :params => {
:board_id => 1,
:id => 99999
}
assert_response 404
end
def test_show_message_from_invalid_board_should_respond_with_404
get :show, :params => {
:board_id => 999,
:id => 1
}
assert_response 404
end
def test_get_new
@request.session[:user_id] = 2
get :new, :params => {
:board_id => 1
}
assert_response :success
assert_select 'input[name=?]', 'message[subject]'
end
def test_get_new_with_invalid_board
@request.session[:user_id] = 2
get :new, :params => {
:board_id => 99
}
assert_response 404
end
def test_post_new
@request.session[:user_id] = 2
ActionMailer::Base.deliveries.clear
with_settings :notified_events => %w(message_posted) do
post :new, :params => {
:board_id => 1,
:message => {
:subject => 'Test created message',
:content => 'Message body'
}
}
end
message = Message.find_by_subject('Test created message')
assert_not_nil message
assert_redirected_to "/boards/1/topics/#{message.to_param}"
assert_equal 'Message body', message.content
assert_equal 2, message.author_id
assert_equal 1, message.board_id
mails = ActionMailer::Base.deliveries
assert_not_empty mails
mails.each do |mail|
assert_equal "[#{message.board.project.name} - #{message.board.name} - msg#{message.root.id}] Test created message", mail.subject
assert_mail_body_match 'Message body', mail
end
# author
assert_equal ['jsmith@somenet.foo'], mails[0].bcc
# project member
assert_equal ['dlopper@somenet.foo'], mails[1].bcc
end
def test_get_edit
@request.session[:user_id] = 2
get :edit, :params => {
:board_id => 1,
:id => 1
}
assert_response :success
assert_select 'input[name=?][value=?]', 'message[subject]', 'First post'
end
def test_post_edit
@request.session[:user_id] = 2
post :edit, :params => {
:board_id => 1,
:id => 1,
:message => {
:subject => 'New subject',
:content => 'New body'
}
}
assert_redirected_to '/boards/1/topics/1'
message = Message.find(1)
assert_equal 'New subject', message.subject
assert_equal 'New body', message.content
end
def test_post_edit_sticky_and_locked
@request.session[:user_id] = 2
post :edit, :params => {
:board_id => 1,
:id => 1,
:message => {
:subject => 'New subject',
:content => 'New body',
:locked => '1',
:sticky => '1'
}
}
assert_redirected_to '/boards/1/topics/1'
message = Message.find(1)
assert_equal true, message.sticky?
assert_equal true, message.locked?
end
def test_post_edit_should_allow_to_change_board
@request.session[:user_id] = 2
post :edit, :params => {
:board_id => 1,
:id => 1,
:message => {
:subject => 'New subject',
:content => 'New body',
:board_id => 2
}
}
assert_redirected_to '/boards/2/topics/1'
message = Message.find(1)
assert_equal Board.find(2), message.board
end
def test_reply
@request.session[:user_id] = 2
post :reply, :params => {
:board_id => 1,
:id => 1,
:reply => {
:content => 'This is a test reply',
:subject => 'Test reply'
}
}
reply = Message.order('id DESC').first
assert_redirected_to "/boards/1/topics/1?r=#{reply.id}"
assert Message.find_by_subject('Test reply')
end
def test_destroy_topic
@request.session[:user_id] = 2
assert_difference 'Message.count', -3 do
post :destroy, :params => {
:board_id => 1,
:id => 1
}
end
assert_redirected_to '/projects/ecookbook/boards/1'
assert_nil Message.find_by_id(1)
end
def test_destroy_reply
@request.session[:user_id] = 2
assert_difference 'Message.count', -1 do
post :destroy, :params => {
:board_id => 1,
:id => 2
}
end
assert_redirected_to '/boards/1/topics/1?r=2'
assert_nil Message.find_by_id(2)
end
def test_quote
@request.session[:user_id] = 2
get :quote, :params => {
:board_id => 1,
:id => 3
},
:xhr => true
assert_response :success
assert_equal 'text/javascript', response.content_type
assert_include 'RE: First post', response.body
assert_include '> An other reply', response.body
end
def test_preview_new
@request.session[:user_id] = 2
post :preview, :params => {
:board_id => 1,
:message => {
:subject => ""
},
:text => "Previewed text"
}
assert_response :success
assert_include 'Previewed text', response.body
end
def test_preview_edit
@request.session[:user_id] = 2
post :preview, :params => {
:id => 4,
:board_id => 1,
:message => {
:subject => "",
},
:text => "Previewed text"
}
assert_response :success
assert_include 'Previewed text', response.body
end
end