Go MAEDA
fa76ec5c01
Adds issue category filter to spent time queries ( #28391 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17249 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-01 00:29:22 +00:00
Go MAEDA
0f9ea965e7
Fix: Calculation of the start date of following issues ignores the "non-working days" setting ( #14846 ).
...
Patch by Felix Schäfer.
git-svn-id: http://svn.redmine.org/redmine/trunk@17230 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-08 07:44:54 +00:00
Go MAEDA
76f12c1316
Optional regex for filtering attachments on incoming emails ( #27025 ).
...
Patch by Jan Schulz-Hofen.
git-svn-id: http://svn.redmine.org/redmine/trunk@17225 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-03 04:29:54 +00:00
Go MAEDA
e9fb90856f
Move textile footnotes test to TextileFormatterTest ( #28207 ).
...
Patch by Mischa The Evil.
git-svn-id: http://svn.redmine.org/redmine/trunk@17222 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-02 04:58:52 +00:00
Go MAEDA
8d033d08d0
Add footnotes test for markdown formatter ( #28207 ).
...
Patch by Mischa The Evil.
git-svn-id: http://svn.redmine.org/redmine/trunk@17221 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-02 04:55:52 +00:00
Go MAEDA
5ed4031b64
Add minimal fixture for issues_pdf_test ( #12510 ).
...
Patch by Gregor Schmidt.
git-svn-id: http://svn.redmine.org/redmine/trunk@17212 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-02-24 09:26:26 +00:00
Go MAEDA
241e4cbb68
Enable lax_spacing for markdown formatting ( #28119 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-02-16 05:01:14 +00:00
Go MAEDA
f496402634
Add tests for "height" and "max-height" ( #26552 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17175 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-13 00:32:53 +00:00
Go MAEDA
e4142a8338
Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textile ( #26552 ).
...
Patch by Michael Gerz and Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@17173 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-11 01:32:18 +00:00
Jean-Philippe Lang
6d4c0a77fe
The progress exceeding 99.5% is displayed as 100% ( #27848 ).
...
Patch by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@17169 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-08 22:35:59 +00:00
Jean-Philippe Lang
4c0638c5f9
Unable to download file if custom field is not defined as visible to any users ( #26705 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17158 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-08 17:43:31 +00:00
Jean-Philippe Lang
4e6b54e33e
Empty email attachments are imported to Redmine, creating broken DB records ( #27885 ).
...
Patch by Felix Schäfer.
git-svn-id: http://svn.redmine.org/redmine/trunk@17147 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-07 21:46:58 +00:00
Jean-Philippe Lang
2cb30321a2
No validation errors when entering an invalid "Estimate hours" value ( #27881 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@17144 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-07 21:41:15 +00:00
Go MAEDA
c35433ad01
Links for custom field value don't have "external" class ( #27024 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@17138 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-01 06:18:01 +00:00
Toshi MARUYAMA
4e7ae640b9
add copyright header to test/unit/lib/redmine/helpers/url_test.rb ( #12510 )
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17077 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 14:28:41 +00:00
Toshi MARUYAMA
93d8204b8a
code clean up IssuesPdfHelperTest ( #12510 )
...
* remove extra empty lines
* remove trailing white space
* replace tab to two spaces
git-svn-id: http://svn.redmine.org/redmine/trunk@17065 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 12:03:08 +00:00
Toshi MARUYAMA
9d797400ea
mercurial: work around faulty parsing of early command options ( #27516 )
...
Use -sVALUE and --long=VALUE instead of "-s VALUE" and "--long VALUE"
respectively.
Contributed by Yuya Nishihara.
git-svn-id: http://svn.redmine.org/redmine/trunk@17062 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 11:38:47 +00:00
Toshi MARUYAMA
ca87bf766c
mercurial: reject malicious command argument ( #27516 )
...
We've got a security report from the Phabricator team, which basically says
--config and --debugger arguments can be injected anywhere to lead to an
arbitrary command execution.
https://secure.phabricator.com/rPa7921a4448093d00defa8bd18f35b8c8f8bf3314
This is a fundamental issue of the argument parsing rules in Mercurial, which
allows extensions to populate their parsing rules and such extensions can be
loaded by "--config extensions.<name>=". There's a chicken and egg problem.
We're working on hardening the parsing rules, but which won't come in by
default as it would be a behavior change.
This patch adds a verification to reject malicious command arguments as a
last ditch. The subsequent patches will fix the problem in more appropriate
way.
Contributed by Yuya Nishihara.
git-svn-id: http://svn.redmine.org/redmine/trunk@17060 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 11:38:23 +00:00
Go MAEDA
d6d2d23365
Fix: Round floats to 2 digits when rendering an issue list to PDF ( #12510 ).
...
Patch by Holger Just and Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17059 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-06 14:25:35 +00:00
Go MAEDA
ae842a73db
Disallow creating inverse relates issue relations ( #27663 ).
...
Patch by Gregor Schmidt.
git-svn-id: http://svn.redmine.org/redmine/trunk@17056 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-06 09:01:07 +00:00
Go MAEDA
0ed07156ad
Reverted r17054 ( #27663 ).
...
The change breaks test/functional/issue_relations_controller_test.rb.
git-svn-id: http://svn.redmine.org/redmine/trunk@17055 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-30 00:02:02 +00:00
Go MAEDA
3a310ccc2e
Disallow creating inverse relates issue relations ( #27663 ).
...
Patch by Gregor Schmidt.
git-svn-id: http://svn.redmine.org/redmine/trunk@17054 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-29 22:22:39 +00:00
Jean-Philippe Lang
62d6dfe1cc
Fixes visibility checks for version.fixed_issues in Gantt ( #27676 ).
...
Like the version page - the Gantt chart featured a "percent done" info
for each version, which wasn't properly limited to visible issues.
Patch by Gregor Schmidt.
git-svn-id: http://svn.redmine.org/redmine/trunk@17053 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-29 19:38:44 +00:00
Go MAEDA
9ae7bc8152
Make robust Redmine::Helpers::URL#uri_with_safe_scheme? ( #27114 )
...
Patch by okkez.
git-svn-id: http://svn.redmine.org/redmine/trunk@17035 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-26 03:44:37 +00:00
Toshi MARUYAMA
abe914fd3f
add test that anonymous user can add watchers by mail ( #26654 )
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16963 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-09-07 17:22:14 +00:00
Jean-Philippe Lang
9f9f7993e6
#assert_nothing_raised takes no arguments.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16944 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-08-01 21:40:58 +00:00
Toshi MARUYAMA
eb1998ef39
try IssueTest#test_overdue failing on CI server at Japanese daytime ( #22320 )
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16938 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-31 06:57:35 +00:00
Jean-Philippe Lang
a9e4b41d4a
Move helper tests to test/helpers ( #26504 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16930 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-30 18:23:06 +00:00
Jean-Philippe Lang
d827fc4a75
Skip all issue concurrency tests with MySQL.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16926 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-30 17:09:45 +00:00
Toshi MARUYAMA
09148ba665
add missing fixture for IssueTest#test_update_should_notify_previous_assignee
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16894 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-27 07:19:31 +00:00
Jean-Philippe Lang
9f346d5921
Make sure that something was actually deleted.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16890 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-26 16:43:19 +00:00
Jean-Philippe Lang
71423af0b2
Get rid of acts_as_versioned.
...
WikiContent::Version becomes WikiContentVersion.
git-svn-id: http://svn.redmine.org/redmine/trunk@16889 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-26 16:41:06 +00:00
Jean-Philippe Lang
0910b2bdbe
Drop Darcs support ( #26391 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@16886 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-25 17:32:53 +00:00
Jean-Philippe Lang
1cb1be17a9
Fixed link to user in email notifications ( #26506 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16876 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-24 16:59:23 +00:00
Jean-Philippe Lang
de4df036f5
Test fails with mysql 5.7.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16874 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 21:06:52 +00:00
Jean-Philippe Lang
d74f0bfd5c
Merged rails-5.1 branch ( #23630 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16859 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 11:26:04 +00:00
Jean-Philippe Lang
1ff3e91033
Adds a test for importing list custom fields with multiple values ( #26148 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16837 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-19 17:07:13 +00:00
Jean-Philippe Lang
3cc483180a
Adds a test for importing list custom fields ( #26148 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16834 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-19 14:58:06 +00:00
Jean-Philippe Lang
7bd8280a83
Adds settings for time entry hours validation ( #24005 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16832 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-19 14:13:10 +00:00
Jean-Philippe Lang
85a0e96ad6
Set a default size for macro thumbnails different from the preview thumbnails.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16829 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-19 07:00:27 +00:00
Jean-Philippe Lang
a7e88dca7d
Fixed that formatting of commit message is never applied ( #26445 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16823 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-16 18:02:38 +00:00
Toshi MARUYAMA
48259a1eda
add some tests to RepositoryTest#test_for_changeset_comments_strip
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16811 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-10 04:48:19 +00:00
Toshi MARUYAMA
7187e8dade
code style cleanup at RepositoryTest#test_for_changeset_comments_strip
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16810 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-10 04:48:08 +00:00
Toshi MARUYAMA
3a0cc09d7c
replace white spaces of here-text at RepositoryTest#test_for_changeset_comments_strip
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16809 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-10 04:47:56 +00:00
Jean-Philippe Lang
2bc719e2c8
LdapError is deprecated ( #24970 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16773 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-08 13:46:47 +00:00
Jean-Philippe Lang
92ca57e938
Fixed User#project_ids_by_role when first called within chained scopes ( #26376 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16767 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-08 12:15:10 +00:00
Jean-Philippe Lang
c7e32aa202
"attachment:filename" should generate a link to preview instead of download ( #26310 , #25988 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16738 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-02 09:54:24 +00:00
Jean-Philippe Lang
dd650c5c26
Setting to disable automatic closing of duplicates ( #26192 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16697 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 11:40:58 +00:00
Jean-Philippe Lang
7fd04e1f8d
Update copyright.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Toshi MARUYAMA
04fa679cb8
add test of email reminder in case of user language is 'auto' ( #26247 )
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16682 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-23 16:46:05 +00:00