meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-24 01:11:12 +00:00
Code Issues Releases Wiki Activity
17,492 Commits 32 Branches 194 Tags
Commit Graph

3117 Commits

Author SHA1 Message Date
Go MAEDA
fa3a42d1de Fix RuboCop offense Style/GuardClause (#37614). 
git-svn-id: https://svn.redmine.org/redmine/trunk@21843 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-09-25 05:00:29 +00:00
Go MAEDA
f17e8507c5 Fix RuboCop offense Style/IfUnlessModifier (#37614). 
git-svn-id: https://svn.redmine.org/redmine/trunk@21842 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-09-25 04:58:53 +00:00
Go MAEDA
b7e477ea7f Fix RuboCop offense Style/SymbolProc (#37614). 
git-svn-id: https://svn.redmine.org/redmine/trunk@21841 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-09-25 04:57:21 +00:00
Go MAEDA
02f17b6d2b Fix RuboCop offense Rails/Blank (#37614). 
git-svn-id: https://svn.redmine.org/redmine/trunk@21840 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-09-25 04:56:16 +00:00
Marius Balteanu
a059599a8b Fix perfomance issue when objects are filtered by custom field values (#37268). 
git-svn-id: https://svn.redmine.org/redmine/trunk@21833 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-09-23 05:51:59 +00:00
Go MAEDA
d7df1a740e Unify duplicate codes (#37687). 
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21832 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-09-23 04:47:49 +00:00
Go MAEDA
43c7cc03a5 Retrieve attachments with a single query when rendering a journal (#37687). 
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21831 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-09-23 04:46:39 +00:00
Go MAEDA
cd70187c2f Introduces a UserQuery model for admin/users (#37674). 
Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21823 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-09-20 03:16:05 +00:00
Go MAEDA
ab2b130e3c Ignore statuses if workflow only defines identity transition (#37636). 
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21818 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-09-17 07:58:12 +00:00
Go MAEDA
d4b7634cc6 Consider only roles with either add_issues or edit_issues permissions for any status transitions (#37635). 
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21817 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-09-17 06:14:27 +00:00
Go MAEDA
12c7061416 Rename Repository#supports_all_revisions? to Repository#supports_history? (#37657). 
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21816 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-09-15 13:14:05 +00:00
Go MAEDA
7f6d9d3be9 Check visibility for passed user in IssueQuery.default (#37499, #37608). 
Patch by  Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21781 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-08-26 01:19:10 +00:00
Go MAEDA
204709f4df Use the classes whitelist configured in application.rb instead of hardcoded classes (#37476). 
Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21777 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-08-25 13:47:04 +00:00
Go MAEDA
38f7a06405 Add default spent time activity per role (#29286). 
Patch by Marius BALTEANU and Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21763 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-08-09 02:50:11 +00:00
Go MAEDA
72e2efdc60 Default query should not be applied if the query is not allowed to be set as the default (#37499). 
Patch by Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21748 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-07-31 13:33:27 +00:00
Go MAEDA
93e24bfccf Better validation error message when the domain of email is not allowed (#35450). 
Patch by  Yuichi HARADA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21739 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-07-27 14:05:06 +00:00
Go MAEDA
7752e9a19a Psych::DisallowedClass exception when loading default plugin settings (#37450, #37476). 
Contributed by Dmitry Makurin.


git-svn-id: https://svn.redmine.org/redmine/trunk@21725 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-07-21 00:41:29 +00:00
Go MAEDA
b6c218deed Don't use YAML.unsafe_load (#37450). 
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21722 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-07-20 03:05:10 +00:00
Go MAEDA
f52b3f90eb Mark edited journal notes as "Edited" (#31505). 
Patch by Marius BALTEANU.


git-svn-id: https://svn.redmine.org/redmine/trunk@21713 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-07-17 04:40:01 +00:00
Go MAEDA
6badcf374b Make the only enabled activity in a project the default one for time entry (#10314). 
Patch by Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21709 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-07-17 00:16:31 +00:00
Go MAEDA
2cd4996a54 Fix RuboCop offense Lint/NonAtomicFileOperation (#36919). 
git-svn-id: https://svn.redmine.org/redmine/trunk@21694 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-06-30 07:35:23 +00:00
Marius Balteanu
ad3f809beb Fix chained custom field filter doesn't work for User fields (#36940). 
Patch by Thomas Löber.



git-svn-id: https://svn.redmine.org/redmine/trunk@21686 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-06-27 18:04:07 +00:00
Marius Balteanu
3ff5aea8f7 Revert undesired change (#37349). 
git-svn-id: https://svn.redmine.org/redmine/trunk@21685 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-06-27 18:01:53 +00:00
Marius Balteanu
6e5b8f07ef Fix filter for chained User custom fields returns 500 internal server error when filtering after a float value (#37349). 
git-svn-id: https://svn.redmine.org/redmine/trunk@21684 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-06-27 17:58:14 +00:00
Marius Balteanu
ce1c1f04b6 Refactor @TimeEntryActivity.default()@ method (#33914). 
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21669 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-06-20 16:44:27 +00:00
Marius Balteanu
bfcb1b0054 Fix time entry activity is not set as default when the default activity exists as project specific activity (#33914). 
Patch by Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21668 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-06-20 15:26:47 +00:00
Marius Balteanu
b2bf7c6d8c Respect field visibility when filtering/sorting by associated issue fields (#37255). 
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21646 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-06-16 21:44:46 +00:00
Marius Balteanu
1a3ee38c2e Respect field visibility when showing associated issue fields (#37255). 
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21645 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-06-16 21:43:58 +00:00
Marius Balteanu
9c4df39c7d Setting @--no-permission-check@ in the mail receiver should not allow creating issues in closed and archived projects (#37187). 
Patch by Felix Schäfer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21641 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-06-16 21:32:02 +00:00
Marius Balteanu
68031b6544 Improved @fixed_version_id@ validation (#37171). 
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21638 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-06-16 15:13:09 +00:00
Marius Balteanu
e5550d5ed4 Ensure @category_id@ is valid within the issue's project (#37171). 
Patch by Holger Just. 


git-svn-id: https://svn.redmine.org/redmine/trunk@21637 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-06-16 15:10:25 +00:00
Go MAEDA
aef5983bdd The done ratio of a parent issue may not be 100% even if all subtasks have a done ratio of 100% (#37151). 
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21626 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-06-08 15:40:45 +00:00
Marius Balteanu
8be29b64d8 Reduce extra queries in @ProjectQuery.default@ (#37135). 
Patch by Dmitry Makurin.


git-svn-id: https://svn.redmine.org/redmine/trunk@21614 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-05-28 09:54:34 +00:00
Marius Balteanu
fcf792615a Issue#last_notes fallback does not respect notes visibility (#37155). 
Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21613 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-05-28 09:52:48 +00:00
Marius Balteanu
883aa3b5cc Background job for project deletion (#36691). 
Due to the deletion of dependent objects (issues etc), project deletion may take a long time.

This patch moves the actual project deletion into an ActiveJob job. It also introduces a new project status (SCHEDULED_FOR_DELETION) that is used to effectively hide the project that is about to be deleted (and any potential descendant projects) from the system immediately.

A security notification is sent out to the user that deleted the project, informing about success / failure.

The projects list is extended to be able to filter for the new status, so in case of a failure, the project can still be accessed for examination.

Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21591 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-05-17 20:45:41 +00:00
Go MAEDA
fe1202d626 Attachment activity provider SQL optimization (#37057). 
Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21573 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-05-14 07:38:36 +00:00
Marius Balteanu
5914b0ebc2 Allow imported time entries to override the selected project with the actual project of their issue (#36823). 
Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21522 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-04-03 07:54:27 +00:00
Marius Balteanu
83ed32e8d7 Reuse ProjectQuery filters on the admin project list (#33422). 
Patch by Takenori TAKAKI.


git-svn-id: https://svn.redmine.org/redmine/trunk@21519 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-04-01 15:08:52 +00:00
Marius Balteanu
883fcb89ee Include roles of built-in "Non member users" and "Anonymous users" members when user is not a member of the project. This fixes #34029. 
git-svn-id: https://svn.redmine.org/redmine/trunk@21502 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-03-27 21:29:05 +00:00
Marius Balteanu
9b25b348c3 Allow to filter issues by its version status with shared versions (#36824, #30924). 
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21499 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-03-24 16:52:20 +00:00
Go MAEDA
750c5e89fb Increase email address length limit from 60 to 254 (#36825). 
Contributed by Brice Beaumesnil.


git-svn-id: https://svn.redmine.org/redmine/trunk@21497 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-03-23 15:26:59 +00:00
Go MAEDA
2e86acfa87 Add tasks to prune registered users after a certain number of days (#30998). 
Patch by Yuichi HARADA and Marius BALTEANU.


git-svn-id: https://svn.redmine.org/redmine/trunk@21490 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-03-22 04:02:39 +00:00
Marius Balteanu
81575e7291 Skip validation of required custom fields when creating a project if user does not have permissions to see those custom fields (#36593). 
Patch by mathieu-mbru.


git-svn-id: https://svn.redmine.org/redmine/trunk@21488 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-03-21 22:13:19 +00:00
Go MAEDA
ab59d9bf87 Do not fire a query to get user default query when user has no default query set (#36503). 
Patch by Dmitry Makurin.


git-svn-id: https://svn.redmine.org/redmine/trunk@21485 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-03-21 06:10:54 +00:00
Go MAEDA
fccc19a451 Reverts r21480 (#36503). 
git-svn-id: https://svn.redmine.org/redmine/trunk@21484 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-03-21 06:00:21 +00:00
Marius Balteanu
d07c7d8e26 Do not fire a query to get user default query when user has no default query set (#36503). 
Patch by Dmitry Makurin.



git-svn-id: http://svn.redmine.org/redmine/trunk@21480 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-03-20 21:38:45 +00:00
Marius Balteanu
e50190a82a Automatically add the user to the watchers list after contributing to an issue (#4347). User can enable/disable this feature from My Account. 
Patch by Takenori TAKAKI and Jens Krämer. 


git-svn-id: http://svn.redmine.org/redmine/trunk@21469 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-03-19 10:14:29 +00:00
Marius Balteanu
f286a6044b Deprecate and rename rss_* methods to atom_* methods (#15118). 
Patch by Mischa The Evil and Marius BĂLTEANU


git-svn-id: http://svn.redmine.org/redmine/trunk@21467 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-03-19 09:56:46 +00:00
Go MAEDA
2d6f552599 Replace Member.find_or_new with ActiveRecord's find_or_initialize_by (#36730). 
git-svn-id: http://svn.redmine.org/redmine/trunk@21456 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-03-14 14:25:24 +00:00
Go MAEDA
cd688a1781 Improve performance of adding or removing members of a group (#36696). 
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21447 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-03-05 08:41:55 +00:00