meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-26 10:21:14 +00:00
Code Issues Releases Wiki Activity
18,372 Commits 32 Branches 194 Tags
Commit Graph

8441 Commits

Author SHA1 Message Date
Go MAEDA
eee5d73ee1 Revert r23002 (#39887). 
The change caused a test failure:

```
Failure:
UserTest#test_accessing_projects_by_role_with_no_projects_should_return_an_empty_array [test/unit/user_test.rb:1048]:
Expected: []
  Actual: nil
```


git-svn-id: https://svn.redmine.org/redmine/trunk@23006 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-09-01 01:33:00 +00:00
Go MAEDA
2190a4b417 Disable RuboCop Lint/InterpolationCheck for USER_FORMATS in app/models/user.rb (#39887). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23005 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-09-01 01:02:38 +00:00
Go MAEDA
987a36281a Fix RuboCop offense Style/EmptyLiteral (#39887). 
git-svn-id: https://svn.redmine.org/redmine/trunk@23002 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-09-01 00:42:33 +00:00
Go MAEDA
2fe36c4128 Fix RuboCop offense Style/RedundantInterpolationUnfreeze (#39887). 
Since interpolated strings are always unfrozen in Ruby 3.0 and later, the use of `+""` is now redundant.


git-svn-id: https://svn.redmine.org/redmine/trunk@23001 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-09-01 00:38:01 +00:00
Go MAEDA
8da72cb712 Fix precision issues in TimeEntry#hours calculation by returning Rational instead of Float (#40914). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23000 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-31 09:26:50 +00:00
Marius Balteanu
1bf607edb9 Replaces icon-email and icon-passwd icons with SVG icons (#23980). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22999 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-31 08:11:18 +00:00
Marius Balteanu
cafb610b7f Fixes icon-multiple (#23980). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22998 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-31 08:10:48 +00:00
Marius Balteanu
565ed934a5 Do not show icon-cancel backgrond icon if element contains a SVG element (#23980). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22997 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-31 07:48:19 +00:00
Marius Balteanu
6d7c7cda6e Replaces zoom-in icon with SVG icon in ssues report (#23980). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22996 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-31 07:41:55 +00:00
Marius Balteanu
6beb892c5f Do not show fav/fav-off backgrond icon if element contains a SVG element (#23980)." 
git-svn-id: https://svn.redmine.org/redmine/trunk@22995 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-31 07:34:57 +00:00
Marius Balteanu
93080bd1bb Replaces zoom-in and zoom-out icons with SVG icons in Gantt (#23980). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22994 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-31 07:33:34 +00:00
Marius Balteanu
768511f7cb Removes extra spaces in icon classes introduced by r22988 (#23980). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22993 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-31 07:24:16 +00:00
Marius Balteanu
dc68230e05 Fixes more tests. 
git-svn-id: https://svn.redmine.org/redmine/trunk@22991 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-30 15:50:22 +00:00
Marius Balteanu
6b327b8852 Add icon to attachment link only when icon variable is passed. 
git-svn-id: https://svn.redmine.org/redmine/trunk@22990 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-30 15:50:08 +00:00
Marius Balteanu
ee54f091cb Fix failing tests by including IconsHelper in ApplicationHelper (#23980). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22989 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-30 06:25:08 +00:00
Marius Balteanu
ffce07e785 Start working on replacing old icons with SVG icons (#23980): 
* Introduces IconsHelper with methods to render SVG icon from a sprite file.
* Adds SVG sprite file with icons mainly from Font Awesome, but also from Material Design Icons and Fluent UI System Icons (based on the work made by Takashi Kato (@tohosaku)).
* Replaces specific icons with new SVG icons.
* Temporarily keep all old CSS icon definitions for backard compatibility.



git-svn-id: https://svn.redmine.org/redmine/trunk@22988 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-29 21:46:40 +00:00
Go MAEDA
fdd90bab2b Fix RuboCop offenses Style/NegatedIf and Style/NegatedWhile (#39887, #7770). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22987 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-25 08:44:33 +00:00
Go MAEDA
9c2bcfea29 Fix untranslated string "OK" in repositories diff view (#39778). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22983 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-24 05:54:29 +00:00
Go MAEDA
e874a53d01 Revert r22981: Incorrect issue number #39887 referenced 
git-svn-id: https://svn.redmine.org/redmine/trunk@22982 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-24 05:53:06 +00:00
Go MAEDA
546c1c0349 Fix untranslated string "OK" in repositories diff view (#39887). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22981 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-24 05:48:56 +00:00
Go MAEDA
c2eb20e434 Fix RuboCop offense Style/ClassEqualityComparison (#39887). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22978 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-21 13:45:13 +00:00
Go MAEDA
9cc3542fa1 Introduce active? method to Group via Principal model (#27510). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22976 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-21 08:05:59 +00:00
Go MAEDA
643b4ebb08 Add filters for "Author's group" and "Author's role" to issues list (#7867). 
Patch by Takenori TAKAKI (user:takenory).


git-svn-id: https://svn.redmine.org/redmine/trunk@22975 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-21 07:47:27 +00:00
Go MAEDA
93645a279e Use anonymous block forwarding introduced in Ruby 3.1 (#38585). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22973 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-21 00:46:15 +00:00
Go MAEDA
c069ea3a24 Use Array#intersect? introduced in Ruby 3.1 (#38585). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22972 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-20 23:40:58 +00:00
Marius Balteanu
9d50075279 Replaces removed ActiveSupport::Deprecation.warn with custom deprecators (#41141, #36320). 
Patch by Takashi Kato (user:tohosaku).


git-svn-id: https://svn.redmine.org/redmine/trunk@22961 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-20 05:58:38 +00:00
Marius Balteanu
fb37d2e4fa Upgrade to Rails 7.2.0 (#36320). 
Patch by Takashi Kato (user:tohosaku). 


git-svn-id: https://svn.redmine.org/redmine/trunk@22960 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-20 05:54:30 +00:00
Go MAEDA
65597ec1cf Add filters for "User's group" and "User's role" to Spent time list (#41053). 
Patch by Takenori TAKAKI (user:takenory).


git-svn-id: https://svn.redmine.org/redmine/trunk@22958 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-16 02:05:25 +00:00
Go MAEDA
b3d1deeece Fix RuboCop offense Layout/SpaceInsideParens, one of the offenses enabled in rubocop-rails-omakase (#39887). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22954 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-12 08:45:54 +00:00
Go MAEDA
79873291d7 Fix RuboCop offense Layout/EmptyLinesAroundModuleBody, one of the offenses enabled in rubocop-rails-omakase (#39887). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22951 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-12 07:51:45 +00:00
Go MAEDA
74e2262efb Fix RuboCop offense Layout/EmptyLinesAroundMethodBody, one of the offenses enabled in rubocop-rails-omakase (#39887). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22950 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-12 07:46:58 +00:00
Go MAEDA
174c237c70 Fix incorrect sorting of users grouped by status in issue filters for administrators (#41079). 
Patch by Vladislav Moiseev (user:vladdy.moses).


git-svn-id: https://svn.redmine.org/redmine/trunk@22947 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-08-11 08:30:40 +00:00
Go MAEDA
fded8025d5 Add project identifier to List-Id header in notification emails (#13359). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22944 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-26 03:19:22 +00:00
Go MAEDA
0247ebb394 Set default age parameter for User.prune method to 30 days (#41023). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22938 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-19 08:26:13 +00:00
Go MAEDA
ee31bf8fe9 Add an option to render Integer and Float custom fields with thousands delimiters (#39997). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22935 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-18 04:56:20 +00:00
Go MAEDA
4879302930 Refactor ApplicationHelper#format_object to accept options as a hash (#39997). 
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22933 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-18 04:26:49 +00:00
Go MAEDA
6c8b04d6d5 Add configurable setting for copying attachments when copying an issue (#36197). 
Patch by Yuichi HARADA (user:yui.har).


git-svn-id: https://svn.redmine.org/redmine/trunk@22926 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-14 01:49:53 +00:00
Marius Balteanu
6322650728 Add bulk unlock to user list context menu (#40913). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22925 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-13 10:21:49 +00:00
Go MAEDA
47d7dd0187 Fix RuboCop offense Style/CollectionCompact (#39887). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22921 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-11 09:35:32 +00:00
Marius Balteanu
c15c754589 Introduces @valid_watcher?@ check on watchables (@40946). 
Patch by Jens Krämer (@jkraemer).



git-svn-id: https://svn.redmine.org/redmine/trunk@22916 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-08 21:33:50 +00:00
Marius Balteanu
57743c4145 Permission check based on the type of @watchables@ (#40946). 
Patch by Jens Krämer (@jkraemer).



git-svn-id: https://svn.redmine.org/redmine/trunk@22915 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-08 21:32:15 +00:00
Marius Balteanu
f9f486bdd0 Check view watchers permission when copying issues (#40946). 
Patch by Jens Kraemer (@jkraemer).


git-svn-id: https://svn.redmine.org/redmine/trunk@22914 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-08 21:30:36 +00:00
Marius Balteanu
2d20811f40 Improve watcher list permissions check to explicitly require @view_issue_watchers@ permission (#40946). 
Patch by Felix Schäfer (@felix).



git-svn-id: https://svn.redmine.org/redmine/trunk@22913 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-08 21:28:24 +00:00
Marius Balteanu
c1eff66f68 Truncate git authors to 255 characters (#40948). 
The committer column in the database allows max 255 characters. With longer authors, this would result in a schema violation. By manually truncating the author field, we can avoid this.

Patch by Holger Just (@hjust). 



git-svn-id: https://svn.redmine.org/redmine/trunk@22910 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-08 20:35:16 +00:00
Go MAEDA
2b786a6f48 Spent hours ignoring "Time Span Format" Setting on several pages (#40924). 
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22902 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-30 14:37:12 +00:00
Go MAEDA
578c53a932 Disable custom query links while loading to prevent multiple requests (#40901). 
Patch by Mizuki ISHIKAWA (@ishikawa999).


git-svn-id: https://svn.redmine.org/redmine/trunk@22901 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-27 08:41:45 +00:00
Go MAEDA
f82d8314d9 Expose project updated_on column and filter in project query (#40829). 
Patch by Felix Schäfer (@felix).


git-svn-id: https://svn.redmine.org/redmine/trunk@22899 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-27 04:46:27 +00:00
Marius Balteanu
193ca9faee Add bulk lock feature to user list context menu (#40913). 
Patch by Mizuki ISHIKAWA (@ishikawa999).


git-svn-id: https://svn.redmine.org/redmine/trunk@22898 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-25 19:03:36 +00:00
Go MAEDA
b5078e314a Creating a new issue fails with an internal error if no issue priorities are defined (#40860). 
Patch by Holger Just (@hjust).


git-svn-id: https://svn.redmine.org/redmine/trunk@22895 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-25 02:09:40 +00:00
Go MAEDA
719b0ce615 Reject passwords that are the same as login, first name, last name, or email (#37279). 
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22888 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-06-21 05:32:46 +00:00