Toshi MARUYAMA
ad97b5afec
remove spaces inside {} of AccountController
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19902 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-15 16:36:31 +00:00
Toshi MARUYAMA
445f6528e2
avoid using rescue in its modifier form at WatchersController#find_objects_from_params
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19865 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-08 17:30:19 +00:00
Toshi MARUYAMA
ddcdac3017
avoid using rescue in its modifier form at ImportsController#import_type
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19864 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-08 17:30:12 +00:00
Toshi MARUYAMA
8b0c21cbf8
avoid using rescue in its modifier form at AttachmentsController#find_container
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19863 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-08 17:30:04 +00:00
Toshi MARUYAMA
562dea3aa8
avoid using rescue in its modifier form at ApplicationController#find_current_user
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19862 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-08 17:29:56 +00:00
Toshi MARUYAMA
0b138f1c4e
avoid multi-line ternary operators in app/controllers/workflows_controller.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19854 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-04 12:14:11 +00:00
Go MAEDA
925fbe9263
Ordering wiki pages should not be case sensitive ( #31287 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19831 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-06-20 06:50:28 +00:00
Go MAEDA
81969c28b5
Fix typo in app/controllers/watchers_controller.rb ( #33567 ).
...
Patch by Pavel Rosický.
git-svn-id: http://svn.redmine.org/redmine/trunk@19823 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-06-16 09:06:42 +00:00
Go MAEDA
a4597c31d2
Fix that issues autocomplete may not find issues with a subject longer than 60 characters ( #32125 ).
...
Contributed by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19784 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-05-18 14:13:58 +00:00
Go MAEDA
302f9bbc76
Reverts r19773 ( #32125 ).
...
The purpose of reverting is to revert r19769 on which r19773 depends.
git-svn-id: http://svn.redmine.org/redmine/trunk@19775 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-05-14 13:40:59 +00:00
Go MAEDA
e16080614e
Fix that issues autocomplete may not find issues with a subject longer than 60 characters ( #32125 ).
...
Contributed by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19773 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-05-13 07:22:44 +00:00
Go MAEDA
c37a45d1c3
Revert r19771 due to the incorrect issue number in the commit message.
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19772 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-05-13 07:21:07 +00:00
Go MAEDA
f61f19518f
Fix that issues autocomplete may not find issues with a subject longer than 60 characters ( #12250 ).
...
Contributed by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19771 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-05-13 00:46:51 +00:00
Go MAEDA
fd1d89827e
Redirect to index page instead of edit page after creating a new custom field ( #32783 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19749 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-05-04 00:46:50 +00:00
Go MAEDA
ee46c3570e
Use scope assignable_watchers ( #4511 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@19726 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-25 08:01:59 +00:00
Go MAEDA
f09e0e8f8c
Use Principal to get users and groups for watchers in watchers controller ( #4511 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@19724 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-25 07:59:49 +00:00
Go MAEDA
f19c291b59
Show groups in members box on project overview page ( #33174 ).
...
Patch by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19718 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-22 14:52:58 +00:00
Go MAEDA
ea54e1acdb
Fix that bulk download raises Errno::EACCES on Windows ( #7056 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19688 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-11 07:58:01 +00:00
Jean-Philippe Lang
31c8e71d8e
Set time entry author in controller ( #32774 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19677 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-05 19:24:32 +00:00
Jean-Philippe Lang
99df2c5c58
Creating time tracking entry for other user through rest API fails with 403 ( #32774 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19676 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-05 18:39:05 +00:00
Jean-Philippe Lang
d955672a7d
Reverted r19669 and r19670 ( #32774 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19675 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-05 17:29:53 +00:00
Jean-Philippe Lang
3fcaff3670
Creating time tracking entry for other user through rest API fails with 403 ( #32774 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19670 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-05 14:28:06 +00:00
Jean-Philippe Lang
ba27fe1b4e
Creating time tracking entry for other user through rest API fails with 403 ( #32774 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@19669 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-05 14:23:40 +00:00
Go MAEDA
6e781f6479
Fix that "Successful deletion" notice is not displayed after deleting some types of content ( #33116 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19641 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-04 00:43:28 +00:00
Go MAEDA
fd75ebcd12
Replace File#readable? with Attachment#readable? ( #7056 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19635 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-02 05:52:39 +00:00
Go MAEDA
4a7bc593af
Display bulk_download_max_size in human-readable representation ( #7056 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19609 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-23 05:52:40 +00:00
Go MAEDA
ab47fb8ae0
Download all attachments at once ( #7056 ).
...
Patch by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19601 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-21 05:59:31 +00:00
Go MAEDA
34977f9199
Fix that unable to update the values of a custom field for time tracking activities when multiple values option is enabled ( #33085 ).
...
Patch by Thomas Löber.
git-svn-id: http://svn.redmine.org/redmine/trunk@19588 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-20 02:25:13 +00:00
Go MAEDA
af36d450e4
Reverts r19569 ( #33071 ).
...
404 error after deleting an attachment.
git-svn-id: http://svn.redmine.org/redmine/trunk@19579 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-14 03:49:44 +00:00
Go MAEDA
463e8163fc
Require sudo mode for actions to delete contents ( #33071 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19569 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-10 03:26:23 +00:00
Go MAEDA
907e0173e4
Update copyright year in source files to 2020 ( #33069 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Go MAEDA
6b0afdc9ca
"Role" dropdown in Workflow page is unexpectedly expanded when selecting "all" ( #33059 ).
...
Patch by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19538 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-29 04:59:48 +00:00
Go MAEDA
cc900c0e07
Diff view for .js files in repositories is broken ( #32449 ).
...
Patch by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19531 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-27 01:19:11 +00:00
Go MAEDA
efbfc76161
Auto select fields mapping in import based on the internal field name (ex: estimared_hours, fixed_version, spent_on) or field label (Estimated hours, Version, Date) ( #22913 ).
...
* mappings are case insensitive
* a field is auto mapped only if there is no mapping setting present for that field
* "Current user" default value for User field when the user has permission to log time for other users is override by the auto mapped column
Patch by Haihan Ji, Yuichi HARADA, and Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@19524 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-19 14:52:02 +00:00
Go MAEDA
dec5f98112
Include attachments in forum post notifications ( #16006 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19506 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-11 02:34:25 +00:00
Go MAEDA
b995014c49
Allow adding user groups as watchers for issues ( #4511 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19498 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-06 08:19:13 +00:00
Go MAEDA
a0b909d523
Repository browser does not render previews for audio/video files ( #32153 ).
...
Patch by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19492 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-04 05:32:04 +00:00
Jean-Philippe Lang
0cd14b3a4b
Validate back_url everywhere ( #32850 ).
...
Patch by Holger Just.
git-svn-id: http://svn.redmine.org/redmine/trunk@19488 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-02 08:39:22 +00:00
Jean-Philippe Lang
b3cda4fd61
Expose validate_back_url as helper method ( #32850 ).
...
Patch by Holger Just.
git-svn-id: http://svn.redmine.org/redmine/trunk@19487 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-02 08:38:47 +00:00
Jean-Philippe Lang
914f57fefc
Move duplicated back_url method from ApplicationHelper to ApplicationController ( #32850 ).
...
Patch by Holger Just.
git-svn-id: http://svn.redmine.org/redmine/trunk@19486 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-02 08:38:01 +00:00
Jean-Philippe Lang
13da124b16
CSV import does not keep the project it was clicked from ( #21766 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@19381 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-12-20 08:07:57 +00:00
Go MAEDA
92232cc602
Fix "Couldn't find template for digesting" error in the log when sending an attachment or thumbnail ( #20277 ).
...
Patch by Olivier Houdas.
git-svn-id: http://svn.redmine.org/redmine/trunk@19365 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-12-12 14:32:25 +00:00
Go MAEDA
f7fcd111e9
Ruby 2.7: Regexp#match and Regexp#match? with a nil argument are deprecated ( #32527 , #31500 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19324 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-30 05:40:40 +00:00
Go MAEDA
f33d6177fe
Add buttons to save/edit/delete a custom query to calendar view ( #32194 ).
...
Patch by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@19322 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-30 00:58:45 +00:00
Toshi MARUYAMA
677dfdc883
replace multi line block "{}" to "do end" in app/controllers/issues_controller.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19319 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-26 06:31:04 +00:00
Toshi MARUYAMA
e27dc4d547
cleanup: rubocop: fix Layout/SpaceInsideBlockBraces in app/controllers/issues_controller.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19318 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-26 06:30:53 +00:00
Toshi MARUYAMA
8ee394e97a
cleanup: rubocop: fix Layout/SpaceInsideHashLiteralBraces in app/controllers/issues_controller.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19317 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-26 06:30:42 +00:00
Toshi MARUYAMA
52d8b21f8d
code layout clean up app/controllers/workflows_controller.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19287 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-25 06:33:00 +00:00
Toshi MARUYAMA
cb591d0af6
code layout clean up app/controllers/application_controller.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19284 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-25 06:32:28 +00:00
Toshi MARUYAMA
d81846ccc9
cleanup: rubocop: fix Layout/SpaceAfterComma in app/controllers/documents_controller.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@19272 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-24 16:45:12 +00:00