meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-24 01:11:12 +00:00
Code Issues Releases Wiki Activity
13,599 Commits 32 Branches 194 Tags
Commit Graph

2600 Commits

Author SHA1 Message Date
Toshi MARUYAMA
4e7ae640b9 add copyright header to test/unit/lib/redmine/helpers/url_test.rb (#12510) 
git-svn-id: http://svn.redmine.org/redmine/trunk@17077 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-12-07 14:28:41 +00:00
Toshi MARUYAMA
93d8204b8a code clean up IssuesPdfHelperTest (#12510) 
* remove extra empty lines
* remove trailing white space
* replace tab to two spaces

git-svn-id: http://svn.redmine.org/redmine/trunk@17065 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-12-07 12:03:08 +00:00
Toshi MARUYAMA
9d797400ea mercurial: work around faulty parsing of early command options (#27516) 
Use -sVALUE and --long=VALUE instead of "-s VALUE" and "--long VALUE"
respectively.

Contributed by Yuya Nishihara.

git-svn-id: http://svn.redmine.org/redmine/trunk@17062 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-12-07 11:38:47 +00:00
Toshi MARUYAMA
ca87bf766c mercurial: reject malicious command argument (#27516) 
We've got a security report from the Phabricator team, which basically says
--config and --debugger arguments can be injected anywhere to lead to an
arbitrary command execution.

https://secure.phabricator.com/rPa7921a4448093d00defa8bd18f35b8c8f8bf3314

This is a fundamental issue of the argument parsing rules in Mercurial, which
allows extensions to populate their parsing rules and such extensions can be
loaded by "--config extensions.<name>=". There's a chicken and egg problem.
We're working on hardening the parsing rules, but which won't come in by
default as it would be a behavior change.

This patch adds a verification to reject malicious command arguments as a
last ditch. The subsequent patches will fix the problem in more appropriate
way.

Contributed by Yuya Nishihara.

git-svn-id: http://svn.redmine.org/redmine/trunk@17060 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-12-07 11:38:23 +00:00
Go MAEDA
d6d2d23365 Fix: Round floats to 2 digits when rendering an issue list to PDF (#12510). 
Patch by Holger Just and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17059 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-12-06 14:25:35 +00:00
Go MAEDA
ae842a73db Disallow creating inverse relates issue relations (#27663). 
Patch by Gregor Schmidt.


git-svn-id: http://svn.redmine.org/redmine/trunk@17056 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-12-06 09:01:07 +00:00
Go MAEDA
0ed07156ad Reverted r17054 (#27663). 
The change breaks test/functional/issue_relations_controller_test.rb.



git-svn-id: http://svn.redmine.org/redmine/trunk@17055 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-11-30 00:02:02 +00:00
Go MAEDA
3a310ccc2e Disallow creating inverse relates issue relations (#27663). 
Patch by Gregor Schmidt.


git-svn-id: http://svn.redmine.org/redmine/trunk@17054 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-11-29 22:22:39 +00:00
Jean-Philippe Lang
62d6dfe1cc Fixes visibility checks for version.fixed_issues in Gantt (#27676). 
Like the version page - the Gantt chart featured a "percent done" info
for each version, which wasn't properly limited to visible issues.

Patch by Gregor Schmidt.

git-svn-id: http://svn.redmine.org/redmine/trunk@17053 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-11-29 19:38:44 +00:00
Go MAEDA
9ae7bc8152 Make robust Redmine::Helpers::URL#uri_with_safe_scheme? (#27114) 
Patch by okkez.


git-svn-id: http://svn.redmine.org/redmine/trunk@17035 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-11-26 03:44:37 +00:00
Toshi MARUYAMA
abe914fd3f add test that anonymous user can add watchers by mail (#26654) 
git-svn-id: http://svn.redmine.org/redmine/trunk@16963 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-09-07 17:22:14 +00:00
Jean-Philippe Lang
9f9f7993e6 #assert_nothing_raised takes no arguments. 
git-svn-id: http://svn.redmine.org/redmine/trunk@16944 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-08-01 21:40:58 +00:00
Toshi MARUYAMA
eb1998ef39 try IssueTest#test_overdue failing on CI server at Japanese daytime (#22320) 
git-svn-id: http://svn.redmine.org/redmine/trunk@16938 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-31 06:57:35 +00:00
Jean-Philippe Lang
a9e4b41d4a Move helper tests to test/helpers (#26504). 
git-svn-id: http://svn.redmine.org/redmine/trunk@16930 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-30 18:23:06 +00:00
Jean-Philippe Lang
d827fc4a75 Skip all issue concurrency tests with MySQL. 
git-svn-id: http://svn.redmine.org/redmine/trunk@16926 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-30 17:09:45 +00:00
Toshi MARUYAMA
09148ba665 add missing fixture for IssueTest#test_update_should_notify_previous_assignee 
git-svn-id: http://svn.redmine.org/redmine/trunk@16894 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-27 07:19:31 +00:00
Jean-Philippe Lang
9f346d5921 Make sure that something was actually deleted. 
git-svn-id: http://svn.redmine.org/redmine/trunk@16890 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-26 16:43:19 +00:00
Jean-Philippe Lang
71423af0b2 Get rid of acts_as_versioned. 
WikiContent::Version becomes WikiContentVersion.

git-svn-id: http://svn.redmine.org/redmine/trunk@16889 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-26 16:41:06 +00:00
Jean-Philippe Lang
0910b2bdbe Drop Darcs support (#26391). 
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@16886 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-25 17:32:53 +00:00
Jean-Philippe Lang
1cb1be17a9 Fixed link to user in email notifications (#26506). 
git-svn-id: http://svn.redmine.org/redmine/trunk@16876 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-24 16:59:23 +00:00
Jean-Philippe Lang
de4df036f5 Test fails with mysql 5.7. 
git-svn-id: http://svn.redmine.org/redmine/trunk@16874 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-23 21:06:52 +00:00
Jean-Philippe Lang
d74f0bfd5c Merged rails-5.1 branch (#23630). 
git-svn-id: http://svn.redmine.org/redmine/trunk@16859 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-23 11:26:04 +00:00
Jean-Philippe Lang
1ff3e91033 Adds a test for importing list custom fields with multiple values (#26148). 
git-svn-id: http://svn.redmine.org/redmine/trunk@16837 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-19 17:07:13 +00:00
Jean-Philippe Lang
3cc483180a Adds a test for importing list custom fields (#26148). 
git-svn-id: http://svn.redmine.org/redmine/trunk@16834 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-19 14:58:06 +00:00
Jean-Philippe Lang
7bd8280a83 Adds settings for time entry hours validation (#24005). 
git-svn-id: http://svn.redmine.org/redmine/trunk@16832 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-19 14:13:10 +00:00
Jean-Philippe Lang
85a0e96ad6 Set a default size for macro thumbnails different from the preview thumbnails. 
git-svn-id: http://svn.redmine.org/redmine/trunk@16829 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-19 07:00:27 +00:00
Jean-Philippe Lang
a7e88dca7d Fixed that formatting of commit message is never applied (#26445). 
git-svn-id: http://svn.redmine.org/redmine/trunk@16823 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-16 18:02:38 +00:00
Toshi MARUYAMA
48259a1eda add some tests to RepositoryTest#test_for_changeset_comments_strip 
git-svn-id: http://svn.redmine.org/redmine/trunk@16811 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-10 04:48:19 +00:00
Toshi MARUYAMA
7187e8dade code style cleanup at RepositoryTest#test_for_changeset_comments_strip 
git-svn-id: http://svn.redmine.org/redmine/trunk@16810 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-10 04:48:08 +00:00
Toshi MARUYAMA
3a0cc09d7c replace white spaces of here-text　at RepositoryTest#test_for_changeset_comments_strip 
git-svn-id: http://svn.redmine.org/redmine/trunk@16809 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-10 04:47:56 +00:00
Jean-Philippe Lang
2bc719e2c8 LdapError is deprecated (#24970). 
git-svn-id: http://svn.redmine.org/redmine/trunk@16773 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-08 13:46:47 +00:00
Jean-Philippe Lang
92ca57e938 Fixed User#project_ids_by_role when first called within chained scopes (#26376). 
git-svn-id: http://svn.redmine.org/redmine/trunk@16767 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-08 12:15:10 +00:00
Jean-Philippe Lang
c7e32aa202 "attachment:filename" should generate a link to preview instead of download (#26310, #25988). 
git-svn-id: http://svn.redmine.org/redmine/trunk@16738 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-07-02 09:54:24 +00:00
Jean-Philippe Lang
dd650c5c26 Setting to disable automatic closing of duplicates (#26192). 
git-svn-id: http://svn.redmine.org/redmine/trunk@16697 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-25 11:40:58 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright. 
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-25 08:40:31 +00:00
Toshi MARUYAMA
04fa679cb8 add test of email reminder in case of user language is 'auto' (#26247) 
git-svn-id: http://svn.redmine.org/redmine/trunk@16682 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-23 16:46:05 +00:00
Toshi MARUYAMA
2b24a617e1 code layout cleanup test/unit/custom_field_test.rb 
git-svn-id: http://svn.redmine.org/redmine/trunk@16678 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-19 05:38:48 +00:00
Toshi MARUYAMA
741fff9956 code layout cleanup test/unit/mail_handler_test.rb 
git-svn-id: http://svn.redmine.org/redmine/trunk@16677 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-19 05:38:36 +00:00
Jean-Philippe Lang
7017874cc9 Link to user by id (#4179). 
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@16671 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-17 08:48:23 +00:00
Jean-Philippe Lang
f902860955 Link to user in wiki syntax (#4179). 
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@16636 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-07 20:10:57 +00:00
Jean-Philippe Lang
24c2416ffe Tests for Redmine::SyntaxHighlighting::CodeRay.retrieve_supported_languages (#26055). 
Patch by Mischa The Evil.

git-svn-id: http://svn.redmine.org/redmine/trunk@16625 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-06 21:56:56 +00:00
Jean-Philippe Lang
b997f03211 Set default assignee before validation (#26072). 
git-svn-id: http://svn.redmine.org/redmine/trunk@16619 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-06 21:11:37 +00:00
Toshi MARUYAMA
c02c9ac1f7 remove trailing white space from test/unit/project_nested_set_test.rb 
git-svn-id: http://svn.redmine.org/redmine/trunk@16610 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-06 02:12:24 +00:00
Toshi MARUYAMA
8c03f2a6db allow unicode whitespace after mail handler body delimiters (#17718) 
Contributed by Holger Just and Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@16609 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-06 01:34:52 +00:00
Jean-Philippe Lang
44c748f968 Use regular instance methods instead of association extensions. 
Rails 5.1 seems to mess things up in this particular case (role.workflow_rules.copy calls the extension declare in Tracker model).

git-svn-id: http://svn.redmine.org/redmine/trunk@16597 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-03 08:04:13 +00:00
Toshi MARUYAMA
1d4300b674 remove trailing white-space from test/unit/mailer_test.rb 
git-svn-id: http://svn.redmine.org/redmine/trunk@16584 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-05-30 18:18:18 +00:00
Toshi MARUYAMA
153409d30f remove trailing white-spaces from test/unit/issue_subtasking_test.rb 
git-svn-id: http://svn.redmine.org/redmine/trunk@16579 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-05-27 16:26:41 +00:00
Jean-Philippe Lang
ba37a2c476 Show statuses of project trackers only (#5385). 
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@16575 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-05-27 09:12:42 +00:00
Jean-Philippe Lang
335a16e4fd Cusotom field label should not be associated to the first input (#25760). 
git-svn-id: http://svn.redmine.org/redmine/trunk@16574 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-05-27 08:49:08 +00:00
Jean-Philippe Lang
8ba7b6a2b2 Highlight language aliases are no more supported (#25634). 
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@16568 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-05-27 07:53:16 +00:00