meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-25 01:41:14 +00:00
Code Issues Releases Wiki Activity
18,836 Commits 32 Branches 194 Tags
Commit Graph

76 Commits

Author SHA1 Message Date
Marius Balteanu
d63678068a Fix random test failure by ensuring @WatchersController#find_objects_from_params@ returns results in consistent order (#41894). 
Patch by Go MAEDA (user:maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@23325 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-11-29 07:52:05 +00:00
Marius Balteanu
c15c754589 Introduces @valid_watcher?@ check on watchables (@40946). 
Patch by Jens Krämer (@jkraemer).



git-svn-id: https://svn.redmine.org/redmine/trunk@22916 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-08 21:33:50 +00:00
Marius Balteanu
57743c4145 Permission check based on the type of @watchables@ (#40946). 
Patch by Jens Krämer (@jkraemer).



git-svn-id: https://svn.redmine.org/redmine/trunk@22915 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-08 21:32:15 +00:00
Marius Balteanu
2d20811f40 Improve watcher list permissions check to explicitly require @view_issue_watchers@ permission (#40946). 
Patch by Felix Schäfer (@felix).



git-svn-id: https://svn.redmine.org/redmine/trunk@22913 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-07-08 21:28:24 +00:00
Go MAEDA
a9518e28b8 Fix RuboCop offense Rails/HttpStatus (#39889). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22837 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-05-18 05:56:55 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-02-26 22:55:54 +00:00
Marius Balteanu
13aeb797cf Use ApplicationRecord instead of ActiveRecord::Base (#38975). 
Patch by Minoru Maeda (@maeda-m).

git-svn-id: https://svn.redmine.org/redmine/trunk@22619 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2024-01-23 11:52:38 +00:00
Marius Balteanu
539d0f867e Explicitly render a 404 on non-JS requests to @watchers#new@ (#39894). 
Patch by @hjust.

git-svn-id: https://svn.redmine.org/redmine/trunk@22538 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-12-21 06:47:32 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141). 
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2023-01-01 06:19:35 +00:00
Marius Balteanu
ba74ba1c70 Allow users to be mentioned using @ in issues and wiki pages (#13919): 
* the user must have add watchers permission on that object in order to mention other users
* mentioned user will receive a notification email
* only visible users who can view the object can be mentioned



git-svn-id: http://svn.redmine.org/redmine/trunk@21435 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-02-23 21:16:18 +00:00
Marius Balteanu
d2f64ee928 Fix autocomplete for users fails with 403 error when there are multiple objects from different projects (#36446). 
Patch by Dmitry Makurin.


git-svn-id: http://svn.redmine.org/redmine/trunk@21394 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-02-01 20:11:56 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379). 
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2022-01-02 05:29:10 +00:00
Marius Balteanu
04e27aa161 Enforce stricter class filtering in WatchersController (35463). 
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@21235 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-10-05 16:46:03 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069). 
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-03-25 06:58:56 +00:00
Go MAEDA
0f4228d4e6 Do not propose watchers that are not allowed to see the object (#33329). 
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20724 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2021-01-24 05:31:18 +00:00
Toshi MARUYAMA
5336205c79 shorten long line of WatchersController 
git-svn-id: http://svn.redmine.org/redmine/trunk@20272 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-11-06 13:00:05 +00:00
Toshi MARUYAMA
72c59b010b use "do end" instead of {} at WatchersController 
git-svn-id: http://svn.redmine.org/redmine/trunk@20258 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-11-05 13:41:44 +00:00
Toshi MARUYAMA
efc6e5e7c5 add empty line after guard clause to WatchersController 
git-svn-id: http://svn.redmine.org/redmine/trunk@20225 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-10-28 14:43:06 +00:00
Toshi MARUYAMA
445f6528e2 avoid using rescue in its modifier form at WatchersController#find_objects_from_params 
git-svn-id: http://svn.redmine.org/redmine/trunk@19865 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-07-08 17:30:19 +00:00
Go MAEDA
81969c28b5 Fix typo in app/controllers/watchers_controller.rb (#33567). 
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@19823 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-06-16 09:06:42 +00:00
Go MAEDA
ee46c3570e Use scope assignable_watchers (#4511). 
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19726 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-04-25 08:01:59 +00:00
Go MAEDA
f09e0e8f8c Use Principal to get users and groups for watchers in watchers controller (#4511). 
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19724 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-04-25 07:59:49 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069). 
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-03-03 00:24:10 +00:00
Go MAEDA
b995014c49 Allow adding user groups as watchers for issues (#4511). 
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19498 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2020-02-06 08:19:13 +00:00
Go MAEDA
4082069c75 Update copyright year. 
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-05-25 07:36:06 +00:00
Go MAEDA
07b3087fda Enable frozen_string_literal for some files under app and lib directory (#26561). 
git-svn-id: http://svn.redmine.org/redmine/trunk@17977 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-03-16 09:37:35 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561). 
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2019-03-15 01:32:57 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright. 
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
8b107b6058 Don't use render :text => "". 
git-svn-id: http://svn.redmine.org/redmine/trunk@15731 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2016-07-21 20:49:14 +00:00
Jean-Philippe Lang
3396d5a1c4 Use head instead of render :nothing => true. 
git-svn-id: http://svn.redmine.org/redmine/trunk@15671 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2016-07-16 09:46:51 +00:00
Jean-Philippe Lang
17aa2f68c2 Don't compare with Hash. 
git-svn-id: http://svn.redmine.org/redmine/trunk@15670 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2016-07-16 09:41:24 +00:00
Jean-Philippe Lang
ee82a55602 Use .before_action instead of .before_filter. 
git-svn-id: http://svn.redmine.org/redmine/trunk@15655 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2016-07-14 07:27:31 +00:00
Jean-Philippe Lang
933dc946d4 Preload project when possible (#5754). 
git-svn-id: http://svn.redmine.org/redmine/trunk@15314 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2016-04-09 07:54:43 +00:00
Jean-Philippe Lang
14234eae39 Don't reject users that already watch one of the objects (#5754). 
git-svn-id: http://svn.redmine.org/redmine/trunk@15313 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2016-04-09 07:42:52 +00:00
Jean-Philippe Lang
5adc1ddde9 Allow addition of watchers via bulk edit context menu (#5754). 
git-svn-id: http://svn.redmine.org/redmine/trunk@15311 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2016-04-09 07:37:49 +00:00
Jean-Philippe Lang
cda9c63d9c Updates copyright for 2016. 
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2016-03-13 10:30:10 +00:00
Jean-Philippe Lang
9b52ae5c5a Fixed that user with permission can't remove a locked watcher (#21382). 
git-svn-id: http://svn.redmine.org/redmine/trunk@14946 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2015-12-05 10:21:07 +00:00
Jean-Philippe Lang
000124f44f Copyright update. 
git-svn-id: http://svn.redmine.org/redmine/trunk@13872 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2015-01-11 09:09:50 +00:00
Jean-Philippe Lang
bdd3ccf8e5 Adds a role setting for controlling visibility of users: all or members of visible projects (#11724). 
git-svn-id: http://svn.redmine.org/redmine/trunk@13584 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-11-11 13:08:52 +00:00
Jean-Philippe Lang
2d1866d966 Merged rails-4.1 branch (#14534). 
git-svn-id: http://svn.redmine.org/redmine/trunk@13482 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-10-22 17:37:16 +00:00
Jean-Philippe Lang
b29c48717d Fixed: Error generated on 'search for watchers to add' after clicking add without selected users (#14298). 
git-svn-id: http://svn.redmine.org/redmine/trunk@12985 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-03-21 00:23:46 +00:00
Jean-Philippe Lang
1ad33134d3 Enable the watching of news (#2549). 
git-svn-id: http://svn.redmine.org/redmine/trunk@12866 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-02-09 11:54:21 +00:00
Toshi MARUYAMA
35cc911192 update copyright year (#15977) 
Contributed by Daniel Felix.

git-svn-id: http://svn.redmine.org/redmine/trunk@12736 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-01-29 22:45:39 +00:00
Jean-Philippe Lang
a525bc8e98 Don't display default watchers checkboxes on the new issue form when there are more than 20 members (#8562). 
git-svn-id: http://svn.redmine.org/redmine/trunk@12673 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-01-19 10:01:14 +00:00
Toshi MARUYAMA
a7b8e6c02a Rails4: replace deprecated find_all_by_* at WatchersController 
git-svn-id: http://svn.redmine.org/redmine/trunk@12616 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2014-01-10 12:49:52 +00:00
Jean-Philippe Lang
856ef810b4 Bulk watch/unwatch issues from the context menu (#7159). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11339 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2013-02-10 10:31:12 +00:00
Jean-Philippe Lang
a0158eff96 Add/remove issue watchers via the REST API (#6727). 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11290 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2013-01-30 20:51:21 +00:00
Jean-Philippe Lang
e53a5de918 Adds "sorted" scope to Principal and User and sort users/groups properly. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11259 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2013-01-23 17:44:28 +00:00
Jean-Philippe Lang
e396a0eebe Copyright for 2013 (#12788). 
Patch by Daniel Felix.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11169 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2013-01-12 09:29:31 +00:00
Jean-Philippe Lang
5b21efd4a4 Replaces find(:all) calls. 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10914 e93f8b46-1217-0410-a6f0-8f06a7374b81
 2012-12-02 19:09:42 +00:00