1
0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-20 15:31:12 +00:00

1798 Commits

Author SHA1 Message Date
Toshi MARUYAMA
7f29c2fd88 IssuesControllerTest: make encoding tests independent of ordering (#18856)
Contributed by Antonio Terceiro.

git-svn-id: http://svn.redmine.org/redmine/trunk@13885 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-16 04:57:10 +00:00
Toshi MARUYAMA
e7346625f0 fix UsersControllerTest failure randomly
<pre>
  1) Error:
UsersControllerTest#test_show:
ActionView::Template::Error: undefined method `name' for nil:NilClass
    app/models/issue.rb:53:in `block in <class:Issue>'
    lib/plugins/acts_as_event/lib/acts_as_event.rb:62:in `call'
    lib/plugins/acts_as_event/lib/acts_as_event.rb:62:in `event_title'
    app/views/users/show.html.erb:57:in `block (2 levels) in _app_views_users_show_html_erb___2965700471773239267_46119700'
    app/views/users/show.html.erb:53:in `each'
    app/views/users/show.html.erb:53:in `block in _app_views_users_show_html_erb___2965700471773239267_46119700'
    app/views/users/show.html.erb:50:in `each'
    app/views/users/show.html.erb:50:in `_app_views_users_show_html_erb___2965700471773239267_46119700'
    app/controllers/users_controller.rb:75:in `block (2 levels) in show'
    app/controllers/users_controller.rb:71:in `show'
    test/functional/users_controller_test.rb:76:in `test_show'
</pre>

This can be reproduced with following change.

<pre>
   fixtures :users, :projects, :members, :member_roles, :roles,
            :custom_fields, :custom_values, :groups_users,
-           :auth_sources
+           :auth_sources,
+           :enabled_modules,
+           :issues, :issue_statuses
</pre>

git-svn-id: http://svn.redmine.org/redmine/trunk@13883 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-15 16:31:01 +00:00
Toshi MARUYAMA
a609c702c3 add missing fixture to SearchControllerTest
git-svn-id: http://svn.redmine.org/redmine/trunk@13881 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-15 13:38:44 +00:00
Jean-Philippe Lang
000124f44f Copyright update.
git-svn-id: http://svn.redmine.org/redmine/trunk@13872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-11 09:09:50 +00:00
Jean-Philippe Lang
a18c719fcc Fixed: Custom field is rendered, even if its value is empty (for multiple) (#18654).
git-svn-id: http://svn.redmine.org/redmine/trunk@13864 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-10 13:03:52 +00:00
Jean-Philippe Lang
0ed895388b Option to search open issues only (#10734).
git-svn-id: http://svn.redmine.org/redmine/trunk@13858 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-10 10:09:34 +00:00
Jean-Philippe Lang
576a13e99d Option to search attachment filenames and description (#4383).
git-svn-id: http://svn.redmine.org/redmine/trunk@13856 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-09 21:06:09 +00:00
Jean-Philippe Lang
fd4a911304 Fixed that project copy triggers a 500 error if project validation fails.
git-svn-id: http://svn.redmine.org/redmine/trunk@13848 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-07 22:29:50 +00:00
Jean-Philippe Lang
7ac9072270 Subclasses may not be loaded when running the test.
git-svn-id: http://svn.redmine.org/redmine/trunk@13782 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-21 12:50:43 +00:00
Jean-Philippe Lang
2a6692248b Replaced "can't" with "cannot" in error messages.
git-svn-id: http://svn.redmine.org/redmine/trunk@13781 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-21 12:39:48 +00:00
Jean-Philippe Lang
8ed791d690 Use DOM assertion instead.
git-svn-id: http://svn.redmine.org/redmine/trunk@13779 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-21 11:48:00 +00:00
Jean-Philippe Lang
f86d4940e1 Removed that quote in a fixture subject.
git-svn-id: http://svn.redmine.org/redmine/trunk@13775 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-20 14:22:50 +00:00
Toshi MARUYAMA
8ec62e9507 add missing fixtures to SearchControllerTest
git-svn-id: http://svn.redmine.org/redmine/trunk@13751 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-13 17:42:18 +00:00
Jean-Philippe Lang
07b44a4662 Droped legacy behaviour that allows a user to edit a few attributes of an issue without the edit_issues permission if a status transition is allowed (#15988).
Now that we can control permission on each field, this behaviour is no longer needed. The edit_issues permission is now required, which is consistent with the current requirements for bulk edition.

git-svn-id: http://svn.redmine.org/redmine/trunk@13746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-13 14:01:56 +00:00
Jean-Philippe Lang
95f58c69d2 Misc tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@13745 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-13 13:24:22 +00:00
Jean-Philippe Lang
3b4f6038ff Adds a test for editing a registered user.
git-svn-id: http://svn.redmine.org/redmine/trunk@13742 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-12 21:40:25 +00:00
Jean-Philippe Lang
2fe806a4a4 Rewrites search engine to properly paginate results (#18631).
Instead of counting and retrieving results based on their timestamps, we now load all result ids then load the appropriate results by their ids. This also brings a 2x performance improvement as we search tokens in one of the 2 queries only.

git-svn-id: http://svn.redmine.org/redmine/trunk@13739 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-12 20:49:31 +00:00
Jean-Philippe Lang
0b1b46ae2c Revert r13736, test fails with mysql.
git-svn-id: http://svn.redmine.org/redmine/trunk@13737 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-11 21:12:06 +00:00
Jean-Philippe Lang
7bc3cf94cb Adds a test for search with limited results.
git-svn-id: http://svn.redmine.org/redmine/trunk@13736 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-11 20:18:30 +00:00
Jean-Philippe Lang
95810125bf Don't create a journal when creating an issue with attachments.
git-svn-id: http://svn.redmine.org/redmine/trunk@13733 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-08 17:30:47 +00:00
Jean-Philippe Lang
2462a8581d Don't create a journal when creating an issue.
git-svn-id: http://svn.redmine.org/redmine/trunk@13732 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-08 17:18:28 +00:00
Jean-Philippe Lang
ca71cf3800 Adds methods for loading and adding settings.
git-svn-id: http://svn.redmine.org/redmine/trunk@13719 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-05 15:00:27 +00:00
Jean-Philippe Lang
c084ef509f Adds a few functional tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@13718 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-05 12:38:48 +00:00
Jean-Philippe Lang
7c1445f19a Tab "New Issue" should not be displayed if a project has no trackers (#18571).
git-svn-id: http://svn.redmine.org/redmine/trunk@13713 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-05 12:17:20 +00:00
Jean-Philippe Lang
8323bc98f5 Adds tests for searching private or archived projects.
git-svn-id: http://svn.redmine.org/redmine/trunk@13710 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-05 08:48:29 +00:00
Jean-Philippe Lang
c7653df32b Adds tests for invalid parameters.
git-svn-id: http://svn.redmine.org/redmine/trunk@13707 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-05 08:16:29 +00:00
Jean-Philippe Lang
50b12518a1 Adds a test for when link_copied_issue setting is set to "never".
git-svn-id: http://svn.redmine.org/redmine/trunk@13705 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-05 08:10:33 +00:00
Jean-Philippe Lang
a942c1c25e Removed unimplemented JournalsController#edit html response and added some tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@13704 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-05 08:08:00 +00:00
Jean-Philippe Lang
5222650d95 Adds a few tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@13695 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-03 20:21:03 +00:00
Jean-Philippe Lang
430c8fd904 Set notified events as expected.
git-svn-id: http://svn.redmine.org/redmine/trunk@13683 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-30 20:44:29 +00:00
Toshi MARUYAMA
5492062557 add missing fixtures to test/functional/projects_controller_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@13671 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-30 00:17:20 +00:00
Jean-Philippe Lang
30d65829b8 Configurable behavour for linking issues on copy (#18500).
git-svn-id: http://svn.redmine.org/redmine/trunk@13668 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-29 15:10:59 +00:00
Jean-Philippe Lang
288c014aa7 Edit attachments after upload (#1326).
git-svn-id: http://svn.redmine.org/redmine/trunk@13665 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-29 13:41:53 +00:00
Jean-Philippe Lang
86d8acb344 Fixed "First argument in form cannot contain nil or be empty" error (#18275).
git-svn-id: http://svn.redmine.org/redmine/trunk@13661 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-28 07:59:54 +00:00
Jean-Philippe Lang
552926772a Error raised on project settings after project wiki is deleted (#18429).
git-svn-id: http://svn.redmine.org/redmine/trunk@13660 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-28 07:43:22 +00:00
Jean-Philippe Lang
e0a034164f Move wiki page to other project (#5450).
git-svn-id: http://svn.redmine.org/redmine/trunk@13643 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-23 13:36:01 +00:00
Jean-Philippe Lang
f3e573b5f8 Replaced remaining #assert_tag with #assert_select.
git-svn-id: http://svn.redmine.org/redmine/trunk@13624 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-22 09:38:21 +00:00
Jean-Philippe Lang
36d487fe50 Replaced some #assert_tag with #assert_select.
git-svn-id: http://svn.redmine.org/redmine/trunk@13620 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-20 19:57:06 +00:00
Jean-Philippe Lang
2a43f1adbc Quote values in DOM selectors for Nokogiri compatibility.
git-svn-id: http://svn.redmine.org/redmine/trunk@13619 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-20 19:38:40 +00:00
Jean-Philippe Lang
043c2c92da Removed deep nested time entries routes.
git-svn-id: http://svn.redmine.org/redmine/trunk@13609 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-16 21:28:03 +00:00
Jean-Philippe Lang
1508cd7b8b Moved new group user to its own action GroupsController#new_users.
git-svn-id: http://svn.redmine.org/redmine/trunk@13602 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-16 08:53:39 +00:00
Jean-Philippe Lang
36fc7beb2f Moved new project member to its own action MemberController#new.
git-svn-id: http://svn.redmine.org/redmine/trunk@13600 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-15 11:20:47 +00:00
Jean-Philippe Lang
46756cbd56 Fixed 500 error when displaying a news with comments in reverse order (#18332).
git-svn-id: http://svn.redmine.org/redmine/trunk@13595 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-14 20:53:14 +00:00
Toshi MARUYAMA
f2ddfcda9a add missing fixtures to test/functional/wiki_controller_test.rb
Tests fail randomly.

<pre>
  1) Error:
WikiControllerTest#test_show_with_sidebar:
ActionView::Template::Error: undefined method `name' for nil:NilClass
    app/helpers/application_helper.rb:797:in `block in parse_redmine_links'
    app/helpers/application_helper.rb:757:in `gsub!'
    app/helpers/application_helper.rb:757:in `parse_redmine_links'
    app/helpers/application_helper.rb:601:in `block (2 levels) in textilizable'
    app/helpers/application_helper.rb:600:in `each'
    app/helpers/application_helper.rb:600:in `block in textilizable'
    app/helpers/application_helper.rb:621:in `parse_non_pre_blocks'
    app/helpers/application_helper.rb:599:in `textilizable'
    app/views/wiki/_content.html.erb:2:in `_app_views_wiki__content_html_erb___3773333740575742579_33736820'
    app/views/wiki/show.html.erb:44:in `_app_views_wiki_show_html_erb__965327089377623997_33504680'
    app/controllers/wiki_controller.rb:97:in `show'
    test/functional/wiki_controller_test.rb:119:in `test_show_with_sidebar'
</pre>

It can be reproduced by following change.

<pre>
 class WikiControllerTest < ActionController::TestCase
   fixtures :projects, :users, :roles, :members, :member_roles,
            :enabled_modules, :wikis, :wiki_pages, :wiki_contents,
-           :wiki_content_versions, :attachments
+           :wiki_content_versions, :attachments,
+           :issues #, :issue_statuses
</pre>

git-svn-id: http://svn.redmine.org/redmine/trunk@13590 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-12 03:44:47 +00:00
Jean-Philippe Lang
bdd3ccf8e5 Adds a role setting for controlling visibility of users: all or members of visible projects (#11724).
git-svn-id: http://svn.redmine.org/redmine/trunk@13584 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-11 13:08:52 +00:00
Jean-Philippe Lang
140ca9532c Adds a test for default issue columns order (#18310).
git-svn-id: http://svn.redmine.org/redmine/trunk@13583 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-11 12:33:06 +00:00
Jean-Philippe Lang
700736de5d Fixed duplicate test names (#18306).
git-svn-id: http://svn.redmine.org/redmine/trunk@13575 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-08 11:02:44 +00:00
Toshi MARUYAMA
2a5bc15344 remove duplicated IssuesControllerTest#test_new_should_select_default_status (#5991, #18305)
git-svn-id: http://svn.redmine.org/redmine/trunk@13570 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-08 04:46:44 +00:00
Jean-Philippe Lang
b2ba7db4e1 Time entries CSV export should include the tracker and subject of the issue (#18269).
git-svn-id: http://svn.redmine.org/redmine/trunk@13562 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-05 15:23:22 +00:00
Jean-Philippe Lang
4c9fcb34b6 Typo.
git-svn-id: http://svn.redmine.org/redmine/trunk@13561 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-05 15:17:21 +00:00