Go MAEDA
e5a8bcfd72
Ignore archived project memberships when calculating issue query visibility ( #28180 ).
...
Patch by Holger Just.
git-svn-id: http://svn.redmine.org/redmine/trunk@17257 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-07 00:26:54 +00:00
Go MAEDA
ed48b0708a
Add a test to ensure that issue calculations on version details page take into account only visible issues ( #27676 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17251 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-01 02:16:03 +00:00
Go MAEDA
02e1a17dd0
Adds issue category column to spent time queries ( #28391 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17250 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-01 00:31:07 +00:00
Go MAEDA
fa76ec5c01
Adds issue category filter to spent time queries ( #28391 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17249 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-01 00:29:22 +00:00
Go MAEDA
8ee4d5084d
Deletion of an LDAP authentication mode may fail silently ( #28000 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@17232 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-12 04:31:04 +00:00
Go MAEDA
0f9ea965e7
Fix: Calculation of the start date of following issues ignores the "non-working days" setting ( #14846 ).
...
Patch by Felix Schäfer.
git-svn-id: http://svn.redmine.org/redmine/trunk@17230 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-08 07:44:54 +00:00
Go MAEDA
76f12c1316
Optional regex for filtering attachments on incoming emails ( #27025 ).
...
Patch by Jan Schulz-Hofen.
git-svn-id: http://svn.redmine.org/redmine/trunk@17225 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-03 04:29:54 +00:00
Go MAEDA
e9fb90856f
Move textile footnotes test to TextileFormatterTest ( #28207 ).
...
Patch by Mischa The Evil.
git-svn-id: http://svn.redmine.org/redmine/trunk@17222 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-02 04:58:52 +00:00
Go MAEDA
8d033d08d0
Add footnotes test for markdown formatter ( #28207 ).
...
Patch by Mischa The Evil.
git-svn-id: http://svn.redmine.org/redmine/trunk@17221 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-02 04:55:52 +00:00
Go MAEDA
e1023a26ac
Fix typo in test name: s/udpate/update/ ( #28268 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17218 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-01 05:10:44 +00:00
Go MAEDA
a175f9ded9
Allow selecting subprojects on new issue form ( #12704 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17217 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-02-28 06:42:52 +00:00
Go MAEDA
5ed4031b64
Add minimal fixture for issues_pdf_test ( #12510 ).
...
Patch by Gregor Schmidt.
git-svn-id: http://svn.redmine.org/redmine/trunk@17212 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-02-24 09:26:26 +00:00
Go MAEDA
8117d481ac
Test that "img" tag for an avatar of AnonymousUser has "width" and "height" attributes ( #28204 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@17201 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-02-18 05:05:50 +00:00
Go MAEDA
a500e8fafc
Don't allow reassigning reported hours to the project if issue is a required field for time logs ( #28110 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17199 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-02-18 04:24:05 +00:00
Go MAEDA
241e4cbb68
Enable lax_spacing for markdown formatting ( #28119 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-02-16 05:01:14 +00:00
Toshi MARUYAMA
c2604e065d
remove trailing white spaces from test/functional/repositories_mercurial_controller_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17187 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-31 17:48:01 +00:00
Go MAEDA
0f4fb452e7
Add right-click context menu in calendar ( #28067 ).
...
Patch by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@17186 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-30 08:03:00 +00:00
Go MAEDA
7844b65f3c
Add CSS classes to column headers of issues and timelogs list ( #26674 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17176 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-15 04:17:53 +00:00
Go MAEDA
f496402634
Add tests for "height" and "max-height" ( #26552 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17175 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-13 00:32:53 +00:00
Go MAEDA
e4142a8338
Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textile ( #26552 ).
...
Patch by Michael Gerz and Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@17173 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-11 01:32:18 +00:00
Jean-Philippe Lang
6d4c0a77fe
The progress exceeding 99.5% is displayed as 100% ( #27848 ).
...
Patch by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@17169 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-08 22:35:59 +00:00
Jean-Philippe Lang
4c0638c5f9
Unable to download file if custom field is not defined as visible to any users ( #26705 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17158 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-08 17:43:31 +00:00
Jean-Philippe Lang
10f96ab2ab
Adds tests for #27153 .
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17156 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-07 22:28:37 +00:00
Jean-Philippe Lang
27cd7f478b
Cannot clear all watchers when copying an issue ( #26880 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17153 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-07 22:18:17 +00:00
Jean-Philippe Lang
c7948ed40d
Anonymous user should have their icon ( #26699 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@17150 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-07 22:01:56 +00:00
Jean-Philippe Lang
4e6b54e33e
Empty email attachments are imported to Redmine, creating broken DB records ( #27885 ).
...
Patch by Felix Schäfer.
git-svn-id: http://svn.redmine.org/redmine/trunk@17147 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-07 21:46:58 +00:00
Jean-Philippe Lang
2cb30321a2
No validation errors when entering an invalid "Estimate hours" value ( #27881 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@17144 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-07 21:41:15 +00:00
Go MAEDA
c35433ad01
Links for custom field value don't have "external" class ( #27024 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@17138 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-01 06:18:01 +00:00
Toshi MARUYAMA
d2298e419c
source code comment slight change ( #27865 )
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17136 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-29 15:09:57 +00:00
Toshi MARUYAMA
7a556764ef
use relative url at robots.txt ( #27865 )
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17135 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-29 14:56:51 +00:00
Toshi MARUYAMA
fca43b026e
remove trailing white spaces from test/functional/timelog_report_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17134 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-28 18:40:25 +00:00
Go MAEDA
f33ddf9749
Issues reports should show only statuses used by the project ( #27772 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17121 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-19 10:15:22 +00:00
Go MAEDA
a4931262d0
Strip whitespace from login on login page ( #22532 ).
...
Patch by Artur Borisovich and Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17113 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-13 13:58:32 +00:00
Go MAEDA
01085249ab
Fix: Strip whitespace from email addresses on lost password page ( #27754 ).
...
Patch by Felix Schäfer.
git-svn-id: http://svn.redmine.org/redmine/trunk@17078 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-08 08:27:27 +00:00
Toshi MARUYAMA
4e7ae640b9
add copyright header to test/unit/lib/redmine/helpers/url_test.rb ( #12510 )
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17077 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 14:28:41 +00:00
Toshi MARUYAMA
93d8204b8a
code clean up IssuesPdfHelperTest ( #12510 )
...
* remove extra empty lines
* remove trailing white space
* replace tab to two spaces
git-svn-id: http://svn.redmine.org/redmine/trunk@17065 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 12:03:08 +00:00
Toshi MARUYAMA
9d797400ea
mercurial: work around faulty parsing of early command options ( #27516 )
...
Use -sVALUE and --long=VALUE instead of "-s VALUE" and "--long VALUE"
respectively.
Contributed by Yuya Nishihara.
git-svn-id: http://svn.redmine.org/redmine/trunk@17062 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 11:38:47 +00:00
Toshi MARUYAMA
ca87bf766c
mercurial: reject malicious command argument ( #27516 )
...
We've got a security report from the Phabricator team, which basically says
--config and --debugger arguments can be injected anywhere to lead to an
arbitrary command execution.
https://secure.phabricator.com/rPa7921a4448093d00defa8bd18f35b8c8f8bf3314
This is a fundamental issue of the argument parsing rules in Mercurial, which
allows extensions to populate their parsing rules and such extensions can be
loaded by "--config extensions.<name>=". There's a chicken and egg problem.
We're working on hardening the parsing rules, but which won't come in by
default as it would be a behavior change.
This patch adds a verification to reject malicious command arguments as a
last ditch. The subsequent patches will fix the problem in more appropriate
way.
Contributed by Yuya Nishihara.
git-svn-id: http://svn.redmine.org/redmine/trunk@17060 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 11:38:23 +00:00
Go MAEDA
d6d2d23365
Fix: Round floats to 2 digits when rendering an issue list to PDF ( #12510 ).
...
Patch by Holger Just and Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17059 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-06 14:25:35 +00:00
Go MAEDA
ae842a73db
Disallow creating inverse relates issue relations ( #27663 ).
...
Patch by Gregor Schmidt.
git-svn-id: http://svn.redmine.org/redmine/trunk@17056 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-06 09:01:07 +00:00
Go MAEDA
0ed07156ad
Reverted r17054 ( #27663 ).
...
The change breaks test/functional/issue_relations_controller_test.rb.
git-svn-id: http://svn.redmine.org/redmine/trunk@17055 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-30 00:02:02 +00:00
Go MAEDA
3a310ccc2e
Disallow creating inverse relates issue relations ( #27663 ).
...
Patch by Gregor Schmidt.
git-svn-id: http://svn.redmine.org/redmine/trunk@17054 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-29 22:22:39 +00:00
Jean-Philippe Lang
62d6dfe1cc
Fixes visibility checks for version.fixed_issues in Gantt ( #27676 ).
...
Like the version page - the Gantt chart featured a "percent done" info
for each version, which wasn't properly limited to visible issues.
Patch by Gregor Schmidt.
git-svn-id: http://svn.redmine.org/redmine/trunk@17053 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-29 19:38:44 +00:00
Go MAEDA
4a6f9e01d6
Add tests for context menu in gantt ( #10485 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17037 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-27 00:34:30 +00:00
Go MAEDA
9ae7bc8152
Make robust Redmine::Helpers::URL#uri_with_safe_scheme? ( #27114 )
...
Patch by okkez.
git-svn-id: http://svn.redmine.org/redmine/trunk@17035 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-26 03:44:37 +00:00
Toshi MARUYAMA
e438523e78
remove unused WikisController#edit ( #26579 )
...
git-svn-id: http://svn.redmine.org/redmine/trunk@17018 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-05 19:09:05 +00:00
Jean-Philippe Lang
5a775287ab
Fix filter after multiple version ids ( #26667 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@17000 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-10-15 11:54:39 +00:00
Jean-Philippe Lang
cb73fc58f2
Fix filter values for fixed version id ( #26667 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@16999 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-10-15 11:53:49 +00:00
Jean-Philippe Lang
0a3e85b92d
Filtering time entries after issue's target version doesn't work as expected in some cases ( #26667 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@16997 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-10-15 11:42:00 +00:00
Toshi MARUYAMA
caca511d25
remove trailing white spaces from test/functional/queries_controller_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@16967 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-09-15 04:49:32 +00:00