1
0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-20 15:31:12 +00:00

7087 Commits

Author SHA1 Message Date
Toshi MARUYAMA
6b5991b34e use "attr_writer" instead of "attr_accessor" for WikiPage#deleted_attachment_ids
WikiPage#deleted_attachment_ids is already defined in this class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18617 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 11:45:22 +00:00
Toshi MARUYAMA
1c0b6075ee use "attr_writer" instead of "attr_accessor" for QueryColumn#sortable
QueryColumn#sortable is already defined in this class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18616 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 11:45:11 +00:00
Toshi MARUYAMA
21cc761b53 use "attr_reader" instead of "attr_accessor" for CustomFieldValue#value
CustomFieldValue#value= is already defined in this class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18615 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 11:44:54 +00:00
Toshi MARUYAMA
557f045e42 code cleanup: fix source code comment in r18607
git-svn-id: http://svn.redmine.org/redmine/trunk@18613 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:34:22 +00:00
Toshi MARUYAMA
af67ade563 code cleanup: rubocop: fix Lint/UselessAccessModifier in app/models/changeset.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18607 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 07:20:26 +00:00
Go MAEDA
2158e3f2c6 Fix that "Associated revisions" tab has no content when the user displays comments in reverse chronological order (#32198, #3058).
Patch by José Esteves.


git-svn-id: http://svn.redmine.org/redmine/trunk@18598 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-05 23:57:33 +00:00
Go MAEDA
16c580a2f8 Option to send email notification on "Target version updated" (#17840).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18595 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-05 09:46:05 +00:00
Go MAEDA
7763902629 Use Redmine::MimeType.of instead of regexp to check if the attachment is Textile (#29752).
git-svn-id: http://svn.redmine.org/redmine/trunk@18586 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-03 09:30:43 +00:00
Go MAEDA
cffc5d6a12 Add styles for Textile/Markdown attachments preview (#29752).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18585 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-03 00:32:33 +00:00
Go MAEDA
3ce678510e Render Textile and Markdown attachments on the preview page (#29752).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@18584 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-03 00:09:28 +00:00
Toshi MARUYAMA
c343588fa7 fix Watcher#prune_single_user is not private
git-svn-id: http://svn.redmine.org/redmine/trunk@18577 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-01 05:07:16 +00:00
Go MAEDA
b0f1175e3e Add support for "start with" and "end with" operators to "Files" filter (#31879).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18570 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 13:15:45 +00:00
Toshi MARUYAMA
0779cd6e53 code cleanup: rubocop: fix Layout/ElseAlignment in Issue class total_spent_hours method
git-svn-id: http://svn.redmine.org/redmine/trunk@18567 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 11:42:48 +00:00
Toshi MARUYAMA
91d7916f38 code cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible? method
git-svn-id: http://svn.redmine.org/redmine/trunk@18566 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 11:42:36 +00:00
Toshi MARUYAMA
edc94dabb3 code cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible_condition method
git-svn-id: http://svn.redmine.org/redmine/trunk@18565 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 11:42:26 +00:00
Toshi MARUYAMA
2795d1edc3 code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in app/helpers/application_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18564 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 11:42:15 +00:00
Toshi MARUYAMA
ca411ddca7 code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18559 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 09:00:06 +00:00
Toshi MARUYAMA
a8c1fc77ef code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/models/attachment.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18558 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 08:59:54 +00:00
Toshi MARUYAMA
fb04274fc0 code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/helpers/application_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18557 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 08:59:43 +00:00
Toshi MARUYAMA
ad110b965f code cleanup: rubocop: fix Layout/MultilineBlockLayout in app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18556 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 08:59:26 +00:00
Toshi MARUYAMA
3d6ab06b6c remove extra space from app/views/issues/_edit.html.erb
git-svn-id: http://svn.redmine.org/redmine/trunk@18551 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 02:23:03 +00:00
Go MAEDA
661d4b42b1 Unify fields of subtasks and related issues on issue page (#25540).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@18549 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-29 00:03:34 +00:00
Go MAEDA
bd46401821 Move the links (All time entries, Import) from Spent time section of the spent time list sidebar under a dropdown (#31598).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18546 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-27 09:38:33 +00:00
Toshi MARUYAMA
612221d36a svn propdel svn:executable app/models/mail_handler.rb
It was added by r16609 accidentally.



git-svn-id: http://svn.redmine.org/redmine/trunk@18539 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-26 02:38:50 +00:00
Go MAEDA
b3baa5c1ce "starts with" and "ends with" filter operators for string values (#31879).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18534 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-25 16:24:08 +00:00
Toshi MARUYAMA
591d0eae79 code cleanup: rubocop: fix Style/ZeroLengthPredicate in app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18523 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 15:56:51 +00:00
Toshi MARUYAMA
2829ddcc33 code cleanup: rubocop: fix Layout/BlockEndNewline in app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18517 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 05:54:53 +00:00
Toshi MARUYAMA
d0ca6ad31d code cleanup: rubocop: fix Layout/SpaceInsideStringInterpolation in app/helpers/issues_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18516 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 05:54:42 +00:00
Toshi MARUYAMA
a405e8f950 code cleanup: rubocop: fix Style/WhileUntilModifier in app/helpers/issues_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18514 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 05:21:09 +00:00
Toshi MARUYAMA
7272399dc9 code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/helpers/issues_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18513 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 05:20:58 +00:00
Toshi MARUYAMA
4c9bef2ace code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/repository/bazaar.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18512 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 05:13:46 +00:00
Go MAEDA
ca16a23ad5 Don't show unsettable permissions in the tracker permissions table (#30431).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18508 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 04:18:44 +00:00
Toshi MARUYAMA
fb221e8069 code cleanup: rubocop: fix Layout/SpaceInsideRangeLiteral in app/models/repository/cvs.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18507 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 02:34:43 +00:00
Toshi MARUYAMA
8fb0ec3c3b code cleanup: rubocop: fix Style/RedundantConditional in app/helpers/issues_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18502 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-21 14:14:28 +00:00
Go MAEDA
f5bbb0317a Auto-complete issues #id in the search form (#32052).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18498 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-21 07:52:16 +00:00
Toshi MARUYAMA
7df0230d67 code cleanup: rubocop: fix Rails/Blank in app/helpers/issues_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18497 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-21 06:39:36 +00:00
Toshi MARUYAMA
a6116a98c5 code cleanup: rubocop: fix Style/MultilineTernaryOperator in app/helpers/issues_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18496 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-21 06:39:24 +00:00
Toshi MARUYAMA
fd51a4fe58 code cleanup: rubocop: fix Style/CommentedKeyword in app/models/repository/cvs.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18492 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 17:54:54 +00:00
Toshi MARUYAMA
d6701ab40f remove "attr_reader :current_journal" from Issue class
Issue#current_journal is already defined in Issue class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18488 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 15:03:48 +00:00
Toshi MARUYAMA
3be589df24 use "attr_writer" instead of "attr_accessor" for Issue#deleted_attachment_ids
Issue#deleted_attachment_ids is already defined in Issue class.

git-svn-id: http://svn.redmine.org/redmine/trunk@18487 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 15:03:37 +00:00
Toshi MARUYAMA
4074ca0771 code clean up app/models/repository.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18486 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 13:58:41 +00:00
Toshi MARUYAMA
7fb47e4b5e code cleanup: rubocop: fix Layout/LeadingCommentSpace in app/models/repository.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18485 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 13:58:30 +00:00
Toshi MARUYAMA
0c416338dd code cleanup: rubocop: fix Style/StringLiteralsInInterpolation in app/helpers/issues_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18481 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-19 12:59:24 +00:00
Go MAEDA
75df6ead3b Log info messages when MailHandler ignored a reply to a nonexistent issue, journal, or message (#31946).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18480 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-19 09:38:39 +00:00
Toshi MARUYAMA
aa8c59a389 code cleanup: rubocop: fix Layout/IndentAssignment in app/helpers/issues_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18479 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-19 06:11:15 +00:00
Go MAEDA
5755bed4e1 Change textfield to textarea for "Exclude attachments by name" (#19903).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18476 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-18 01:25:47 +00:00
Go MAEDA
61554d9004 Add wiki toolbar to "Email header" and "Email footer" in "Email notifications" admin tab (#8343).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18475 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-17 05:58:36 +00:00
Toshi MARUYAMA
217b091143 code cleanup: rubocop: fix Layout/LeadingCommentSpace in app/controllers/repositories_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18473 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-15 15:08:49 +00:00
Toshi MARUYAMA
881c99f162 code cleanup: rubocop: fix Layout/IndentAssignment in app/helpers/repositories_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18472 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-15 15:08:38 +00:00
Go MAEDA
0d4fbfe340 Add clear query icon next to selected query in sidebar (#31640).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18468 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-14 00:33:05 +00:00