Toshi MARUYAMA
e2cb4be892
code cleanup: rubocop: fix Layout/EmptyLines in test/unit/query_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18741 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 07:27:35 +00:00
Toshi MARUYAMA
89e9b05b3d
code cleanup: rubocop: fix Layout/CommentIndentation and Layout/MultilineArrayBraceLayout of STR_WITH_PRE in test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18699 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-17 04:15:37 +00:00
Toshi MARUYAMA
1f14386822
code cleanup: rubocop: fix Layout/CommentIndentation and Layout/MultilineArrayBraceLayout of STR_WITHOUT_PRE in test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18698 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-17 04:15:26 +00:00
Toshi MARUYAMA
2117705cbc
code cleanup: rubocop: fix Layout/BlockAlignment in test/unit/lib/redmine/menu_manager/menu_helper_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18683 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-15 12:11:00 +00:00
Toshi MARUYAMA
94a7c3aa65
code cleanup: rubocop: fix Layout/BlockAlignment in test/unit/lib/redmine/menu_manager/mapper_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18677 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-15 05:07:51 +00:00
Toshi MARUYAMA
9e05932c45
code layout clean up test/unit/project_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18676 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-15 05:07:40 +00:00
Toshi MARUYAMA
b65348fa2c
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs and Layout/EmptyLines in app/models/version.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18674 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-15 05:07:17 +00:00
Toshi MARUYAMA
6a3d42dd69
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/unit/mailer_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18673 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-15 05:07:06 +00:00
Toshi MARUYAMA
a4133891e4
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/user_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18654 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-14 11:14:24 +00:00
Toshi MARUYAMA
7b7a1a3ed5
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/query_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18653 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-14 11:14:12 +00:00
Toshi MARUYAMA
0cf19f967a
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/project_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18648 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-14 11:13:14 +00:00
Toshi MARUYAMA
f3f1fad8de
code cleanup: rubocop: fix Layout/SpaceAroundBlockParameters in test/unit/query_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18645 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-13 16:22:42 +00:00
Toshi MARUYAMA
91c56e2cbd
code cleanup: rubocop: fix Style/AsciiComments in test/unit/mail_handler_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18630 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-09 02:05:25 +00:00
Toshi MARUYAMA
74f5842adb
code layout clean up test/unit/issue_status_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18628 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-08 14:10:02 +00:00
Toshi MARUYAMA
6972d7e982
code cleanup: rubocop: fix Layout/ClosingHeredocIndentation and Layout/IndentHeredoc in test/unit/setting_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18614 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-07 11:44:42 +00:00
Go MAEDA
16c580a2f8
Option to send email notification on "Target version updated" ( #17840 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18595 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-05 09:46:05 +00:00
Go MAEDA
5ce4a363a9
Fix test failure due to missing call to set_tmp_attachments_directory ( #32122 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18593 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-04 11:17:33 +00:00
Go MAEDA
545a050ba3
Code cleanup: RuboCop: Fix Performance/Count and Performance/Detect.
...
This change corrects newly detected offenses after updating rubocop-performance to 1.5.0 in r18579.
git-svn-id: http://svn.redmine.org/redmine/trunk@18580 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-02 00:53:11 +00:00
Go MAEDA
b0f1175e3e
Add support for "start with" and "end with" operators to "Files" filter ( #31879 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18570 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 13:15:45 +00:00
Toshi MARUYAMA
d4f491847d
code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/unit/changeset_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18555 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 08:59:14 +00:00
Toshi MARUYAMA
cc8750f7dd
code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/issue_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18554 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-30 02:44:32 +00:00
Toshi MARUYAMA
2e1da01790
code cleanup: rubocop: fix Layout/EmptyLinesAroundMethodBody in test/unit/issue_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18537 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-25 17:55:14 +00:00
Go MAEDA
b3baa5c1ce
"starts with" and "ends with" filter operators for string values ( #31879 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18534 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-25 16:24:08 +00:00
Toshi MARUYAMA
83d5633a5f
code cleanup: rubocop: fix Style/TrailingCommaInArguments in test/unit/issue_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18529 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-25 11:18:59 +00:00
Toshi MARUYAMA
9a5cb65b9e
code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/unit/issue_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18522 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 15:43:56 +00:00
Toshi MARUYAMA
004b1e35f5
add missing fixtures to MailHandlerTest ( #31946 )
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18509 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 04:48:14 +00:00
Toshi MARUYAMA
fc243aa3ea
code cleanup: rubocop: fix Layout/MultilineArrayBraceLayout in test/unit/repository_bazaar_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18495 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-21 06:32:29 +00:00
Go MAEDA
75df6ead3b
Log info messages when MailHandler ignored a reply to a nonexistent issue, journal, or message ( #31946 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18480 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-19 09:38:39 +00:00
Toshi MARUYAMA
5611ee0e02
backout r13743
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18478 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-19 05:49:21 +00:00
Toshi MARUYAMA
c7c2bb2b24
code cleanup: rubocop: fix Lint/UselessSetterCall in test/unit/issue_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18477 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-18 01:56:43 +00:00
Go MAEDA
5755bed4e1
Change textfield to textarea for "Exclude attachments by name" ( #19903 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18476 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-18 01:25:47 +00:00
Go MAEDA
59968110a3
Add additional mail headers for issue tracker ( #31910 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18459 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-12 21:52:21 +00:00
Toshi MARUYAMA
dc657cb2c0
code cleanup: rubocop: fix Layout/SpaceInsideReferenceBrackets in test/unit/lib/redmine/scm/adapters/git_adapter_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18448 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-11 05:51:02 +00:00
Go MAEDA
f461488c41
Fix that test_mail_from_format_should_be_validated randomly fails ( #31154 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18434 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-05 07:22:32 +00:00
Toshi MARUYAMA
75519b7158
code cleanup: rubocop: fix Layout/SpaceBeforeFirstArg in test/unit/lib/redmine/scm/adapters/git_adapter_test.rb
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18425 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-04 05:35:37 +00:00
Go MAEDA
ef856653ac
Code cleanup: RuboCop: Fix Performance/InefficientHashSearch
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18423 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-03 07:42:05 +00:00
Go MAEDA
35e6a532f5
Force passwords to contain specified character classes ( #4221 ).
...
Patch by Takenori TAKAKI.
git-svn-id: http://svn.redmine.org/redmine/trunk@18411 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-29 01:35:09 +00:00
Go MAEDA
62443361af
IssueCustomFieldTest randomly fails ( #31967 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18409 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-28 08:21:08 +00:00
Go MAEDA
ae8ee086b4
Add missing fixtures to Redmine::Helpers::GanttHelperTest ( #31966 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18408 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-28 06:22:43 +00:00
Go MAEDA
c37d1b43a4
Reject version custom field values not visible for the user ( #31954 , #23997 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@18402 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-27 10:44:39 +00:00
Go MAEDA
ce831ae5e4
Reject project custom field values not visible for the user ( #31954 , #31925 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@18401 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-27 10:20:09 +00:00
Go MAEDA
47dd2083f7
Reject setting RFC non-compliant emission email addresses ( #31154 ).
...
Patch by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18396 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-26 04:18:18 +00:00
Go MAEDA
959b55779f
Fix hard-coded string "no subject" in app/models/mail_handler.rb ( #5820 ).
...
Patch by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18388 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-25 00:09:10 +00:00
Go MAEDA
878f4c3455
Add tests for r18383 ( #31231 ).
...
Patch by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18384 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-24 07:03:01 +00:00
Go MAEDA
70284ee244
MarkdownFormatterTest#test_should_support_underlined_text is declared as private ( #31929 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@18381 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-21 00:31:54 +00:00
Go MAEDA
0d4ed12388
Code cleanup: RuboCop: Rails/ActiveRecordAliases
...
update_attributes is deprecated in Rails 6.0 and will be removed in Rails 6.1 (#29914 ).
git-svn-id: http://svn.redmine.org/redmine/trunk@18375 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-17 08:14:36 +00:00
Go MAEDA
489a563ece
Update Rouge to 3.8.0 ( #31556 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18369 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-14 05:23:46 +00:00
Go MAEDA
31e8e736f3
Code cleanup: RuboCop: Layout/TrailingBlankLines
...
git-svn-id: http://svn.redmine.org/redmine/trunk@18367 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-14 03:02:20 +00:00
Go MAEDA
f5c7a4a420
Convert HTML links to Textile/Markdown links when creating an issue from an email ( #31695 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@18361 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-11 05:01:37 +00:00
Go MAEDA
8a9123de04
Limit total_estimated_hours to visible issues ( #31778 ).
...
Patch by Gregor Schmidt.
git-svn-id: http://svn.redmine.org/redmine/trunk@18356 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-07 04:44:19 +00:00