1
0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-21 16:01:14 +00:00

502 Commits

Author SHA1 Message Date
Go MAEDA
4506524ea5 Revert r22764 (#33829).
It breaks activities_controller_test.rb.


git-svn-id: https://svn.redmine.org/redmine/trunk@22770 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-03-06 14:09:21 +00:00
Go MAEDA
c94d7c5a57 Fix Atom feed for issues to correctly use the updated time for "updated" element instead of the created time (#33829).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22764 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-03-04 14:25:49 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043).
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Marius Balteanu
13aeb797cf Use ApplicationRecord instead of ActiveRecord::Base (#38975).
Patch by Minoru Maeda (@maeda-m).

git-svn-id: https://svn.redmine.org/redmine/trunk@22619 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-23 11:52:38 +00:00
Go MAEDA
c13d597209 Optimize Issue#relations method to improve performance by fetching both relations_from and relations_to using a single database query (#39840).
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22572 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-28 00:10:34 +00:00
Go MAEDA
380444f085 Fix RuboCop offense Performance/StringIdentifierArgument (#39888).
git-svn-id: https://svn.redmine.org/redmine/trunk@22535 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-20 09:23:05 +00:00
Go MAEDA
c51e4937e7 Fix RuboCop offense Style/SuperWithArgsParentheses (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22530 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-20 07:15:11 +00:00
Marius Balteanu
a54155d206 Moves create parent issue journal to after_commit hook to work around stale object errors on concurrency (#39437).
Patch by Jens Krämer.

git-svn-id: https://svn.redmine.org/redmine/trunk@22459 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-11-18 14:40:25 +00:00
Go MAEDA
86c5d7814f Retry in case of stale issue during Issue.update_versions (#38820).
Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@22279 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-08-23 07:40:25 +00:00
Go MAEDA
945a82b5c0 <=> operator should return nil when invoked with an incomparable object (#38772).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22269 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-06-29 14:42:54 +00:00
Go MAEDA
55408c480b Ability to disable the priority field (#38416).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22185 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-04-14 01:05:02 +00:00
Go MAEDA
555acea780 Check if the user has the permission to add notes or edit an issue when adding an issue attachments (#38297).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@22122 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-03-02 04:32:34 +00:00
Go MAEDA
a499d68802 Show parent issues in notification email (#34302).
Patch by Yuichi HARADA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22120 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-03-01 03:46:53 +00:00
Go MAEDA
41b4bc54a5 Disable auto watch for the anonymous user (#38238).
Patch by Felix Schäfer.


git-svn-id: https://svn.redmine.org/redmine/trunk@22116 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-02-26 07:48:19 +00:00
Go MAEDA
9a625f2610 Auto watch issues on issue creation (#38238).
Patch by Felix Schäfer.


git-svn-id: https://svn.redmine.org/redmine/trunk@22115 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-02-26 07:46:35 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Go MAEDA
0f2378c121 Reverts r21958 and r21959 (#1739).
git-svn-id: https://svn.redmine.org/redmine/trunk@21960 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-11-18 08:17:50 +00:00
Go MAEDA
b3e4214989 Add the ability to change the author of an issue (#1739).
Patch by Vladimir Kovacik, Jiri Stepanek, Aighan Pacobilch, Olivier Houdas, Takenori TAKAKI, and Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21958 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-11-16 09:24:17 +00:00
Go MAEDA
d4b7634cc6 Consider only roles with either add_issues or edit_issues permissions for any status transitions (#37635).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21817 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-17 06:14:27 +00:00
Marius Balteanu
68031b6544 Improved @fixed_version_id@ validation (#37171).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21638 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-06-16 15:13:09 +00:00
Marius Balteanu
e5550d5ed4 Ensure @category_id@ is valid within the issue's project (#37171).
Patch by Holger Just. 


git-svn-id: https://svn.redmine.org/redmine/trunk@21637 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-06-16 15:10:25 +00:00
Go MAEDA
aef5983bdd The done ratio of a parent issue may not be 100% even if all subtasks have a done ratio of 100% (#37151).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21626 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-06-08 15:40:45 +00:00
Marius Balteanu
fcf792615a Issue#last_notes fallback does not respect notes visibility (#37155).
Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21613 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-05-28 09:52:48 +00:00
Marius Balteanu
ba74ba1c70 Allow users to be mentioned using @ in issues and wiki pages (#13919):
* the user must have add watchers permission on that object in order to mention other users
* mentioned user will receive a notification email
* only visible users who can view the object can be mentioned



git-svn-id: http://svn.redmine.org/redmine/trunk@21435 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-02-23 21:16:18 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Go MAEDA
b6a26a60f3 Fixes for Performance/StringIdentifierArgument introduced in RuboCop Performance 1.13.0 (#35142).
git-svn-id: http://svn.redmine.org/redmine/trunk@21330 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-12-29 06:12:27 +00:00
Go MAEDA
91c00f51ec Fixes for Performance/BigDecimalWithNumericArgument introduced in RuboCop Performance 1.13.0 (#35142).
git-svn-id: http://svn.redmine.org/redmine/trunk@21326 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-12-25 08:59:22 +00:00
Go MAEDA
b4dbd821c9 Issue Summary: add statistics about issues without assignee, version or category (#13099).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@21309 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-12-12 04:40:32 +00:00
Go MAEDA
578e367c8c Allow addition/removal of subtasks to show in parent's history (#6033).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21273 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-11-08 14:22:06 +00:00
Marius Balteanu
506fc9d74c Tokenize search parameter in order to allow multiple search terms in:
* the "contains" operator of text filters
* in issue autocomplete

Patch by Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@21238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-05 19:54:31 +00:00
Marius Balteanu
05e9d7883b Use sanitize_sql_like in like scopes (#35073).
Patch Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@21231 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-03 19:44:39 +00:00
Marius Balteanu
f31a1e2bbb Fixed attachments deletable by user without edit issue permission on tracker (#35634).
git-svn-id: http://svn.redmine.org/redmine/trunk@21142 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-08-05 23:50:11 +00:00
Go MAEDA
83e22515b9 Ruby 3.0: Fix super calls (#34992, #34986).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20912 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-03 09:01:53 +00:00
Go MAEDA
f134831602 Do not journalize attachments that are added during a "Copy Issue" operation (#34921).
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@20872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-29 03:32:38 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Go MAEDA
5d251f28d0 Unable to autoload constant Version.table_name if gems use Version class (#33206).
Patch by Alexander Meindl.


git-svn-id: http://svn.redmine.org/redmine/trunk@20760 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-03 14:39:23 +00:00
Go MAEDA
354d30df31 Add class 'error' to custom fields with validation errors (#32764, #34580).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20710 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-01-11 12:26:44 +00:00
Go MAEDA
3f3514d8b1 Show only valid projects on issue form when the issue is a subtask (#33419).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20701 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-01-01 00:59:07 +00:00
Toshi MARUYAMA
ca099daae2 shorten long line of app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20663 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-17 13:11:05 +00:00
Go MAEDA
f43b3685ff Use sum { ... } instead of map { ... }.sum (#34399).
git-svn-id: http://svn.redmine.org/redmine/trunk@20581 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-06 01:36:39 +00:00
Toshi MARUYAMA
43b848a2ed remove spaces inside {} of app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20411 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-17 12:41:33 +00:00
Toshi MARUYAMA
4ce729d5af use "do end" instead of {} at ActiveRecord scope lambda of app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-12 12:31:20 +00:00
Toshi MARUYAMA
63cd0b3e61 use "do end" instead of {} at app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20284 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-07 12:30:38 +00:00
Go MAEDA
e48ff48820 Evaluate acts_as_activity_provider's scope lazily (#33664).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20148 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-17 02:02:50 +00:00
Toshi MARUYAMA
d208cb6421 fix source indent of app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20083 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-26 15:02:02 +00:00
Go MAEDA
a7b9fa9996 Fix that Issues API bypasses add_issue_notes permission (#33689).
Patch by Junya Tomono and Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19975 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-12 02:28:46 +00:00
Toshi MARUYAMA
258ba9b88b remove spaces inside {} of app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19889 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 16:21:53 +00:00
Toshi MARUYAMA
f3f333a906 add space after comma to app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19888 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 16:21:45 +00:00
Toshi MARUYAMA
2f478664f7 add empty line after guard clause to app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19887 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 16:21:37 +00:00
Toshi MARUYAMA
26bf703530 fix source indent of Issue#visible_condition
git-svn-id: http://svn.redmine.org/redmine/trunk@19886 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 16:21:29 +00:00