Marius Balteanu
243c110265
Move @lib/diff.rb@ to @lib/redmine/string_array_diff@ and extract @Diffable@ class to its own file ( #29914 , #32938 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@21262 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-27 20:42:10 +00:00
Marius Balteanu
fe5c3f81de
Revert changes made in r21251 due to a test fail ( #29914 , #32938 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@21254 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-21 06:30:52 +00:00
Marius Balteanu
7125fd70ce
Split multiple classes and modules that existed in the same file ( #29914 , #32938 ).
...
Patch by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@21252 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-20 22:18:49 +00:00
Marius Balteanu
a256addaf7
Fix rubocop "Style/CombinableLoops" offense in wiki_page.rb ( #29914 , #32938 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@21251 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-20 22:02:03 +00:00
Marius Balteanu
d91f644a14
Disable rubocop Lint/IneffectiveAccessModifier for @self.tokenized_like_conditions@ in @app/models/query.rb@ ( #35764 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@21241 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-09 06:47:54 +00:00
Marius Balteanu
6cbf1f2015
Explicitly specify escape character using an ESCAPE on SQLite ( #35073 ).
...
Patch by Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@21240 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-09 06:35:47 +00:00
Marius Balteanu
506fc9d74c
Tokenize search parameter in order to allow multiple search terms in:
...
* the "contains" operator of text filters
* in issue autocomplete
Patch by Jens Krämer.
git-svn-id: http://svn.redmine.org/redmine/trunk@21238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-05 19:54:31 +00:00
Marius Balteanu
a0ef175ffe
Fix rubocop offense ( #35073 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@21234 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-03 19:56:00 +00:00
Marius Balteanu
5c7d43d36a
Replace send with direct call because sanitize_sql_for_conditions is now public ( #35073 ).
...
Patch by Jens Krämer.
git-svn-id: http://svn.redmine.org/redmine/trunk@21233 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-03 19:46:53 +00:00
Marius Balteanu
0ec96f52f3
Use sanitize_sql_like in Query#sql_contains ( #35073 ).
...
Patch by Jens Krämer.
git-svn-id: http://svn.redmine.org/redmine/trunk@21232 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-03 19:45:20 +00:00
Marius Balteanu
05e9d7883b
Use sanitize_sql_like in like scopes ( #35073 ).
...
Patch Jens Krämer.
git-svn-id: http://svn.redmine.org/redmine/trunk@21231 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-03 19:44:39 +00:00
Marius Balteanu
715ffcda43
Append two spaces to lines when importing an email on CommonMark with hardbreaks disabled ( #32424 ).
...
Patch by Jens Krämer.
git-svn-id: http://svn.redmine.org/redmine/trunk@21228 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-03 19:20:04 +00:00
Go MAEDA
bc3938fca3
Fix NoMethodError when generating a link to a locked user ( #12795 , #35823 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@21217 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-09-07 14:59:40 +00:00
Marius Balteanu
55ce8de0ae
Use ids instead of pluck(:id) ( #32977 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@21208 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-09-06 18:33:14 +00:00
Marius Balteanu
4378b7e1b4
Remove references to deleted user from "user"-Format CustomFields when destroying an user ( #32977 ).
...
Patch by Jens Krämer.
git-svn-id: http://svn.redmine.org/redmine/trunk@21207 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-09-06 18:30:04 +00:00
Go MAEDA
1578c7207b
Fix that binmode specified twice ( #35539 , #35720 ).
...
Patch by Pavel Rosický.
git-svn-id: http://svn.redmine.org/redmine/trunk@21193 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-08-18 02:34:46 +00:00
Marius Balteanu
f31a1e2bbb
Fixed attachments deletable by user without edit issue permission on tracker ( #35634 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@21142 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-08-05 23:50:11 +00:00
Marius Balteanu
805b36cbfb
Remove unused setting 'Blind carbon copy recipients (bcc)' ( #30820 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@21130 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-08-01 17:25:13 +00:00
Go MAEDA
da4303a961
Locked users should not be displayed in the members box of the project overview page ( #35606 ).
...
Patch by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@21090 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-27 04:55:08 +00:00
Marius Balteanu
3ebe6a8b0a
When updating an issue, allow adding time entry on an issue that was visible for the previous assignee ( #34856 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@21081 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-26 20:20:41 +00:00
Go MAEDA
8e4d71adc9
Ensure unique attachment filenames ( #35539 ).
...
Patch by Jens Krämer.
git-svn-id: http://svn.redmine.org/redmine/trunk@21071 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-19 13:27:59 +00:00
Go MAEDA
8f0d358533
User sessions not reset after 2FA activation ( #35417 ).
...
Patch by Felix Schäfer.
git-svn-id: http://svn.redmine.org/redmine/trunk@21069 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-15 01:44:05 +00:00
Go MAEDA
7f965286ed
Default issue query ( #7360 ).
...
Patch by Katsuya HIDAKA (the author of https://github.com/hidakatsuya/redmine_default_custom_query ), Takenori TAKAKI, Olivier Chabert, and Jens Krämer.
git-svn-id: http://svn.redmine.org/redmine/trunk@21061 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-06 06:01:50 +00:00
Marius Balteanu
1b0bf28803
When 2FA is set to optional, allow to require 2FA only for certain user groups ( #31920 ).
...
Patch by Jens Krämer.
git-svn-id: http://svn.redmine.org/redmine/trunk@21060 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-04 13:06:47 +00:00
Go MAEDA
41b22756d2
Allow sending account information when importing users ( #35365 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@21058 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-03 09:40:05 +00:00
Go MAEDA
9101dcf111
Project specific TimeEntryActivity name not updating properly ( #21056 ).
...
Patch by Mizuki ISHIKAWA.
git-svn-id: http://svn.redmine.org/redmine/trunk@21054 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-06-30 02:39:18 +00:00
Go MAEDA
51755e4349
Require redmine/sort_criteria globally ( #35455 ).
...
Patch by Felix Schäfer.
git-svn-id: http://svn.redmine.org/redmine/trunk@21050 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-06-26 01:16:41 +00:00
Go MAEDA
ffc9101e23
Use base_scope for issue query results ( #35396 ).
...
Patch by Alexander Meindl.
git-svn-id: http://svn.redmine.org/redmine/trunk@21040 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-06-19 02:16:38 +00:00
Go MAEDA
a0bf4e5cd3
Filter issues by file description ( #34715 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@21034 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-06-14 07:01:27 +00:00
Go MAEDA
66fc9f463d
Gracefully handle invalid query parameters for custom fields ( #35312 ).
...
Patch by Holger Just.
git-svn-id: http://svn.redmine.org/redmine/trunk@21012 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-05-28 03:58:01 +00:00
Go MAEDA
97c2607da4
X-Redmine-Issue-Assignee email header field is empty when the assignee of an issue is a group ( #35017 ).
...
Patch by Akihiro MATOBA.
git-svn-id: http://svn.redmine.org/redmine/trunk@21005 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-05-18 05:18:23 +00:00
Go MAEDA
a9aae29708
Remove deprecated Project#members_by_role ( #35031 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@21003 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-05-15 05:52:58 +00:00
Go MAEDA
ec3527102d
Remove deprecated WikiContent::Version ( #35031 ).
...
git-svn-id: http://svn.redmine.org/redmine/trunk@21002 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-05-15 05:51:14 +00:00
Go MAEDA
49e323ae7a
Duplicate entries in issue filter values ( #35201 ).
...
Patch by Jens Krämer.
git-svn-id: http://svn.redmine.org/redmine/trunk@20990 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-05-07 04:45:08 +00:00
Go MAEDA
cbd5f2ce8c
Mail handler bypasses add_issue_notes permission ( #35045 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@20970 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-25 13:02:13 +00:00
Go MAEDA
d67ed93f39
Allow Unique ID and relation fields to be auto mapped ( #35131 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@20968 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-23 03:53:53 +00:00
Go MAEDA
137b41cf38
Ruby 2.7: FrozenError when new LDAP users try to login ( #35135 ).
...
Patch by Pavel Rosický.
git-svn-id: http://svn.redmine.org/redmine/trunk@20966 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-23 03:02:24 +00:00
Go MAEDA
1cf427ee63
Stricter validation of given revisions of repositories ( #35085 ).
...
Patch by Holger Just.
git-svn-id: http://svn.redmine.org/redmine/trunk@20962 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-23 00:46:45 +00:00
Go MAEDA
ccd00df71c
MailHandler raises NameError exception when generating error message ( #35100 ).
...
Patch by Dmitry Makurin and Go MAEDA.
git-svn-id: http://svn.redmine.org/redmine/trunk@20959 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-22 03:07:42 +00:00
Go MAEDA
de93c19c3f
Disable grouping for associations custom field ( #35115 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@20956 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-21 07:29:02 +00:00
Go MAEDA
7ab1a667a9
Filter issues by notes ( #5893 ).
...
Patch by Yuichi HARADA.
git-svn-id: http://svn.redmine.org/redmine/trunk@20955 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-21 07:01:02 +00:00
Go MAEDA
e41cf61de8
Validate attachment filenames on every change ( #34367 ).
...
Patch by Holger Just.
git-svn-id: http://svn.redmine.org/redmine/trunk@20946 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-16 01:36:59 +00:00
Go MAEDA
ab3128106e
The result of Attachment.latest_attach is unstable if attachments have the same timestamp ( #34999 ).
...
Patch by Pavel Rosický.
git-svn-id: http://svn.redmine.org/redmine/trunk@20923 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-07 05:30:01 +00:00
Go MAEDA
83e22515b9
Ruby 3.0: Fix super calls ( #34992 , #34986 ).
...
Patch by Pavel Rosický.
git-svn-id: http://svn.redmine.org/redmine/trunk@20912 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-03 09:01:53 +00:00
Go MAEDA
74a6ff0230
Replace pluck().first with pick() ( #32909 ).
...
Patch by Pavel Rosický and Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@20907 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-03 01:34:45 +00:00
Go MAEDA
268b474f53
Rails 6.1: fix set roleids ( #29914 , #32935 ).
...
Patch by Pavel Rosický.
git-svn-id: http://svn.redmine.org/redmine/trunk@20899 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-01 15:45:23 +00:00
Go MAEDA
ba6ace46d7
Fix sending mail with DeliveryJob is deprecated ( #29914 , #32908 ).
...
Patch by Pavel Rosický.
git-svn-id: http://svn.redmine.org/redmine/trunk@20882 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-01 14:41:03 +00:00
Go MAEDA
2a564a1376
DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1. ( #29914 , #32897 ).
...
Patch by Marius BALTEANU.
git-svn-id: http://svn.redmine.org/redmine/trunk@20880 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-01 14:32:23 +00:00
Go MAEDA
f134831602
Do not journalize attachments that are added during a "Copy Issue" operation ( #34921 ).
...
Patch by Jens Krämer.
git-svn-id: http://svn.redmine.org/redmine/trunk@20872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-29 03:32:38 +00:00
Go MAEDA
770a31a78e
Use secure_compare to validate keys ( #34950 ).
...
Patch by Holger Just.
git-svn-id: http://svn.redmine.org/redmine/trunk@20854 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-26 05:08:03 +00:00