1
0
mirror of https://github.com/meineerde/redmine.git synced 2025-10-17 17:01:01 +00:00

2298 Commits

Author SHA1 Message Date
Marius Balteanu
9b807267ac Add sudo-mode to all 2fa actions
The sudo-mode window should ensure this does not impede users
currently setting up 2fa things, but adds protection when not
in 2fa activation/deactivation mode. (#43083).

Patch by Felix Schäfer (user:felix).

git-svn-id: https://svn.redmine.org/redmine/trunk@23918 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-13 05:59:53 +00:00
Marius Balteanu
2d1f1684a1 Explicitly don't cache sensitive 2FA actions (#43083).
Patch by Felix Schäfer (user:felix).

git-svn-id: https://svn.redmine.org/redmine/trunk@23917 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-13 05:58:49 +00:00
Marius Balteanu
8f002c297e Deny 2fa setup when 2fa already present (#43083).
Patch by Felix Schäfer (user:felix).

git-svn-id: https://svn.redmine.org/redmine/trunk@23916 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-13 05:57:21 +00:00
Marius Balteanu
d79fe0df9a Adds @Cache-Control: no-store@ header to login, lost password, change password and sudo pages (#42998).
Patch by Go MAEDA (user:maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@23908 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-08-10 13:23:14 +00:00
Go MAEDA
69dde23d5c Downloading .js files from the repository browser fails with a 422 error due to ActionController::InvalidCrossOriginRequest (#42839).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23857 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-07-05 02:22:30 +00:00
Go MAEDA
8cc3e1a5ac Fix N+1 query in Wiki history page by preloading the author of each Wiki content version (#42933).
Patch by [Agileware]Kota Uchino (user:uchinokot).


git-svn-id: https://svn.redmine.org/redmine/trunk@23847 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-29 04:55:22 +00:00
Marius Balteanu
2d3b3b939e Add OAuth2 provider capability using doorkeeper gem (#24808).
Patch by Jens Krämer (user:jkraemer).

git-svn-id: https://svn.redmine.org/redmine/trunk@23837 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-12 07:09:03 +00:00
Marius Balteanu
e56d84b632 Reverts r23835 due to wrong issue ID (#40856).
git-svn-id: https://svn.redmine.org/redmine/trunk@23836 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-12 07:05:01 +00:00
Marius Balteanu
ebdd1a40f4 Add OAuth2 provider capability using doorkeeper gem (#40856).
Patch by Jens Krämer (user:jkraemer).

git-svn-id: https://svn.redmine.org/redmine/trunk@23835 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-06-11 20:30:44 +00:00
Go MAEDA
d2a9223c4a Improve method and variable naming for clarity and consistency (#42630).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23769 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-15 05:09:17 +00:00
Go MAEDA
403c10091f Introduce reactions feature (so-called "like button") to issues, notes, news, and forums (#42630).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23755 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-11 07:59:16 +00:00
Go MAEDA
3c0faad370 Optimize the rendering of versions on the roadmap by preloading the email addresses of issue assignees (#42682).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23749 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-07 04:39:24 +00:00
Go MAEDA
2d064e6952 Avoid unnecessary SQL query for subprojects in ProjectsController#show when project has no children (#42671).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23745 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-05-06 02:16:37 +00:00
Go MAEDA
113d7f50a9 Optimize autocomplete issue listing triggered by typing "##" by eager loading trackers (#42574).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23660 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-16 06:50:26 +00:00
Go MAEDA
08ea4e0323 Fix RuboCop Style/RedundantCondition (#41884).
git-svn-id: https://svn.redmine.org/redmine/trunk@23627 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-11 09:21:17 +00:00
Go MAEDA
630f2863ba Improve role deletion error message to display projects containing members under the role (#42441).
Patch by Mizuki ISHIKAWA (user:ishikawa999).


git-svn-id: https://svn.redmine.org/redmine/trunk@23619 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-04-10 10:14:30 +00:00
Marius Balteanu
3c57eaffd4 Add administration setting to allow time logging on closed issues. By default, the setting is enabled (#13596).
git-svn-id: https://svn.redmine.org/redmine/trunk@23586 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-03-30 07:48:53 +00:00
Marius Balteanu
8cd7d5bdf7 Fixes rubocop offense (#42352).
git-svn-id: https://svn.redmine.org/redmine/trunk@23533 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-03-10 00:33:48 +00:00
Marius Balteanu
1f46b0b236 Extract project query for admins to a separate ProjectAdminQuery model (#42352).
Patch by Holger Just (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23531 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-03-09 23:25:12 +00:00
Marius Balteanu
10971361fa Allow query class to select layout for QueriesController (#42352).
Patch by Holger Just (user:hjust).

git-svn-id: https://svn.redmine.org/redmine/trunk@23529 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-03-09 23:20:50 +00:00
Go MAEDA
55d6b59b61 Simplify URL components omission in ApplicationController#verify_back_url (#41930).
git-svn-id: https://svn.redmine.org/redmine/trunk@23469 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-01-28 08:24:52 +00:00
Go MAEDA
7ccf349e36 Redirection after signing in fails when the back_url includes a port number (#41930).
Patch by Kenta Kumojima (user:kumojima) and Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23465 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-01-28 05:49:12 +00:00
Go MAEDA
d480067439 Optimize IssuesController#show by skipping time tracking queries when disabled (#42144).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23463 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-01-25 08:18:26 +00:00
Go MAEDA
9fccf787a4 Remove navigation parameters from issue detail URLs after updates (#42073).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23433 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-01-07 07:18:32 +00:00
Marius Balteanu
d63678068a Fix random test failure by ensuring @WatchersController#find_objects_from_params@ returns results in consistent order (#41894).
Patch by Go MAEDA (user:maeda).

git-svn-id: https://svn.redmine.org/redmine/trunk@23325 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-11-29 07:52:05 +00:00
Go MAEDA
071971131f Fix project links in tracker deletion error message to set the status_id filter to "all" (#12521).
git-svn-id: https://svn.redmine.org/redmine/trunk@23209 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-11-04 04:50:25 +00:00
Go MAEDA
e5867ffc8d Improve tracker deletion error message to display projects containing issues under the tracker (#12521).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23181 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-11-03 07:11:07 +00:00
Go MAEDA
8ca5d2fa1a Partial quoting feature for Issues and Forums (#41294).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23107 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-10-09 21:51:52 +00:00
Go MAEDA
2fe36c4128 Fix RuboCop offense Style/RedundantInterpolationUnfreeze (#39887).
Since interpolated strings are always unfrozen in Ruby 3.0 and later, the use of `+""` is now redundant.


git-svn-id: https://svn.redmine.org/redmine/trunk@23001 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-09-01 00:38:01 +00:00
Marius Balteanu
ffce07e785 Start working on replacing old icons with SVG icons (#23980):
* Introduces IconsHelper with methods to render SVG icon from a sprite file.
* Adds SVG sprite file with icons mainly from Font Awesome, but also from Material Design Icons and Fluent UI System Icons (based on the work made by Takashi Kato (@tohosaku)).
* Replaces specific icons with new SVG icons.
* Temporarily keep all old CSS icon definitions for backard compatibility.



git-svn-id: https://svn.redmine.org/redmine/trunk@22988 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-29 21:46:40 +00:00
Go MAEDA
fdd90bab2b Fix RuboCop offenses Style/NegatedIf and Style/NegatedWhile (#39887, #7770).
git-svn-id: https://svn.redmine.org/redmine/trunk@22987 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-25 08:44:33 +00:00
Marius Balteanu
fb37d2e4fa Upgrade to Rails 7.2.0 (#36320).
Patch by Takashi Kato (user:tohosaku). 


git-svn-id: https://svn.redmine.org/redmine/trunk@22960 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-20 05:54:30 +00:00
Go MAEDA
6c8b04d6d5 Add configurable setting for copying attachments when copying an issue (#36197).
Patch by Yuichi HARADA (user:yui.har).


git-svn-id: https://svn.redmine.org/redmine/trunk@22926 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-14 01:49:53 +00:00
Marius Balteanu
6322650728 Add bulk unlock to user list context menu (#40913).
git-svn-id: https://svn.redmine.org/redmine/trunk@22925 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-13 10:21:49 +00:00
Go MAEDA
47d7dd0187 Fix RuboCop offense Style/CollectionCompact (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22921 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-11 09:35:32 +00:00
Marius Balteanu
c15c754589 Introduces @valid_watcher?@ check on watchables (@40946).
Patch by Jens Krämer (@jkraemer).



git-svn-id: https://svn.redmine.org/redmine/trunk@22916 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-08 21:33:50 +00:00
Marius Balteanu
57743c4145 Permission check based on the type of @watchables@ (#40946).
Patch by Jens Krämer (@jkraemer).



git-svn-id: https://svn.redmine.org/redmine/trunk@22915 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-08 21:32:15 +00:00
Marius Balteanu
2d20811f40 Improve watcher list permissions check to explicitly require @view_issue_watchers@ permission (#40946).
Patch by Felix Schäfer (@felix).



git-svn-id: https://svn.redmine.org/redmine/trunk@22913 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-08 21:28:24 +00:00
Marius Balteanu
193ca9faee Add bulk lock feature to user list context menu (#40913).
Patch by Mizuki ISHIKAWA (@ishikawa999).


git-svn-id: https://svn.redmine.org/redmine/trunk@22898 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-25 19:03:36 +00:00
Go MAEDA
b803bddb1f Fix "ArgumentError: Invalid response name: unprocessable_entity" with Rack 3.1.0+ in assert_response (#39889).
Rack 3.1.0 changed the symbol for HTTP status code 422 from `:unprocessable_entity` to `:unprocessable_content`.
Due to the change, `assert_response(:unprocessable_entity, ...)` raises ArgumentError with Rack 3.1.0+.

This fix is a follow-up to r22837.


git-svn-id: https://svn.redmine.org/redmine/trunk@22876 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-12 16:09:37 +00:00
Marius Balteanu
38a8adb2a2 Adds description field to custom queries (#9309).
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22855 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-04 20:04:45 +00:00
Go MAEDA
c19176a5c4 Reduce an extra SQL query in IssuesController#retrieve_default_query (#40775).
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22854 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-04 09:37:34 +00:00
Go MAEDA
c0af36b12d Dynamic generation of supported code highlighting languages in help section (#40681).
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22840 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-19 05:07:42 +00:00
Go MAEDA
a9518e28b8 Fix RuboCop offense Rails/HttpStatus (#39889).
git-svn-id: https://svn.redmine.org/redmine/trunk@22837 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-18 05:56:55 +00:00
Marius Balteanu
b4bfb6b581 Replaces use of Digest::MD5 / Digest::SHA1 with ActiveSupport::Digest (#35217).
Patch by Jens Krämer (@jkraemer).

git-svn-id: https://svn.redmine.org/redmine/trunk@22816 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-07 18:36:46 +00:00
Marius Balteanu
8b57ffc3c7 Adds the date of the last activity to the list of available columns for Projects (#23954).
Patch by Frederico Camara (@fredsdc) and Marius BĂLTEANU (@marius.balteanu).

git-svn-id: https://svn.redmine.org/redmine/trunk@22811 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-03 13:14:18 +00:00
Marius Balteanu
54aa810240 Fix rubocop warning (#39111, #40137).
git-svn-id: https://svn.redmine.org/redmine/trunk@22757 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-03-03 22:24:58 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043).
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Marius Balteanu
eef8f625c8 Adds route for code highlighting languages page (#39111, #40137).
git-svn-id: https://svn.redmine.org/redmine/trunk@22732 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-25 21:41:14 +00:00
Marius Balteanu
56f3a4dac3 * Remove languages from wiki syntax help files that are identical with en language.
* Fall back to the english help page if there is none for the current language.

(#39111, #40137).

git-svn-id: https://svn.redmine.org/redmine/trunk@22721 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-19 20:54:01 +00:00