meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-19 15:01:14 +00:00
Code Issues Releases Wiki Activity

Ensure that vendor-defined characters in ISO-2022-JP email subject don't break issue's subject (#29442).

Browse Source 
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17596 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA 2018-10-15 10:00:18 +00:00
parent 88a83228e1
commit facb44cb03
2 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/fixtures/mail_handler/subject_japanese_3.eml vendored Normal file
View File

@ -0,0 +1,9 @@
From: John Smith <JSmith@somenet.foo>
To: "redmine@somenet.foo" <redmine@somenet.foo>
Subject: =?iso-2022-jp?B?GyRCLSEbKEIgGyRCNF0/dDt6JUYlOSVIGyhC?=
Date: Mon, 27 Aug 2018 09:30:00 +0900
Message-ID: <87C31D42249DD0489D1A1444E3232DD7019D6183@foo.bar>
The subject contains a "CIRCLED DIGIT ONE" character (U+2460).
It is undefined in ISO-2022-JP but defined in some vendor-extended
variants such as ISO-2022-JP-MS.

14
test/unit/mail_handler_test.rb
View File

@ -741,6 +741,20 @@ class MailHandlerTest < ActiveSupport::TestCase
assert_equal ja, issue.subject assert_equal ja, issue.subject
end end
def test_add_issue_with_iso_2022_jp_ms_subject
# The original subject is "① 丸数字テスト".
# CIRCLED DIGIT ONE character is undefined in ISO-2022-JP but
# defined in some vendor-extended variants such as ISO-2022-JP-MS.
# This test makes sure that mail gem replaces an undefined characters
# with a replacement character instead of breaking the whole subject.
issue = submit_email(
'subject_japanese_3.eml',
:issue => {:project => 'ecookbook'}
)
assert_kind_of Issue, issue
assert_match /丸数字テスト/, issue.subject
end
def test_should_ignore_emails_from_locked_users def test_should_ignore_emails_from_locked_users
User.find(2).lock! User.find(2).lock!