From fa8984f36a3f61588c103da323cfbb0764243ef8 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Lang Date: Fri, 15 Mar 2019 07:28:25 +0000 Subject: [PATCH] Searching for issue number with REST API redirects to issue HTML page (#29055). Patch by Go MAEDA. git-svn-id: http://svn.redmine.org/redmine/trunk@17949 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/controllers/search_controller.rb | 2 +- test/integration/api_test/search_test.rb | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/app/controllers/search_controller.rb b/app/controllers/search_controller.rb index 37ac37cac..8ae53e7ff 100644 --- a/app/controllers/search_controller.rb +++ b/app/controllers/search_controller.rb @@ -39,7 +39,7 @@ class SearchController < ApplicationController end # quick jump to an issue - if (m = @question.match(/^#?(\d+)$/)) && (issue = Issue.visible.find_by_id(m[1].to_i)) + if !api_request? && (m = @question.match(/^#?(\d+)$/)) && (issue = Issue.visible.find_by_id(m[1].to_i)) redirect_to issue_path(issue) return end diff --git a/test/integration/api_test/search_test.rb b/test/integration/api_test/search_test.rb index 65d4654d8..951fb45a9 100644 --- a/test/integration/api_test/search_test.rb +++ b/test/integration/api_test/search_test.rb @@ -91,4 +91,9 @@ class Redmine::ApiTest::SearchTest < Redmine::ApiTest::Base assert_equal 4, json['limit'] assert_equal issue[8..10], json['results'].map {|r| r['id']} end + + test "GET /search.xml should not quick jump to the issue with given id" do + get '/search.xml', :params => {:q => '3'} + assert_response :success + end end