From f1561ebda9a29534ea7c912b162acce8de465454 Mon Sep 17 00:00:00 2001 From: Holger Just Date: Sun, 20 Jun 2010 21:14:43 +0200 Subject: [PATCH] Fixed search for large integers --- app/controllers/search_controller.rb | 2 +- test/functional/search_controller_test.rb | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/app/controllers/search_controller.rb b/app/controllers/search_controller.rb index 0f0a4e6ae..f2d43be8e 100644 --- a/app/controllers/search_controller.rb +++ b/app/controllers/search_controller.rb @@ -43,7 +43,7 @@ class SearchController < ApplicationController begin; offset = params[:offset].to_time if params[:offset]; rescue; end # quick jump to an issue - if @question.match(/^#?(\d+)$/) && Issue.visible.find_by_id($1) + if @question.match(/^#?(\d+)$/) && $1.to_i <= 2147483647 && Issue.visible.find_by_id($1) redirect_to :controller => "issues", :action => "show", :id => $1 return end diff --git a/test/functional/search_controller_test.rb b/test/functional/search_controller_test.rb index b062468a6..546034e71 100644 --- a/test/functional/search_controller_test.rb +++ b/test/functional/search_controller_test.rb @@ -134,6 +134,12 @@ class SearchControllerTest < ActionController::TestCase assert_template 'index' end + def test_large_integer + get :index, :q => '4615713488' + assert_response :success + assert_template 'index' + end + def test_tokens_with_quotes get :index, :id => 1, :q => '"good bye" hello "bye bye"' assert_equal ["good bye", "hello", "bye bye"], assigns(:tokens)