meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-19 23:11:12 +00:00
Code Issues Releases Wiki Activity

IssuesControllerTest#test_index_sort_by_total_estimated_hours tests nothing (#30474).

Browse Source 
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17837 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA 2019-01-22 08:23:53 +00:00
parent 61a365789f
commit eda4b6514b
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/fixtures/issues.yml vendored
View File

@ -15,6 +15,7 @@ issues_001:
status_id: 1 status_id: 1
start_date: <%= 1.day.ago.to_date.to_s(:db) %> start_date: <%= 1.day.ago.to_date.to_s(:db) %>
due_date: <%= 10.day.from_now.to_date.to_s(:db) %> due_date: <%= 10.day.from_now.to_date.to_s(:db) %>
estimated_hours: 200.0
root_id: 1 root_id: 1
lft: 1 lft: 1
rgt: 2 rgt: 2
@ -35,6 +36,7 @@ issues_002:
status_id: 2 status_id: 2
start_date: <%= 2.day.ago.to_date.to_s(:db) %> start_date: <%= 2.day.ago.to_date.to_s(:db) %>
due_date: due_date:
estimated_hours: 0.5
root_id: 2 root_id: 2
lft: 1 lft: 1
rgt: 2 rgt: 2
@ -56,6 +58,7 @@ issues_003:
status_id: 1 status_id: 1
start_date: <%= 15.day.ago.to_date.to_s(:db) %> start_date: <%= 15.day.ago.to_date.to_s(:db) %>
due_date: <%= 5.day.ago.to_date.to_s(:db) %> due_date: <%= 5.day.ago.to_date.to_s(:db) %>
estimated_hours: 1.0
root_id: 3 root_id: 3
lft: 1 lft: 1
rgt: 2 rgt: 2
@ -90,6 +93,7 @@ issues_005:
assigned_to_id: assigned_to_id:
author_id: 2 author_id: 2
status_id: 1 status_id: 1
estimated_hours: 2.0
root_id: 5 root_id: 5
lft: 1 lft: 1
rgt: 2 rgt: 2

2
test/functional/issues_controller_test.rb
View File

@ -1067,6 +1067,8 @@ class IssuesControllerTest < Redmine::ControllerTest
} }
assert_response :success assert_response :success
hours = issues_in_list.map(&:total_estimated_hours) hours = issues_in_list.map(&:total_estimated_hours)
# Removes nil because the position of NULL is database dependent
hours.compact!
assert_equal hours.sort.reverse, hours assert_equal hours.sort.reverse, hours
end end