meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-24 01:11:12 +00:00
Code Issues Releases Wiki Activity

Allow single Chinese character as a search keyword (#30037).

Browse Source 
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17667 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA 2018-11-30 15:42:30 +00:00
parent 198212f991
commit e23b2023cb
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/redmine/search.rb
View File

@ -60,7 +60,8 @@ module Redmine
# eg. hello "bye bye" => ["hello", "bye bye"]
@tokens = @question.scan(%r{((\s|^)"[^"]+"(\s|$)|\S+)}).collect {|m| m.first.gsub(%r{(^\s*"\s*|\s*"\s*$)}, '')}
# tokens must be at least 2 characters long
@tokens = @tokens.uniq.select {|w| w.length > 1 }
# but for Chinese characters (汉字/漢字), tokens can be one character
@tokens = @tokens.uniq.select {|w| w.length > 1 || w =~ /\p{Han}/ }
# no more than 5 tokens to search for
@tokens.slice! 5..-1
end

5
test/unit/search_test.rb
View File

@ -194,6 +194,11 @@ class SearchTest < ActiveSupport::TestCase
assert_equal ['Special', 'chars', 'in a phrase Öö'], f.tokens
end
def test_fetcher_should_exclude_single_character_tokens_except_for_chinese_characters
f = Redmine::Search::Fetcher.new('ca f é 漢 あ 한', User.anonymous, %w(issues), Project.all)
assert_equal ['ca', '漢'], f.tokens
end
private
def remove_permission(role, permission)