diff --git a/app/assets/images/icons.svg b/app/assets/images/icons.svg index ef44b6ddf..148cd09a0 100644 --- a/app/assets/images/icons.svg +++ b/app/assets/images/icons.svg @@ -476,6 +476,11 @@ + + + + + @@ -485,6 +490,10 @@ + + + + diff --git a/app/assets/stylesheets/application.css b/app/assets/stylesheets/application.css index 61df9fd98..96fbb6f8f 100644 --- a/app/assets/stylesheets/application.css +++ b/app/assets/stylesheets/application.css @@ -1779,11 +1779,6 @@ svg.icon-ok { display: none; } -.icon-fav svg.icon-svg { - fill: #ffc400; - stroke: #ffc400; -} - svg.icon-svg { stroke: #169; fill: none; diff --git a/app/helpers/watchers_helper.rb b/app/helpers/watchers_helper.rb index 882325c18..6e6366846 100644 --- a/app/helpers/watchers_helper.rb +++ b/app/helpers/watchers_helper.rb @@ -26,6 +26,7 @@ module WatchersHelper watched = Watcher.any_watched?(objects, user) css = [watcher_css(objects), watched ? 'icon icon-fav' : 'icon icon-fav-off'].join(' ') + icon = watched ? 'unwatch' : 'watch' text = watched ? l(:button_unwatch) : l(:button_watch) url = watch_path( :object_type => objects.first.class.to_s.underscore, @@ -33,7 +34,7 @@ module WatchersHelper ) method = watched ? 'delete' : 'post' - link_to sprite_icon('fav', text), url, :remote => true, :method => method, :class => css + link_to sprite_icon(icon, text), url, :remote => true, :method => method, :class => css end # Returns the css class used to identify watch links for a given +object+ diff --git a/config/icon_source.yml b/config/icon_source.yml index a73e9a2ba..a6f3f5a85 100644 --- a/config/icon_source.yml +++ b/config/icon_source.yml @@ -214,3 +214,7 @@ - name: circle-dot-filled svg: circle-dot style: filled +- name: watch + svg: eye +- name: unwatch + svg: eye-off diff --git a/test/helpers/watchers_helper_test.rb b/test/helpers/watchers_helper_test.rb index c59e8e25d..6f8dbde21 100644 --- a/test/helpers/watchers_helper_test.rb +++ b/test/helpers/watchers_helper_test.rb @@ -26,7 +26,7 @@ class WatchersHelperTest < Redmine::HelperTest test '#watcher_link with a non-watched object' do expected = link_to( - sprite_icon("fav", "Watch"), + sprite_icon("watch", "Watch"), "/watchers/watch?object_id=1&object_type=issue", :remote => true, :method => 'post', :class => "issue-1-watcher icon icon-fav-off" ) @@ -35,7 +35,7 @@ class WatchersHelperTest < Redmine::HelperTest test '#watcher_link with a single object array' do expected = link_to( - sprite_icon("fav", "Watch"), + sprite_icon("watch", "Watch"), "/watchers/watch?object_id=1&object_type=issue", :remote => true, :method => 'post', :class => "issue-1-watcher icon icon-fav-off" ) @@ -44,7 +44,7 @@ class WatchersHelperTest < Redmine::HelperTest test '#watcher_link with a multiple objects array' do expected = link_to( - sprite_icon("fav", "Watch"), + sprite_icon("watch", "Watch"), "/watchers/watch?object_id%5B%5D=1&object_id%5B%5D=3&object_type=issue", :remote => true, :method => 'post', :class => "issue-bulk-watcher icon icon-fav-off" ) @@ -59,7 +59,7 @@ class WatchersHelperTest < Redmine::HelperTest Watcher.create!(:watchable => Issue.find(1), :user => User.find(1)) expected = link_to( - sprite_icon("fav", "Unwatch"), + sprite_icon("unwatch", "Unwatch"), "/watchers/watch?object_id=1&object_type=issue", :remote => true, :method => 'delete', :class => "issue-1-watcher icon icon-fav" )