From dde3fe9bfe8dd6e059cee5b12ff0bd0aa3b5928c Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Sun, 9 Feb 2025 05:43:11 +0000 Subject: [PATCH] Increase ComparisonsThreshold for RuboCop's Style/MultipleComparison to 3 (#41884). git-svn-id: https://svn.redmine.org/redmine/trunk@23496 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- .rubocop.yml | 4 ++++ .rubocop_todo.yml | 8 -------- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 3190c2870..3a2831c05 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -246,6 +246,10 @@ Style/IdenticalConditionalBranches: Style/InverseMethods: Enabled: false +Style/MultipleComparison: + Enabled: true + ComparisonsThreshold: 3 + Style/NegatedIfElseCondition: Enabled: false diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index e2b2a566b..aee767d54 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -966,14 +966,6 @@ Style/MultilineTernaryOperator: - 'lib/redmine/ciphering.rb' - 'lib/redmine/scm/adapters/filesystem_adapter.rb' -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowMethodComparison, ComparisonsThreshold. -Style/MultipleComparison: - Exclude: - - 'app/helpers/application_helper.rb' - - 'app/models/version.rb' - - 'app/models/wiki_page.rb' - # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: literals, strict