meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2025-10-17 17:01:01 +00:00
Code Issues Releases Wiki Activity

Fix: Round floats to 2 digits when rendering an issue list to PDF (#12510).

Browse Source 
Patch by Holger Just and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17059 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA 2017-12-06 14:25:35 +00:00
parent ae842a73db
commit d6d2d23365
2 changed files with 37 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/redmine/export/pdf/issues_pdf_helper.rb
View File

@ -384,6 +384,8 @@ module Redmine
format_date(value) format_date(value)
elsif value.is_a?(Time) elsif value.is_a?(Time)
format_time(value) format_time(value)
elsif value.is_a?(Float)
sprintf "%.2f", value
else else
value value
end end

35
test/unit/lib/redmine/export/pdf/issues_pdf_test.rb Normal file
View File

@ -0,0 +1,35 @@
# Redmine - project management software
# Copyright (C) 2006-2017 Jean-Philippe Lang
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
require File.expand_path('../../../../../../test_helper', __FILE__)
class IssuesPdfHelperTest < ActiveSupport::TestCase
include Redmine::Export::PDF::IssuesPdfHelper
def test_fetch_row_values_should_round_float_values
query = IssueQuery.new(:project => Project.find(1), :name => '_')
query.column_names = [:subject, :spent_hours]
issue = Issue.find(2)
TimeEntry.create(:spent_on => Date.today, :hours => 4.3432, :user => User.find(1), :project_id => 1, :issue => issue, :activity => TimeEntryActivity.first)
results = fetch_row_values(issue, query, 0)
assert_equal ["2", "Add ingredients categories", "4.34"], results
end
end