meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-01-14 11:22:54 +00:00
Code Issues Releases Wiki Activity

Code cleanup, use safer #closed?

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@13505 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang 2014-10-24 21:40:26 +00:00
parent 67c4936908
commit d62574badb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/models/issue.rb
View File

@ -688,7 +688,7 @@ class Issue < ActiveRecord::Base
# Return true if the issue is closed, otherwise false
def closed?
self.status.is_closed?
status.present? && status.is_closed?
end
# Return true if the issue is being reopened
@ -706,7 +706,7 @@ class Issue < ActiveRecord::Base
# Return true if the issue is being closed
def closing?
if !new_record? && status_id_changed?
if status_was && status && !status_was.is_closed? && status.is_closed?
if closed? && status_was && !status_was.is_closed?
return true
end
end