meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-19 15:01:14 +00:00
Code Issues Releases Wiki Activity

Fixed: unable to clear value for list custom field with multiple values and checkboxes style (#16798).

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@13167 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang 2014-05-24 16:53:33 +00:00
parent 96baa905bf
commit cf4af2c5db
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/redmine/field_format.rb
View File

@ -498,6 +498,9 @@ module Redmine
tag_id = nil tag_id = nil
s << view.content_tag('label', tag + ' ' + label) s << view.content_tag('label', tag + ' ' + label)
end end
if custom_value.custom_field.multiple?
s << view.hidden_field_tag(tag_name, '')
end
css = "#{options[:class]} check_box_group" css = "#{options[:class]} check_box_group"
view.content_tag('span', s, options.merge(:class => css)) view.content_tag('span', s, options.merge(:class => css))
end end

12
test/unit/lib/redmine/field_format/list_format_test.rb
View File

@ -116,6 +116,18 @@ class Redmine::ListFieldFormatTest < ActionView::TestCase
end end
end end
def test_edit_tag_with_check_box_style_and_multiple_values_should_contain_hidden_field_to_clear_value
field = IssueCustomField.new(:field_format => 'list', :possible_values => ['Foo', 'Bar'], :is_required => false,
:edit_tag_style => 'check_box', :multiple => true)
value = CustomFieldValue.new(:custom_field => field, :customized => Issue.new)
tag = field.format.edit_tag(self, 'id', 'name', value)
assert_select_in tag, 'span' do
assert_select 'input[type=checkbox]', 2
assert_select 'input[type=hidden]', 1
end
end
def test_field_with_url_pattern_should_link_value def test_field_with_url_pattern_should_link_value
field = IssueCustomField.new(:field_format => 'list', :url_pattern => 'http://localhost/%value%') field = IssueCustomField.new(:field_format => 'list', :url_pattern => 'http://localhost/%value%')
formatted = field.format.formatted_value(self, field, 'foo', Issue.new, true) formatted = field.format.formatted_value(self, field, 'foo', Issue.new, true)