From c89fa2be5765deaae19e9a6ec1c6a391c54b61ec Mon Sep 17 00:00:00 2001 From: Jean-Philippe Lang Date: Sat, 30 May 2015 08:18:34 +0000 Subject: [PATCH] Connection leak in Redmine.pm (#19956). MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Patch by Bruno Orcha GarcĂ­a. git-svn-id: http://svn.redmine.org/redmine/trunk@14281 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- extra/svn/Redmine.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extra/svn/Redmine.pm b/extra/svn/Redmine.pm index ddad660b3..1ec057645 100644 --- a/extra/svn/Redmine.pm +++ b/extra/svn/Redmine.pm @@ -453,7 +453,6 @@ sub is_member { my $redmine_pass = shift; my $r = shift; - my $dbh = connect_database($r); my $project_id = get_project_identifier($r); my $pass_digest = Digest::SHA::sha1_hex($redmine_pass); @@ -466,6 +465,7 @@ sub is_member { $usrprojpass = $cfg->{RedmineCacheCreds}->get($redmine_user.":".$project_id.":".$access_mode); return 1 if (defined $usrprojpass and ($usrprojpass eq $pass_digest)); } + my $dbh = connect_database($r); my $query = $cfg->{RedmineQuery}; my $sth = $dbh->prepare($query); $sth->execute($redmine_user, $project_id);