meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-24 01:11:12 +00:00
Code Issues Releases Wiki Activity

Fixed that custom field referencing deleted value trigger an error on display (#16926).

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@13141 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang 2014-05-24 10:12:40 +00:00
parent 1fd5346c3c
commit c74925d4af
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/redmine/field_format.rb
View File

@ -98,9 +98,10 @@ module Redmine
if value.blank? if value.blank?
nil nil
elsif value.is_a?(Array) elsif value.is_a?(Array)
value.map do |v| casted = value.map do |v|
cast_single_value(custom_field, v, customized) cast_single_value(custom_field, v, customized)
end.sort end
casted.compact.sort
else else
cast_single_value(custom_field, value, customized) cast_single_value(custom_field, value, customized)
end end

7
test/unit/lib/redmine/field_format/version_field_format_test.rb
View File

@ -56,4 +56,11 @@ class Redmine::VersionFieldFormatTest < ActionView::TestCase
assert_equal expected, field.possible_values_options(project).map(&:first) assert_equal expected, field.possible_values_options(project).map(&:first)
end end
def test_cast_value_should_not_raise_error_when_array_contains_value_casted_to_nil
field = IssueCustomField.new(:field_format => 'version')
assert_nothing_raised do
field.cast_value([1,2, 42])
end
end
end end