From c6fdc7db866aa1adac2ec24bfa8633840610ca76 Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Tue, 31 Oct 2023 12:45:15 +0000 Subject: [PATCH] Redirect to repositories#show after repository#fetch_changesets to avoid the user-visible browser URL (#39238). Patch by Holger Just. git-svn-id: https://svn.redmine.org/redmine/trunk@22414 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/controllers/repositories_controller.rb | 6 +++++- test/functional/repositories_controller_test.rb | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/app/controllers/repositories_controller.rb b/app/controllers/repositories_controller.rb index 3fb69e8b2..b362bc152 100644 --- a/app/controllers/repositories_controller.rb +++ b/app/controllers/repositories_controller.rb @@ -103,7 +103,11 @@ class RepositoriesController < ApplicationController def fetch_changesets @repository.fetch_changesets if @project.active? && @path.empty? && !Setting.autofetch_changesets? - show + + redirect_to( + controller: :repositories, action: :show, + id: @project, repository_id: @repository.identifier_param + ) end def changes diff --git a/test/functional/repositories_controller_test.rb b/test/functional/repositories_controller_test.rb index 17d9a50c4..779d7d63d 100644 --- a/test/functional/repositories_controller_test.rb +++ b/test/functional/repositories_controller_test.rb @@ -237,7 +237,7 @@ class RepositoriesControllerTest < Redmine::RepositoryControllerTest role.add_permission! :manage_repository Repository::Subversion.any_instance.expects(:fetch_changesets).once post(:fetch_changesets, :params => {:id => 1, :repository_id => 10}) - assert_response :success + assert_redirected_to '/projects/ecookbook/repository/10' role.remove_permission! :manage_repository Repository::Subversion.any_instance.expects(:fetch_changesets).never