meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-03-29 12:11:13 +00:00
Code Issues Releases Wiki Activity

Fix RuboCop offense Style/ClassEqualityComparison (#39887).

Browse Source 
git-svn-id: https://svn.redmine.org/redmine/trunk@22978 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA 2024-08-21 13:45:13 +00:00
parent 7cc62836b5
commit c2eb20e434
2 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
.rubocop_todo.yml
View File

@ -758,13 +758,6 @@ Style/CaseLikeIf:
Style/ClassAndModuleChildren: Style/ClassAndModuleChildren:
Enabled: false Enabled: false
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: AllowedMethods, AllowedPatterns.
# AllowedMethods: ==, equal?, eql?
Style/ClassEqualityComparison:
Exclude:
- 'app/models/principal.rb'
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
Style/ClassMethods: Style/ClassMethods:
Exclude: Exclude:

2
app/models/principal.rb
View File

@ -159,7 +159,7 @@ class Principal < ApplicationRecord
return -1 if principal.nil? return -1 if principal.nil?
return nil unless principal.is_a?(Principal) return nil unless principal.is_a?(Principal)
if self.class.name == principal.class.name if self.instance_of?(principal.class)
self.to_s.casecmp(principal.to_s) self.to_s.casecmp(principal.to_s)
else else
# groups after users # groups after users