From c252857414ad6a665901eb76d6d32beac38da343 Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Thu, 30 Jan 2025 03:34:38 +0000 Subject: [PATCH] Reduce SQL queries triggered by `empty?` and `one?` in `TimeEntryActivity.default_activity_id` by preloading `available_activities` (#42150). git-svn-id: https://svn.redmine.org/redmine/trunk@23478 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/models/time_entry_activity.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/time_entry_activity.rb b/app/models/time_entry_activity.rb index 66245a461..d279359fb 100644 --- a/app/models/time_entry_activity.rb +++ b/app/models/time_entry_activity.rb @@ -58,7 +58,7 @@ class TimeEntryActivity < Enumeration end def self.default_activity_id(user=nil, project=nil) - available_activities = self.available_activities(project) + available_activities = self.available_activities(project).load return nil if available_activities.empty? return available_activities.first.id if available_activities.one?