From c1335f51266cd69ece60a9d12396f3668466fca9 Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Thu, 6 Jun 2024 01:20:23 +0000 Subject: [PATCH] Suppress RuboCop false positive for Security/Open (#39887). git-svn-id: https://svn.redmine.org/redmine/trunk@22862 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- .rubocop_todo.yml | 4 ---- app/models/version.rb | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 5b4a02137..2f7eb1c78 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -802,10 +802,6 @@ Security/IoMethods: - 'test/functional/mail_handler_controller_test.rb' - 'test/unit/mail_handler_test.rb' -Security/Open: - Exclude: - - 'app/models/version.rb' - # This cop supports unsafe autocorrection (--autocorrect-all). Security/YAMLLoad: Exclude: diff --git a/app/models/version.rb b/app/models/version.rb index b1327f068..eed2e22d7 100644 --- a/app/models/version.rb +++ b/app/models/version.rb @@ -106,7 +106,7 @@ module FixedIssuesExtension @issues_progress[open] ||= begin progress = 0 if count > 0 - done = open(open).sum do |c| + done = self.open(open).sum do |c| estimated = c.total_estimated_hours.to_f estimated = estimated_average unless estimated > 0.0 ratio = c.closed? ? 100 : (c.done_ratio || 0)