rubocop: fix Lint/IneffectiveAccessModifier in app/models/auth_source_ldap.rb (#32470)

git-svn-id: http://svn.redmine.org/redmine/trunk@19085 e93f8b46-1217-0410-a6f0-8f06a7374b81

.rubocop_todo.yml

@@ -390,10 +390,6 @@ Lint/HandleExceptions:
     - 'lib/redmine/scm/adapters/cvs_adapter.rb'
     - 'lib/redmine/scm/adapters/subversion_adapter.rb'
 
-Lint/IneffectiveAccessModifier:
-  Exclude:
-    - 'app/models/auth_source_ldap.rb'
-
 Lint/InterpolationCheck:
   Exclude:
     - 'app/models/user.rb'

app/models/auth_source_ldap.rb

@@ -244,10 +244,13 @@ class AuthSourceLdap < AuthSource
     attrs
   end
 
-  def self.get_attr(entry, attr_name)
+  # Singleton class method is public
-    if !attr_name.blank?
+  class << self
-      value = entry[attr_name].is_a?(Array) ? entry[attr_name].first : entry[attr_name]
+    def get_attr(entry, attr_name)
-      value.to_s.force_encoding('UTF-8')
+      if !attr_name.blank?
+        value = entry[attr_name].is_a?(Array) ? entry[attr_name].first : entry[attr_name]
+        value.to_s.force_encoding('UTF-8')
+      end
     end
   end
 end