meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-20 15:31:12 +00:00
Code Issues Releases Wiki Activity

Fixed: LabelledFormBuilder#label outputs 2 label elements (#18679).

Browse Source 
Patch by Masato NODA.

git-svn-id: http://svn.redmine.org/redmine/trunk@13786 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang 2014-12-21 20:19:39 +00:00
parent c0800b330c
commit b8a586c475
2 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/redmine/views/labelled_form_builder.rb
View File

@ -20,7 +20,7 @@ require 'action_view/helpers/form_helper'
class Redmine::Views::LabelledFormBuilder < ActionView::Helpers::FormBuilder
include Redmine::I18n
(field_helpers.map(&:to_s) - %w(radio_button hidden_field fields_for check_box) +
(field_helpers.map(&:to_s) - %w(radio_button hidden_field fields_for check_box label) +
%w(date_select)).each do |selector|
src = <<-END_SRC
def #{selector}(field, options = {})

28
test/unit/lib/redmine/views/labelled_form_builder_test.rb Normal file
View File

@ -0,0 +1,28 @@
# Redmine - project management software
# Copyright (C) 2006-2014 Jean-Philippe Lang
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
require File.expand_path('../../../../../test_helper', __FILE__)
class Redmine::Views::LabelledFormBuilderTest < ActionView::TestCase
def test_label_should_output_one_element
labelled_form_for(Issue.new) do |f|
output = f.label :subject
assert_equal output, '<label for="issue_subject">Subject</label>'
end
end
end