diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index a43e97d78..7d8d061fc 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -393,7 +393,6 @@ Lint/IneffectiveAccessModifier: - 'app/models/attachment.rb' - 'app/models/issue.rb' - 'app/models/mail_handler.rb' - - 'app/models/mailer.rb' - 'app/models/user.rb' Lint/InterpolationCheck: diff --git a/app/models/mailer.rb b/app/models/mailer.rb index 3f3b00e7c..48bf0eed4 100644 --- a/app/models/mailer.rb +++ b/app/models/mailer.rb @@ -742,28 +742,31 @@ class Mailer < ActionMailer::Base h.each { |k,v| headers["X-Redmine-#{k}"] = v.to_s } end - def self.token_for(object, user) - timestamp = object.send(object.respond_to?(:created_on) ? :created_on : :updated_on) - hash = [ - "redmine", - "#{object.class.name.demodulize.underscore}-#{object.id}", - timestamp.utc.strftime("%Y%m%d%H%M%S") - ] - hash << user.id if user - host = Setting.mail_from.to_s.strip.gsub(%r{^.*@|>}, '') - host = "#{::Socket.gethostname}.redmine" if host.empty? - "#{hash.join('.')}@#{host}" - end + # Singleton class method is public + class << self + def token_for(object, user) + timestamp = object.send(object.respond_to?(:created_on) ? :created_on : :updated_on) + hash = [ + "redmine", + "#{object.class.name.demodulize.underscore}-#{object.id}", + timestamp.utc.strftime("%Y%m%d%H%M%S") + ] + hash << user.id if user + host = Setting.mail_from.to_s.strip.gsub(%r{^.*@|>}, '') + host = "#{::Socket.gethostname}.redmine" if host.empty? + "#{hash.join('.')}@#{host}" + end - # Returns a Message-Id for the given object - def self.message_id_for(object, user) - token_for(object, user) - end + # Returns a Message-Id for the given object + def message_id_for(object, user) + token_for(object, user) + end - # Returns a uniq token for a given object referenced by all notifications - # related to this object - def self.references_for(object, user) - token_for(object, user) + # Returns a uniq token for a given object referenced by all notifications + # related to this object + def references_for(object, user) + token_for(object, user) + end end def message_id(object)