From ab3128106e643bd0bfb720ebb96c1671a78d2822 Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Wed, 7 Apr 2021 05:30:01 +0000 Subject: [PATCH] The result of Attachment.latest_attach is unstable if attachments have the same timestamp (#34999). MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Patch by Pavel Rosický. git-svn-id: http://svn.redmine.org/redmine/trunk@20923 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/models/attachment.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/attachment.rb b/app/models/attachment.rb index 620ea89ef..241ed0d70 100644 --- a/app/models/attachment.rb +++ b/app/models/attachment.rb @@ -370,7 +370,7 @@ class Attachment < ActiveRecord::Base def self.latest_attach(attachments, filename) return unless filename.valid_encoding? - attachments.sort_by(&:created_on).reverse.detect do |att| + attachments.sort_by{|attachment| [attachment.created_on, attachment.id]}.reverse.detect do |att| filename.casecmp?(att.filename) end end