From aa8c59a38909c8c84fb70e77fdaebc9e3aaf447c Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Thu, 19 Sep 2019 06:11:15 +0000 Subject: [PATCH] code cleanup: rubocop: fix Layout/IndentAssignment in app/helpers/issues_helper.rb git-svn-id: http://svn.redmine.org/redmine/trunk@18479 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- .rubocop_todo.yml | 1 - app/helpers/issues_helper.rb | 8 +++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 72ef997a7..e6c0d731c 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -248,7 +248,6 @@ Layout/ExtraSpacing: Layout/IndentAssignment: Exclude: - 'app/helpers/application_helper.rb' - - 'app/helpers/issues_helper.rb' - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' - 'test/unit/lib/redmine/helpers/gantt_test.rb' diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb index addd66dc9..7772ced60 100644 --- a/app/helpers/issues_helper.rb +++ b/app/helpers/issues_helper.rb @@ -264,16 +264,14 @@ module IssuesHelper def render_full_width_custom_fields_rows(issue) values = issue.visible_custom_field_values.select {|value| value.custom_field.full_width_layout?} return if values.empty? - s = ''.html_safe values.each_with_index do |value, i| attr_value_tag = custom_field_value_tag(value) next if attr_value_tag.blank? - content = - content_tag('hr') + - content_tag('p', content_tag('strong', custom_field_name_tag(value.custom_field) )) + - content_tag('div', attr_value_tag, class: 'value') + content_tag('hr') + + content_tag('p', content_tag('strong', custom_field_name_tag(value.custom_field) )) + + content_tag('div', attr_value_tag, class: 'value') s << content_tag('div', content, class: "#{value.custom_field.css_classes} attribute") end s