From a531f805f82696ad86b5addf1b56839b4195b7e2 Mon Sep 17 00:00:00 2001
From: Marius Balteanu <marius.balteanu@zitec.com>
Date: Wed, 26 Mar 2025 21:08:50 +0000
Subject: [PATCH] Replaces legacy icons with SVG icons in error explanation
 (#41952).

git-svn-id: https://svn.redmine.org/redmine/trunk@23563 e93f8b46-1217-0410-a6f0-8f06a7374b81
---
 app/assets/stylesheets/application.css   | 22 ++++++++++++++++------
 app/helpers/application_helper.rb        |  4 +++-
 app/helpers/settings_helper.rb           |  6 +++++-
 app/views/common/error.html.erb          |  5 ++++-
 app/views/issue_relations/_form.html.erb |  1 +
 app/views/issues/bulk_edit.html.erb      |  2 ++
 app/views/repositories/annotate.html.erb |  5 ++++-
 app/views/timelog/bulk_edit.html.erb     |  1 +
 8 files changed, 36 insertions(+), 10 deletions(-)

diff --git a/app/assets/stylesheets/application.css b/app/assets/stylesheets/application.css
index 849b5e901..d9882f9ca 100644
--- a/app/assets/stylesheets/application.css
+++ b/app/assets/stylesheets/application.css
@@ -1194,11 +1194,9 @@ input.autocomplete.ajax-loading {
 }
 
 div.flash {margin-top: 8px;}
-div.flash:has(svg) {
-  padding-left: 10px;
-}
-div.flash svg.icon-svg {
+div.flash svg.icon-svg, #errorExplanation svg.icon-svg {
   margin-right: 4px;
+  margin-left: -26px;
 }
 
 div.flash.error, #errorExplanation {
@@ -1206,13 +1204,25 @@ div.flash.error, #errorExplanation {
   border-color: #d88;
   color: #880000;
 }
-div.flash.error:not(:has(svg)), #errorExplanation {
+div.flash.error:not(:has(svg)), #errorExplanation:not(:has(svg)) {
   background: url(/exclamation.png) 8px 50% no-repeat #ffe3e3;
 }
-div.flash.error svg.icon-svg {
+div.flash.error svg.icon-svg, #errorExplanation svg.icon-svg {
   stroke: #880000;
 }
 
+#errorExplanation:has(svg) {
+  position: relative;
+}
+
+#errorExplanation:has(svg) > svg.icon-svg {
+  position: absolute;
+  top: 50%;
+  bottom: 50%;
+  margin-left: -24px;
+  margin-top: -9px;
+}
+
 div.flash.notice {
   background-color: #dfffdf;
   border-color: #9fcf9f;
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index 7991b9b43..9bb26bdec 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -1576,7 +1576,9 @@ module ApplicationHelper
   def render_error_messages(errors)
     html = +""
     if errors.present?
-      html << "<div id='errorExplanation'><ul>\n"
+      html << "<div id='errorExplanation'>\n"
+      html << notice_icon('error')
+      html << "<ul>\n"
       errors.each do |error|
         html << "<li>#{h error}</li>\n"
       end
diff --git a/app/helpers/settings_helper.rb b/app/helpers/settings_helper.rb
index 1fb57b2d7..39a836a03 100644
--- a/app/helpers/settings_helper.rb
+++ b/app/helpers/settings_helper.rb
@@ -48,7 +48,11 @@ module SettingsHelper
     errors.each do |name, message|
       s << content_tag('li', content_tag('b', l("setting_#{name}")) + " " + message)
     end
-    content_tag('div', content_tag('ul', s), :id => 'errorExplanation')
+
+    h = ''.html_safe
+    h << notice_icon('error')
+    h << content_tag('ul', s)
+    content_tag('div', h, :id => 'errorExplanation')
   end
 
   def setting_value(setting)
diff --git a/app/views/common/error.html.erb b/app/views/common/error.html.erb
index 007063f9c..e1c6ef82f 100644
--- a/app/views/common/error.html.erb
+++ b/app/views/common/error.html.erb
@@ -1,7 +1,10 @@
 <h2><%= @status %></h2>
 
 <% if @message.present? %>
-  <p id="errorExplanation"><%= @message %></p>
+  <p id="errorExplanation">
+    <%= notice_icon('error') %>
+    <%= @message %>
+  </p>
 <% end %>
 
 <% if @archived_project && User.current.admin? %>
diff --git a/app/views/issue_relations/_form.html.erb b/app/views/issue_relations/_form.html.erb
index 97fe78cc6..b55e93eac 100644
--- a/app/views/issue_relations/_form.html.erb
+++ b/app/views/issue_relations/_form.html.erb
@@ -2,6 +2,7 @@
 <% if @unsaved_relations && @unsaved_relations.any? %>
   <% unsaved_relations_ids = @unsaved_relations.map(&:issue_to_id).compact.join(", ") %>
   <div id="errorExplanation">
+    <%= notice_icon('error') %>
     <ul>
       <% relation_error_messages(@unsaved_relations).each do |message| %>
         <li><%= message %></li>
diff --git a/app/views/issues/bulk_edit.html.erb b/app/views/issues/bulk_edit.html.erb
index a379305be..b8bf87beb 100644
--- a/app/views/issues/bulk_edit.html.erb
+++ b/app/views/issues/bulk_edit.html.erb
@@ -2,6 +2,7 @@
 
 <% if @saved_issues && @unsaved_issues.present? %>
 <div id="errorExplanation">
+  <%= notice_icon('error') %>
   <span>
     <%= l(:notice_failed_to_save_issues,
         :count => @unsaved_issues.size,
@@ -241,6 +242,7 @@
 
 <% if @values_by_custom_field.present? %>
 <div class="flash warning">
+  <%= notice_icon('warning') %>
   <%= l(:warning_fields_cleared_on_bulk_edit) %>:<br />
   <%= safe_join(@values_by_custom_field.map {|field, ids| content_tag "span", "#{field.name} (#{ids.size})"}, ', ') %>
 </div>
diff --git a/app/views/repositories/annotate.html.erb b/app/views/repositories/annotate.html.erb
index db91ef913..e532714e4 100644
--- a/app/views/repositories/annotate.html.erb
+++ b/app/views/repositories/annotate.html.erb
@@ -51,7 +51,10 @@
 </table>
 </div>
 <% else %>
-<p id="errorExplanation"><%= @error_message %></p>
+<p id="errorExplanation">
+  <%= notice_icon('error') %>
+  <%= @error_message %>
+</p>
 <% end %>
 
 <% html_title(l(:button_annotate)) -%>
diff --git a/app/views/timelog/bulk_edit.html.erb b/app/views/timelog/bulk_edit.html.erb
index a4cb0c8af..4f496470a 100644
--- a/app/views/timelog/bulk_edit.html.erb
+++ b/app/views/timelog/bulk_edit.html.erb
@@ -2,6 +2,7 @@
 
 <% if @unsaved_time_entries.present? %>
 <div id="errorExplanation">
+  <%= notice_icon('error') %>
   <span>
     <%= l(:notice_failed_to_save_time_entries,
         :count => @unsaved_time_entries.size,