diff --git a/app/controllers/queries_controller.rb b/app/controllers/queries_controller.rb index 348806198..56283dc30 100644 --- a/app/controllers/queries_controller.rb +++ b/app/controllers/queries_controller.rb @@ -126,7 +126,7 @@ class QueriesController < ApplicationController @query.column_names = nil if params[:default_columns] @query.sort_criteria = (params[:query] && params[:query][:sort_criteria]) || @query.sort_criteria @query.name = params[:query] && params[:query][:name] - if User.current.allowed_to?(:manage_public_queries, @query.project) || User.current.admin? || (@query.type == 'ProjectQuery' && User.current.allowed_to?(:manage_public_queries, @query.project, :global => true)) + if User.current.allowed_to?(:manage_public_queries, @query.project) || User.current.admin? @query.visibility = (params[:query] && params[:query][:visibility]) || Query::VISIBILITY_PRIVATE @query.role_ids = params[:query] && params[:query][:role_ids] else diff --git a/app/views/queries/_form.html.erb b/app/views/queries/_form.html.erb index 071496f52..7227a6c5f 100644 --- a/app/views/queries/_form.html.erb +++ b/app/views/queries/_form.html.erb @@ -8,8 +8,7 @@ <%= text_field 'query', 'name', :size => 80 %>
<% if User.current.admin? || - User.current.allowed_to?(:manage_public_queries, @query.project) || - @query.type == 'ProjectQuery' && User.current.allowed_to?(:manage_public_queries, @query.project, :global => true) %> + User.current.allowed_to?(:manage_public_queries, @query.project) %>diff --git a/test/functional/queries_controller_test.rb b/test/functional/queries_controller_test.rb index 923202b02..55c46478c 100644 --- a/test/functional/queries_controller_test.rb +++ b/test/functional/queries_controller_test.rb @@ -495,7 +495,7 @@ class QueriesControllerTest < Redmine::ControllerTest end def test_create_public_project_query - @request.session[:user_id] = 2 + @request.session[:user_id] = 1 q = new_record(ProjectQuery) do post :create, :params => {