meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-01-31 19:47:14 +00:00
Code Issues Releases Wiki Activity

Add tests for current alt attribute behavior in images (#40650).

Browse Source 
Patch by Katsuya HIDAKA (@hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@22844 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA 2024-05-24 02:16:23 +00:00
parent 81e0a93238
commit 9293b72a45
2 changed files with 61 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
test/helpers/application_helper_test.rb
View File

@ -198,6 +198,39 @@ class ApplicationHelperTest < Redmine::HelperTest
end
end
def test_attached_image_alt_attribute_with_textile
attachments = Attachment.all
with_settings text_formatting: 'textile' do
# When alt text is set
assert_match %r[<img src=".+?" title="This is a logo" alt="This is a logo" loading=".+?" title="alt text" alt="alt text" />],
textilizable('!logo.gif(alt text)!', attachments: attachments)
# When alt text and style are set
assert_match %r[<img src=".+?" title="This is a logo" alt="This is a logo" loading=".+?" style="width:100px;" title="alt text" alt="alt text" />],
textilizable('!{width:100px}logo.gif(alt text)!', attachments: attachments)
# When alt text is not set
assert_match %r[<img src=".+?" title="This is a logo" alt="This is a logo" loading=".+?" />],
textilizable('!logo.gif!', attachments: attachments)
# When alt text is not set and the attachment has no description
assert_match %r[<img src=".+?" alt="" loading=".+?" />],
textilizable('!testfile.PNG!', attachments: attachments)
# When no matching attachments are found
assert_match %r[<img src=".+?" alt="" />],
textilizable('!no-match.jpg!', attachments: attachments)
assert_match %r[<img src=".+?" alt="alt text" />],
textilizable('!no-match.jpg(alt text)!', attachments: attachments)
# When no attachment is registered
assert_match %r[<img src=".+?" alt="" />],
textilizable('!logo.gif!', attachments: [])
assert_match %r[<img src=".+?" alt="alt text" />],
textilizable('!logo.gif(alt text)!', attachments: [])
end
end
def test_attached_images_on_issue
issue = Issue.generate!
attachment_1 = Attachment.generate!(:file => mock_file_with_options(:original_filename => "attached_on_issue.png"), :container => issue)

28
test/unit/lib/redmine/wiki_formatting/common_mark/application_helper_test.rb
View File

@ -62,5 +62,33 @@ class Redmine::WikiFormatting::CommonMark::ApplicationHelperTest < Redmine::Help
end
end
def test_attached_image_alt_attribute_with_madkrown
attachments = Attachment.all
with_settings text_formatting: 'common_mark' do
# When alt text is set
assert_match %r[<img src=".+?" alt="alt text" loading=".+?">],
textilizable('![alt text](logo.gif)', attachments: attachments)
# When alt text is not set
assert_match %r[<img src=".+?" title="This is a logo" alt="This is a logo" loading=".+?">],
textilizable('![](logo.gif)', attachments: attachments)
# When alt text is not set and the attachment has no description
assert_match %r[<img src=".+?" alt="" loading=".+?">],
textilizable('![](testfile.PNG)', attachments: attachments)
# When no matching attachments are found
assert_match %r[<img src=".+?" alt="">],
textilizable('![](no-match.jpg)', attachments: attachments)
assert_match %r[<img src=".+?" alt="alt text">],
textilizable('![alt text](no-match.jpg)', attachments: attachments)
# When no attachment is registered
assert_match %r[<img src=".+?" alt="">],
textilizable('![](logo.gif)', attachments: [])
assert_match %r[<img src=".+?" alt="alt text">],
textilizable('![alt text](logo.gif)', attachments: [])
end
end
end
end