meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-02-01 03:57:15 +00:00
Code Issues Releases Wiki Activity

Use start_with? or end_with? to check the first or last character of a string (#37591).

Browse Source 
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21774 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA 2022-08-24 13:45:20 +00:00
parent f8033a069f
commit 80b7a83940
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/redmine/diff_table.rb
View File

@ -118,7 +118,7 @@ module Redmine
end
def parse_line(line, type="inline")
if line[0, 1] == "+"
if line.start_with?('+')
diff = diff_for_added_line
diff.line_right = line[1..-1]
diff.nb_line_right = @line_num_r
@ -126,7 +126,7 @@ module Redmine
@line_num_r += 1
@added += 1
true
elsif line[0, 1] == "-"
elsif line.start_with?('-')
diff = Diff.new
diff.line_left = line[1..-1]
diff.nb_line_left = @line_num_l
@ -137,7 +137,7 @@ module Redmine
true
else
write_offsets
if /\s/.match?(line[0, 1])
if line.start_with?(/\s/)
diff = Diff.new
diff.line_right = line[1..-1]
diff.nb_line_right = @line_num_r

2
lib/redmine/export/pdf.rb
View File

@ -120,7 +120,7 @@ module Redmine
end
def get_sever_url(url)
if !empty_string(url) and (url[0, 1] == '/')
if !empty_string(url) and url.start_with?('/')
Setting.host_name.split('/')[0] + url
else
url

6
lib/redmine/scm/adapters/abstract_adapter.rb
View File

@ -158,12 +158,12 @@ module Redmine
def with_leading_slash(path)
path ||= ''
(path[0, 1]!="/") ? "/#{path}" : path
path.start_with?('/') ? path : "/#{path}"
end
def with_trailling_slash(path)
path ||= ''
(path[-1, 1] == "/") ? path : "#{path}/"
path.end_with?('/') ? path : "#{path}/"
end
def without_leading_slash(path)
@ -173,7 +173,7 @@ module Redmine
def without_trailling_slash(path)
path ||= ''
(path[-1, 1] == "/") ? path[0..-2] : path
path.end_with?('/') ? path[0..-2] : path
end
def valid_name?(name)